From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: wei.huang2@amd.com, terry.bowman@amd.com, Jon.Grimm@amd.com,
linux-kernel@vger.kernel.org, daniel.m.jordan@oracle.com,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/amd: Fix I/O page table memory leak
Date: Mon, 14 Feb 2022 12:52:53 +0100 [thread overview]
Message-ID: <YgpClRRdOR/1DXJE@8bytes.org> (raw)
In-Reply-To: <20220210154745.11524-1-suravee.suthikulpanit@amd.com>
On Thu, Feb 10, 2022 at 09:47:45AM -0600, Suravee Suthikulpanit wrote:
> The current logic updates the I/O page table mode for the domain
> before calling the logic to free memory used for the page table.
> This results in IOMMU page table memory leak, and can be observed
> when launching VM w/ pass-through devices.
>
> Fix by freeing the memory used for page table before updating the mode.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Reported-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> Tested-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Fixes: e42ba0633064 ("iommu/amd: Restructure code for freeing page table")
> Link: https://lore.kernel.org/all/20220118194720.urjgi73b7c3tq2o6@oracle.com/
> ---
> drivers/iommu/amd/io_pgtable.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
daniel.m.jordan@oracle.com, Jon.Grimm@amd.com,
wei.huang2@amd.com, terry.bowman@amd.com
Subject: Re: [PATCH] iommu/amd: Fix I/O page table memory leak
Date: Mon, 14 Feb 2022 12:52:53 +0100 [thread overview]
Message-ID: <YgpClRRdOR/1DXJE@8bytes.org> (raw)
In-Reply-To: <20220210154745.11524-1-suravee.suthikulpanit@amd.com>
On Thu, Feb 10, 2022 at 09:47:45AM -0600, Suravee Suthikulpanit wrote:
> The current logic updates the I/O page table mode for the domain
> before calling the logic to free memory used for the page table.
> This results in IOMMU page table memory leak, and can be observed
> when launching VM w/ pass-through devices.
>
> Fix by freeing the memory used for page table before updating the mode.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Reported-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> Tested-by: Daniel Jordan <daniel.m.jordan@oracle.com>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Fixes: e42ba0633064 ("iommu/amd: Restructure code for freeing page table")
> Link: https://lore.kernel.org/all/20220118194720.urjgi73b7c3tq2o6@oracle.com/
> ---
> drivers/iommu/amd/io_pgtable.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
next prev parent reply other threads:[~2022-02-14 11:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 15:47 [PATCH] iommu/amd: Fix I/O page table memory leak Suravee Suthikulpanit via iommu
2022-02-10 15:47 ` Suravee Suthikulpanit
2022-02-14 11:52 ` Joerg Roedel [this message]
2022-02-14 11:52 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgpClRRdOR/1DXJE@8bytes.org \
--to=joro@8bytes.org \
--cc=Jon.Grimm@amd.com \
--cc=daniel.m.jordan@oracle.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=terry.bowman@amd.com \
--cc=wei.huang2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.