All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
	will@kernel.org
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Check for error num after setting mask
Date: Mon, 14 Feb 2022 13:41:27 +0100	[thread overview]
Message-ID: <YgpN9zvNFohAESii@8bytes.org> (raw)
In-Reply-To: <c95e5d3a-d2b4-dcc1-b6ba-2e4e9ebc5bb0@arm.com>

On Mon, Feb 14, 2022 at 12:32:21PM +0000, Robin Murphy wrote:
> In this particular case it cannot fail on any system the driver actually
> runs on - it's a platform device so the dma_mask pointer is always
> initialised, then dma_direct_supported() on arm64 will always return true
> for any mask wider than 32 bits, while arm_dma_supported() will also always
> pass since a 32-bit system cannot have memory above 40 bits either.
> 
> There's no great harm in adding the check for the sake of consistency, I
> guess, but it's purely cosmetic and not fixing anything.

Okay, thanks Robin and Nikita for looking to quickly into this. I will
apply it for 5.18 just to be on the safe side if the above assumptions
change.

Regards,

	Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
	will@kernel.org, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Check for error num after setting mask
Date: Mon, 14 Feb 2022 13:41:27 +0100	[thread overview]
Message-ID: <YgpN9zvNFohAESii@8bytes.org> (raw)
In-Reply-To: <c95e5d3a-d2b4-dcc1-b6ba-2e4e9ebc5bb0@arm.com>

On Mon, Feb 14, 2022 at 12:32:21PM +0000, Robin Murphy wrote:
> In this particular case it cannot fail on any system the driver actually
> runs on - it's a platform device so the dma_mask pointer is always
> initialised, then dma_direct_supported() on arm64 will always return true
> for any mask wider than 32 bits, while arm_dma_supported() will also always
> pass since a 32-bit system cannot have memory above 40 bits either.
> 
> There's no great harm in adding the check for the sake of consistency, I
> guess, but it's purely cosmetic and not fixing anything.

Okay, thanks Robin and Nikita for looking to quickly into this. I will
apply it for 5.18 just to be on the safe side if the above assumptions
change.

Regards,

	Joerg

  reply	other threads:[~2022-02-14 12:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-06  2:43 [PATCH] iommu/ipmmu-vmsa: Check for error num after setting mask Jiasheng Jiang
2022-01-06  2:43 ` Jiasheng Jiang
2022-02-14 11:43 ` Joerg Roedel
2022-02-14 11:43   ` Joerg Roedel
2022-02-14 12:00   ` Nikita Yushchenko
2022-02-14 12:00     ` Nikita Yushchenko
2022-02-14 12:32   ` Robin Murphy
2022-02-14 12:32     ` Robin Murphy
2022-02-14 12:41     ` Joerg Roedel [this message]
2022-02-14 12:41       ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgpN9zvNFohAESii@8bytes.org \
    --to=joro@8bytes.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiasheng@iscas.ac.cn \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.