From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: iommu@lists.linux-foundation.org, will@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: Remove trivial ops->capable implementations
Date: Mon, 14 Feb 2022 14:05:10 +0100 [thread overview]
Message-ID: <YgpThrw8QWgc4GuR@8bytes.org> (raw)
In-Reply-To: <8413578c6f8a7cf75530b00cba8f10f5b88f8517.1644495614.git.robin.murphy@arm.com>
On Thu, Feb 10, 2022 at 12:29:05PM +0000, Robin Murphy wrote:
> Implementing ops->capable to always return false is pointless since it's
> the default behaviour anyway. Clean up the unnecessary implementations.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Spinning this out of my bus ops stuff (currently 30 patches and
> counting...) since it would be better off alongside Baolu's cleanup
> series to avoid conflicts, and I want to depend on those patches for
> dev_iommu_ops() anyway.
>
> drivers/iommu/msm_iommu.c | 6 ------
> drivers/iommu/tegra-gart.c | 6 ------
> drivers/iommu/tegra-smmu.c | 6 ------
> 3 files changed, 18 deletions(-)
Applied, thanks Robin.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: will@kernel.org, iommu@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com
Subject: Re: [PATCH] iommu: Remove trivial ops->capable implementations
Date: Mon, 14 Feb 2022 14:05:10 +0100 [thread overview]
Message-ID: <YgpThrw8QWgc4GuR@8bytes.org> (raw)
In-Reply-To: <8413578c6f8a7cf75530b00cba8f10f5b88f8517.1644495614.git.robin.murphy@arm.com>
On Thu, Feb 10, 2022 at 12:29:05PM +0000, Robin Murphy wrote:
> Implementing ops->capable to always return false is pointless since it's
> the default behaviour anyway. Clean up the unnecessary implementations.
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> ---
>
> Spinning this out of my bus ops stuff (currently 30 patches and
> counting...) since it would be better off alongside Baolu's cleanup
> series to avoid conflicts, and I want to depend on those patches for
> dev_iommu_ops() anyway.
>
> drivers/iommu/msm_iommu.c | 6 ------
> drivers/iommu/tegra-gart.c | 6 ------
> drivers/iommu/tegra-smmu.c | 6 ------
> 3 files changed, 18 deletions(-)
Applied, thanks Robin.
next prev parent reply other threads:[~2022-02-14 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 12:29 [PATCH] iommu: Remove trivial ops->capable implementations Robin Murphy
2022-02-10 12:29 ` Robin Murphy
2022-02-11 1:33 ` Lu Baolu
2022-02-11 1:33 ` Lu Baolu
2022-02-14 13:05 ` Joerg Roedel [this message]
2022-02-14 13:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgpThrw8QWgc4GuR@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.