All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] mfd: stmfx: Improve error message triggered by regulator fault in .remove()
Date: Mon, 14 Feb 2022 13:46:37 +0000	[thread overview]
Message-ID: <YgpdPTDurgsvR9mk@google.com> (raw)
In-Reply-To: <20220207081709.27288-1-u.kleine-koenig@pengutronix.de>

On Mon, 07 Feb 2022, Uwe Kleine-König wrote:

> Returning a non-zero value in an i2c remove callback results in the i2c
> core emitting a very generic error message ("remove failed (-ESOMETHING),
> will be ignored") and as the message indicates not further error handling
> is done.
> 
> Instead emit a more specific error message and then return zero in
> .remove().
> 
> The long-term goal is to make the i2c remove prototype return void, making
> all implementations return 0 is preparatory work for this change.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mfd/stmfx.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
> index e095a3930142..16631c675f2f 100644
> --- a/drivers/mfd/stmfx.c
> +++ b/drivers/mfd/stmfx.c
> @@ -392,17 +392,21 @@ static int stmfx_chip_init(struct i2c_client *client)
>  	return ret;
>  }
>  
> -static int stmfx_chip_exit(struct i2c_client *client)
> +static void stmfx_chip_exit(struct i2c_client *client)
>  {
>  	struct stmfx *stmfx = i2c_get_clientdata(client);
>  
>  	regmap_write(stmfx->map, STMFX_REG_IRQ_SRC_EN, 0);
>  	regmap_write(stmfx->map, STMFX_REG_SYS_CTRL, 0);
>  
> -	if (stmfx->vdd)
> -		return regulator_disable(stmfx->vdd);
> +	if (stmfx->vdd) {
> +		int ret = regulator_disable(stmfx->vdd);
>  
> -	return 0;
> +		if (ret)

Nit: Premise of the patch is fine, but please can you use the standard
function call, check the return value format please.  Something about
this is triggering my OCD! :)

     	int ret;

	ret = regulator_disable(stmfx->vdd);
	if (ret)
		do_thing();

> +			dev_err(&client->dev,
> +				"Failed to disable vdd regulator: %pe\n",
> +				ERR_PTR(ret));
> +	}
>  }
>  
>  static int stmfx_probe(struct i2c_client *client,
> @@ -466,7 +470,9 @@ static int stmfx_remove(struct i2c_client *client)
>  {
>  	stmfx_irq_exit(client);
>  
> -	return stmfx_chip_exit(client);
> +	stmfx_chip_exit(client);
> +
> +	return 0;
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> 
> base-commit: dcb85f85fa6f142aae1fe86f399d4503d49f2b60

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] mfd: stmfx: Improve error message triggered by regulator fault in .remove()
Date: Mon, 14 Feb 2022 13:46:37 +0000	[thread overview]
Message-ID: <YgpdPTDurgsvR9mk@google.com> (raw)
In-Reply-To: <20220207081709.27288-1-u.kleine-koenig@pengutronix.de>

On Mon, 07 Feb 2022, Uwe Kleine-König wrote:

> Returning a non-zero value in an i2c remove callback results in the i2c
> core emitting a very generic error message ("remove failed (-ESOMETHING),
> will be ignored") and as the message indicates not further error handling
> is done.
> 
> Instead emit a more specific error message and then return zero in
> .remove().
> 
> The long-term goal is to make the i2c remove prototype return void, making
> all implementations return 0 is preparatory work for this change.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/mfd/stmfx.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
> index e095a3930142..16631c675f2f 100644
> --- a/drivers/mfd/stmfx.c
> +++ b/drivers/mfd/stmfx.c
> @@ -392,17 +392,21 @@ static int stmfx_chip_init(struct i2c_client *client)
>  	return ret;
>  }
>  
> -static int stmfx_chip_exit(struct i2c_client *client)
> +static void stmfx_chip_exit(struct i2c_client *client)
>  {
>  	struct stmfx *stmfx = i2c_get_clientdata(client);
>  
>  	regmap_write(stmfx->map, STMFX_REG_IRQ_SRC_EN, 0);
>  	regmap_write(stmfx->map, STMFX_REG_SYS_CTRL, 0);
>  
> -	if (stmfx->vdd)
> -		return regulator_disable(stmfx->vdd);
> +	if (stmfx->vdd) {
> +		int ret = regulator_disable(stmfx->vdd);
>  
> -	return 0;
> +		if (ret)

Nit: Premise of the patch is fine, but please can you use the standard
function call, check the return value format please.  Something about
this is triggering my OCD! :)

     	int ret;

	ret = regulator_disable(stmfx->vdd);
	if (ret)
		do_thing();

> +			dev_err(&client->dev,
> +				"Failed to disable vdd regulator: %pe\n",
> +				ERR_PTR(ret));
> +	}
>  }
>  
>  static int stmfx_probe(struct i2c_client *client,
> @@ -466,7 +470,9 @@ static int stmfx_remove(struct i2c_client *client)
>  {
>  	stmfx_irq_exit(client);
>  
> -	return stmfx_chip_exit(client);
> +	stmfx_chip_exit(client);
> +
> +	return 0;
>  }
>  
>  #ifdef CONFIG_PM_SLEEP
> 
> base-commit: dcb85f85fa6f142aae1fe86f399d4503d49f2b60

-- 
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2022-02-14 13:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  8:17 [PATCH] mfd: stmfx: Improve error message triggered by regulator fault in .remove() Uwe Kleine-König
2022-02-07  8:17 ` Uwe Kleine-König
2022-02-14 13:46 ` Lee Jones [this message]
2022-02-14 13:46   ` Lee Jones
2022-02-14 14:06   ` Uwe Kleine-König
2022-02-14 14:06     ` Uwe Kleine-König
2022-02-14 14:30     ` Lee Jones
2022-02-14 14:30       ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgpdPTDurgsvR9mk@google.com \
    --to=lee.jones@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.