From: Joerg Roedel <joro@8bytes.org>
To: John Garry <john.garry@huawei.com>
Cc: mst@redhat.com, will@kernel.org, jasowang@redhat.com,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, iommu@lists.linux-foundation.org,
robin.murphy@arm.com
Subject: Re: [PATCH v2] iommu/iova: Separate out rcache init
Date: Mon, 14 Feb 2022 15:45:11 +0100 [thread overview]
Message-ID: <Ygpq9zvzGsFu/FZ1@8bytes.org> (raw)
In-Reply-To: <1643882360-241739-1-git-send-email-john.garry@huawei.com>
On Thu, Feb 03, 2022 at 05:59:20PM +0800, John Garry wrote:
> Currently the rcache structures are allocated for all IOVA domains, even if
> they do not use "fast" alloc+free interface. This is wasteful of memory.
>
> In addition, fails in init_iova_rcaches() are not handled safely, which is
> less than ideal.
>
> Make "fast" users call a separate rcache init explicitly, which includes
> error checking.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: John Garry <john.garry@huawei.com>
Cc: mst@redhat.com, will@kernel.org, linuxarm@huawei.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, iommu@lists.linux-foundation.org,
robin.murphy@arm.com
Subject: Re: [PATCH v2] iommu/iova: Separate out rcache init
Date: Mon, 14 Feb 2022 15:45:11 +0100 [thread overview]
Message-ID: <Ygpq9zvzGsFu/FZ1@8bytes.org> (raw)
In-Reply-To: <1643882360-241739-1-git-send-email-john.garry@huawei.com>
On Thu, Feb 03, 2022 at 05:59:20PM +0800, John Garry wrote:
> Currently the rcache structures are allocated for all IOVA domains, even if
> they do not use "fast" alloc+free interface. This is wasteful of memory.
>
> In addition, fails in init_iova_rcaches() are not handled safely, which is
> less than ideal.
>
> Make "fast" users call a separate rcache init explicitly, which includes
> error checking.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
Applied, thanks.
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: John Garry <john.garry@huawei.com>
Cc: will@kernel.org, mst@redhat.com, jasowang@redhat.com,
robin.murphy@arm.com, xieyongji@bytedance.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linuxarm@huawei.com
Subject: Re: [PATCH v2] iommu/iova: Separate out rcache init
Date: Mon, 14 Feb 2022 15:45:11 +0100 [thread overview]
Message-ID: <Ygpq9zvzGsFu/FZ1@8bytes.org> (raw)
In-Reply-To: <1643882360-241739-1-git-send-email-john.garry@huawei.com>
On Thu, Feb 03, 2022 at 05:59:20PM +0800, John Garry wrote:
> Currently the rcache structures are allocated for all IOVA domains, even if
> they do not use "fast" alloc+free interface. This is wasteful of memory.
>
> In addition, fails in init_iova_rcaches() are not handled safely, which is
> less than ideal.
>
> Make "fast" users call a separate rcache init explicitly, which includes
> error checking.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
Applied, thanks.
next prev parent reply other threads:[~2022-02-14 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 9:59 [PATCH v2] iommu/iova: Separate out rcache init John Garry via iommu
2022-02-03 9:59 ` John Garry
2022-02-03 11:34 ` Michael S. Tsirkin
2022-02-03 11:34 ` Michael S. Tsirkin
2022-02-03 11:34 ` Michael S. Tsirkin
2022-02-14 13:26 ` John Garry via iommu
2022-02-14 13:26 ` John Garry
2022-02-14 14:29 ` Robin Murphy
2022-02-14 14:29 ` Robin Murphy
2022-02-14 14:29 ` Robin Murphy
2022-02-14 14:45 ` Joerg Roedel [this message]
2022-02-14 14:45 ` Joerg Roedel
2022-02-14 14:45 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygpq9zvzGsFu/FZ1@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.