From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field
Date: Tue, 15 Feb 2022 09:38:53 -0600 [thread overview]
Message-ID: <YgvJDVHYfuns03W5@yoga> (raw)
In-Reply-To: <20220215141643.3444941-5-dmitry.baryshkov@linaro.org>
On Tue 15 Feb 08:16 CST 2022, Dmitry Baryshkov wrote:
> We do not use MSM bus client, so drop bus_scaling_client field from
> dpu_encoder_virt.
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 401e37f50d54..480d02ccff8c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -127,7 +127,6 @@ enum dpu_enc_rc_states {
> * Virtual encoder registers itself with the DRM Framework as the encoder.
> * @base: drm_encoder base class for registration with DRM
> * @enc_spinlock: Virtual-Encoder-Wide Spin Lock for IRQ purposes
> - * @bus_scaling_client: Client handle to the bus scaling interface
> * @enabled: True if the encoder is active, protected by enc_lock
> * @num_phys_encs: Actual number of physical encoders contained.
> * @phys_encs: Container of physical encoders managed.
> @@ -172,7 +171,6 @@ enum dpu_enc_rc_states {
> struct dpu_encoder_virt {
> struct drm_encoder base;
> spinlock_t enc_spinlock;
> - uint32_t bus_scaling_client;
>
> bool enabled;
>
> --
> 2.34.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: freedreno@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
linux-arm-msm@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
dri-devel@lists.freedesktop.org,
Stephen Boyd <swboyd@chromium.org>, Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field
Date: Tue, 15 Feb 2022 09:38:53 -0600 [thread overview]
Message-ID: <YgvJDVHYfuns03W5@yoga> (raw)
In-Reply-To: <20220215141643.3444941-5-dmitry.baryshkov@linaro.org>
On Tue 15 Feb 08:16 CST 2022, Dmitry Baryshkov wrote:
> We do not use MSM bus client, so drop bus_scaling_client field from
> dpu_encoder_virt.
>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 401e37f50d54..480d02ccff8c 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -127,7 +127,6 @@ enum dpu_enc_rc_states {
> * Virtual encoder registers itself with the DRM Framework as the encoder.
> * @base: drm_encoder base class for registration with DRM
> * @enc_spinlock: Virtual-Encoder-Wide Spin Lock for IRQ purposes
> - * @bus_scaling_client: Client handle to the bus scaling interface
> * @enabled: True if the encoder is active, protected by enc_lock
> * @num_phys_encs: Actual number of physical encoders contained.
> * @phys_encs: Container of physical encoders managed.
> @@ -172,7 +171,6 @@ enum dpu_enc_rc_states {
> struct dpu_encoder_virt {
> struct drm_encoder base;
> spinlock_t enc_spinlock;
> - uint32_t bus_scaling_client;
>
> bool enabled;
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-02-15 15:44 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 14:16 [PATCH v2 0/8] drm/msm/dpu: cleanup dpu encoder code Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 14:16 ` [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 15:37 ` Bjorn Andersson
2022-02-15 15:37 ` Bjorn Andersson
2022-02-15 17:54 ` Abhinav Kumar
2022-02-15 17:54 ` Abhinav Kumar
2022-02-16 1:55 ` Stephen Boyd
2022-02-16 1:55 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 2/8] drm/msm: move struct msm_display_info to dpu driver Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-16 1:56 ` Stephen Boyd
2022-02-16 1:56 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 3/8] drm/msm/dpu: remove msm_dp cached in dpu_encoder_virt Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 15:38 ` Bjorn Andersson
2022-02-15 15:38 ` Bjorn Andersson
2022-02-16 1:57 ` Stephen Boyd
2022-02-16 1:57 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 15:38 ` Bjorn Andersson [this message]
2022-02-15 15:38 ` Bjorn Andersson
2022-02-16 1:57 ` Stephen Boyd
2022-02-16 1:57 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 5/8] drm/msm/dpu: encoder: drop unused mode_fixup callback Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 15:39 ` Bjorn Andersson
2022-02-15 15:39 ` Bjorn Andersson
2022-02-15 16:51 ` Abhinav Kumar
2022-02-15 16:51 ` Abhinav Kumar
2022-02-16 1:58 ` Stephen Boyd
2022-02-16 1:58 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 6/8] drm/msm/dpu: switch dpu_encoder to use atomic_mode_set Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-16 1:58 ` Stephen Boyd
2022-02-16 1:58 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-16 2:00 ` Stephen Boyd
2022-02-16 2:00 ` Stephen Boyd
2022-02-16 2:13 ` Dmitry Baryshkov
2022-02-16 2:13 ` Dmitry Baryshkov
2022-02-16 2:17 ` Stephen Boyd
2022-02-16 2:17 ` Stephen Boyd
2022-02-15 14:16 ` [PATCH v2 8/8] drm/msm/dpu: simplify intf allocation code Dmitry Baryshkov
2022-02-15 14:16 ` Dmitry Baryshkov
2022-02-15 15:42 ` Bjorn Andersson
2022-02-15 15:42 ` Bjorn Andersson
2022-02-15 17:51 ` Abhinav Kumar
2022-02-15 17:51 ` Abhinav Kumar
2022-02-17 1:18 ` Dmitry Baryshkov
2022-02-17 1:18 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgvJDVHYfuns03W5@yoga \
--to=bjorn.andersson@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.