From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: David Laight <David.Laight@aculab.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] net: Remove branch in csum_shift()
Date: Tue, 1 Mar 2022 12:37:18 +0000 [thread overview]
Message-ID: <Yh4TfnHuTmCqWZDb@shell.armlinux.org.uk> (raw)
In-Reply-To: <10309fa64833418a980a8d950d037357@AcuMS.aculab.com>
On Tue, Mar 01, 2022 at 11:41:06AM +0000, David Laight wrote:
> From: Christophe Leroy
> > Sent: 01 March 2022 11:15
> ...
> > Looks like ARM also does better code with the generic implementation as
> > it seems to have some looking like conditional instructions 'rorne' and
> > 'strne'.
>
> In arm32 (and I think arm64) every instruction is conditional.
Almost every instruction in arm32. There are a number of unconditional
instructions that were introduced.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: David Laight <David.Laight@aculab.com>
Cc: 'Christophe Leroy' <christophe.leroy@csgroup.eu>,
'Segher Boessenkool' <segher@kernel.crashing.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: Remove branch in csum_shift()
Date: Tue, 1 Mar 2022 12:37:18 +0000 [thread overview]
Message-ID: <Yh4TfnHuTmCqWZDb@shell.armlinux.org.uk> (raw)
In-Reply-To: <10309fa64833418a980a8d950d037357@AcuMS.aculab.com>
On Tue, Mar 01, 2022 at 11:41:06AM +0000, David Laight wrote:
> From: Christophe Leroy
> > Sent: 01 March 2022 11:15
> ...
> > Looks like ARM also does better code with the generic implementation as
> > it seems to have some looking like conditional instructions 'rorne' and
> > 'strne'.
>
> In arm32 (and I think arm64) every instruction is conditional.
Almost every instruction in arm32. There are a number of unconditional
instructions that were introduced.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-03-01 12:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 8:48 [PATCH] net: Remove branch in csum_shift() Christophe Leroy
2022-02-11 8:48 ` Christophe Leroy
2022-02-13 2:39 ` David Laight
2022-02-13 2:39 ` David Laight
2022-02-13 9:16 ` Segher Boessenkool
2022-02-13 9:16 ` Segher Boessenkool
2022-02-13 17:47 ` David Laight
2022-02-13 17:47 ` David Laight
2022-02-14 9:29 ` Segher Boessenkool
2022-02-14 9:29 ` Segher Boessenkool
2022-03-01 10:20 ` Christophe Leroy
2022-03-01 10:20 ` Christophe Leroy
2022-03-01 10:47 ` David Laight
2022-03-01 10:47 ` David Laight
2022-03-01 11:14 ` Christophe Leroy
2022-03-01 11:14 ` Christophe Leroy
2022-03-01 11:41 ` David Laight
2022-03-01 11:41 ` David Laight
2022-03-01 12:37 ` Russell King (Oracle) [this message]
2022-03-01 12:37 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh4TfnHuTmCqWZDb@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=David.Laight@aculab.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.