From: Petr Vorel <pvorel@suse.cz>
To: Dai Shili <daisl.fnst@fujitsu.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h
Date: Mon, 21 Feb 2022 19:04:58 +0100 [thread overview]
Message-ID: <YhPUSnQatwz3BFbg@pevik> (raw)
In-Reply-To: <1645459842-1609-1-git-send-email-daisl.fnst@fujitsu.com>
Hi Dai, Viresh, all,
[ Cc: Viresh, as he's the author ]
> Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com>
> ---
> include/lapi/fsmount.h | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
> index fa25306..eb98c97 100644
> --- a/include/lapi/fsmount.h
> +++ b/include/lapi/fsmount.h
> @@ -7,7 +7,6 @@
> #ifndef LAPI_FSMOUNT_H__
> #define LAPI_FSMOUNT_H__
> -#include <sys/mount.h>
indeed now is sys/mount.h useless, but we're not sure if there is no wrapper
for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in
the future. Because we have configure checks for these functions.
@Viresh, was this the reason why you added <sys/mount.h> ?
Kind regards,
Petr
> #include <sys/syscall.h>
> #include <sys/types.h>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-21 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 16:10 [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h Dai Shili
2022-02-21 18:04 ` Petr Vorel [this message]
2022-02-22 2:55 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhPUSnQatwz3BFbg@pevik \
--to=pvorel@suse.cz \
--cc=daisl.fnst@fujitsu.com \
--cc=ltp@lists.linux.it \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.