* [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h
@ 2022-02-21 16:10 Dai Shili
2022-02-21 18:04 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Dai Shili @ 2022-02-21 16:10 UTC (permalink / raw)
To: ltp
Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com>
---
include/lapi/fsmount.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
index fa25306..eb98c97 100644
--- a/include/lapi/fsmount.h
+++ b/include/lapi/fsmount.h
@@ -7,7 +7,6 @@
#ifndef LAPI_FSMOUNT_H__
#define LAPI_FSMOUNT_H__
-#include <sys/mount.h>
#include <sys/syscall.h>
#include <sys/types.h>
--
1.8.3.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h
2022-02-21 16:10 [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h Dai Shili
@ 2022-02-21 18:04 ` Petr Vorel
2022-02-22 2:55 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2022-02-21 18:04 UTC (permalink / raw)
To: Dai Shili; +Cc: Viresh Kumar, ltp
Hi Dai, Viresh, all,
[ Cc: Viresh, as he's the author ]
> Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com>
> ---
> include/lapi/fsmount.h | 1 -
> 1 file changed, 1 deletion(-)
> diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
> index fa25306..eb98c97 100644
> --- a/include/lapi/fsmount.h
> +++ b/include/lapi/fsmount.h
> @@ -7,7 +7,6 @@
> #ifndef LAPI_FSMOUNT_H__
> #define LAPI_FSMOUNT_H__
> -#include <sys/mount.h>
indeed now is sys/mount.h useless, but we're not sure if there is no wrapper
for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in
the future. Because we have configure checks for these functions.
@Viresh, was this the reason why you added <sys/mount.h> ?
Kind regards,
Petr
> #include <sys/syscall.h>
> #include <sys/types.h>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h
2022-02-21 18:04 ` Petr Vorel
@ 2022-02-22 2:55 ` Viresh Kumar
0 siblings, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2022-02-22 2:55 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On 21-02-22, 19:04, Petr Vorel wrote:
> Hi Dai, Viresh, all,
>
> [ Cc: Viresh, as he's the author ]
>
> > Signed-off-by: Dai Shili <daisl.fnst@fujitsu.com>
> > ---
> > include/lapi/fsmount.h | 1 -
> > 1 file changed, 1 deletion(-)
>
> > diff --git a/include/lapi/fsmount.h b/include/lapi/fsmount.h
> > index fa25306..eb98c97 100644
> > --- a/include/lapi/fsmount.h
> > +++ b/include/lapi/fsmount.h
> > @@ -7,7 +7,6 @@
> > #ifndef LAPI_FSMOUNT_H__
> > #define LAPI_FSMOUNT_H__
>
> > -#include <sys/mount.h>
>
> indeed now is sys/mount.h useless, but we're not sure if there is no wrapper
> for new syscalls (e.g. fsopen, fsconfig, fspick, move_mount, ...) in any libc in
> the future. Because we have configure checks for these functions.
> @Viresh, was this the reason why you added <sys/mount.h> ?
Right. Once the libc has the prototypes of these routines, most of fsmount.h
will become useless and sys/mount.h is the one that is going to be used.
--
viresh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-22 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-21 16:10 [LTP] [PATCH] lapi/fsmount.h: remove useless sys/mount.h Dai Shili
2022-02-21 18:04 ` Petr Vorel
2022-02-22 2:55 ` Viresh Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.