From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: kexec@lists.infradead.org
Subject: [PATCH V6] panic: Move panic_print before kmsg dumpers
Date: Tue, 22 Feb 2022 10:45:29 +0900 [thread overview]
Message-ID: <YhRAOQbH15E7y9s8@google.com> (raw)
In-Reply-To: <20220214141308.841525-1-gpiccoli@igalia.com>
On (22/02/14 11:13), Guilherme G. Piccoli wrote:
> -static void panic_print_sys_info(void)
> +static void panic_print_sys_info(bool console_flush)
> {
> - if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
> - console_flush_on_panic(CONSOLE_REPLAY_ALL);
> + if (console_flush) {
> + if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
> + console_flush_on_panic(CONSOLE_REPLAY_ALL);
> + return;
> + }
Yeah, if Petr is fine with that then I'm OK. But at the same time,
we have `panic_print' which is a bit mask of what panic_print_sys_info()
should do. And now we also have a boolean `console_flush` flag that tells
panic_print_sys_info() to ignore some (one as of now) bits of `panic_print'.
So _maybe_ panic_print_sys_info() can just accept panic_print as
its parameter and then we can do something like this (as an example)
panic_print_sys_info(panic_print & ~PANIC_PRINT_ALL_PRINTK_MSG);
> if (panic_print & PANIC_PRINT_ALL_CPU_BT)
> trigger_all_cpu_backtrace();
> @@ -286,6 +289,8 @@ void panic(const char *fmt, ...)
> */
> atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
[..]
> + panic_print_sys_info(false);
Merely because `panic_print_sys_info(false);` doesn't tell much to a reader.
Like what is print sys info false?
Or did you already discuss this?
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-kernel@vger.kernel.org, bhe@redhat.com, pmladek@suse.com,
akpm@linux-foundation.org, anton@enomsg.org, ccross@android.com,
dyoung@redhat.com, feng.tang@intel.com,
john.ogness@linutronix.de, keescook@chromium.org,
kernel@gpiccoli.net, kexec@lists.infradead.org,
rostedt@goodmis.org, senozhatsky@chromium.org,
tony.luck@intel.com, vgoyal@redhat.com
Subject: Re: [PATCH V6] panic: Move panic_print before kmsg dumpers
Date: Tue, 22 Feb 2022 10:45:29 +0900 [thread overview]
Message-ID: <YhRAOQbH15E7y9s8@google.com> (raw)
In-Reply-To: <20220214141308.841525-1-gpiccoli@igalia.com>
On (22/02/14 11:13), Guilherme G. Piccoli wrote:
> -static void panic_print_sys_info(void)
> +static void panic_print_sys_info(bool console_flush)
> {
> - if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
> - console_flush_on_panic(CONSOLE_REPLAY_ALL);
> + if (console_flush) {
> + if (panic_print & PANIC_PRINT_ALL_PRINTK_MSG)
> + console_flush_on_panic(CONSOLE_REPLAY_ALL);
> + return;
> + }
Yeah, if Petr is fine with that then I'm OK. But at the same time,
we have `panic_print' which is a bit mask of what panic_print_sys_info()
should do. And now we also have a boolean `console_flush` flag that tells
panic_print_sys_info() to ignore some (one as of now) bits of `panic_print'.
So _maybe_ panic_print_sys_info() can just accept panic_print as
its parameter and then we can do something like this (as an example)
panic_print_sys_info(panic_print & ~PANIC_PRINT_ALL_PRINTK_MSG);
> if (panic_print & PANIC_PRINT_ALL_CPU_BT)
> trigger_all_cpu_backtrace();
> @@ -286,6 +289,8 @@ void panic(const char *fmt, ...)
> */
> atomic_notifier_call_chain(&panic_notifier_list, 0, buf);
[..]
> + panic_print_sys_info(false);
Merely because `panic_print_sys_info(false);` doesn't tell much to a reader.
Like what is print sys info false?
Or did you already discuss this?
next prev parent reply other threads:[~2022-02-22 1:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 14:13 [PATCH V6] panic: Move panic_print before kmsg dumpers Guilherme G. Piccoli
2022-02-14 14:13 ` Guilherme G. Piccoli
2022-02-14 19:33 ` kernel test robot
2022-02-14 21:15 ` kernel test robot
2022-02-14 21:15 ` kernel test robot
2022-02-15 16:14 ` Petr Mladek
2022-02-15 16:14 ` Petr Mladek
2022-02-23 11:41 ` Sergey Senozhatsky
2022-02-23 11:41 ` Sergey Senozhatsky
2022-02-23 12:30 ` Guilherme G. Piccoli
2022-02-23 12:30 ` Guilherme G. Piccoli
2022-02-22 1:45 ` Sergey Senozhatsky [this message]
2022-02-22 1:45 ` Sergey Senozhatsky
2022-02-22 14:08 ` Guilherme G. Piccoli
2022-02-22 14:08 ` Guilherme G. Piccoli
2022-02-23 1:35 ` Sergey Senozhatsky
2022-02-23 1:35 ` Sergey Senozhatsky
2022-02-22 2:06 ` Sergey Senozhatsky
2022-02-22 2:06 ` Sergey Senozhatsky
2022-02-22 2:10 ` Sergey Senozhatsky
2022-02-22 2:10 ` Sergey Senozhatsky
2022-02-22 14:10 ` Guilherme G. Piccoli
2022-02-22 14:10 ` Guilherme G. Piccoli
2022-02-23 1:27 ` Sergey Senozhatsky
2022-02-23 1:27 ` Sergey Senozhatsky
2022-02-23 13:15 ` Guilherme G. Piccoli
2022-02-23 13:15 ` Guilherme G. Piccoli
2022-02-24 2:52 ` Sergey Senozhatsky
2022-02-24 2:52 ` Sergey Senozhatsky
2022-02-24 14:33 ` Petr Mladek
2022-02-24 14:33 ` Petr Mladek
2022-02-24 14:45 ` Guilherme G. Piccoli
2022-02-24 14:45 ` Guilherme G. Piccoli
2022-02-25 5:18 ` Sergey Senozhatsky
2022-02-25 5:18 ` Sergey Senozhatsky
2022-02-25 5:23 ` Sergey Senozhatsky
2022-02-25 5:23 ` Sergey Senozhatsky
2022-02-25 12:16 ` Petr Mladek
2022-02-25 12:16 ` Petr Mladek
2022-02-26 2:23 ` Sergey Senozhatsky
2022-02-26 2:23 ` Sergey Senozhatsky
2022-02-28 12:33 ` Guilherme G. Piccoli
2022-02-28 12:33 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhRAOQbH15E7y9s8@google.com \
--to=senozhatsky@chromium.org \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.