From: Christoph Hellwig <hch@infradead.org>
To: Wang Jianchao <jianchao.wan9@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Josef Bacik <jbacik@fb.com>,
Tejun Heo <tj@kernel.org>, Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V4 2/6] blk-wbt: make wbt pluggable
Date: Tue, 22 Feb 2022 00:12:15 -0800 [thread overview]
Message-ID: <YhSa30p1cPm4CVCg@infradead.org> (raw)
In-Reply-To: <6e6df16c-3609-71ef-c147-435920e59e8c@gmail.com>
On Fri, Feb 18, 2022 at 11:41:11AM +0800, Wang Jianchao wrote:
>
>
> On 2022/2/17 4:50 下午, Christoph Hellwig wrote:
> >> +struct rq_qos *wbt_rq_qos(struct request_queue *q);
> >> int wbt_init(struct request_queue *);
> >
> >
> > Please move the wb_lat sysfs attribute into blk-wbt.c as well, which
> > removes the need to expose these two functions.
> >
>
> Given this patchset:
> (1) Do we need to reserve the wb_lat sysfs when we turn off the wbt ?
> (2) Do we need to disable wbt automatically when switch io scheduler
> to bfq ? Or just tell the user turn off the wbt by themselves ?
I don't think this needs any changes to what is done there today,
i.e. keep the sysfs attribute around.
next prev parent reply other threads:[~2022-02-22 8:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 3:13 [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 3:13 ` [RFC V4 1/6] blk: prepare to make blk-rq-qos " Wang Jianchao (Kuaishou)
2022-02-17 8:48 ` Christoph Hellwig
2022-02-18 3:34 ` Wang Jianchao
2022-02-22 17:19 ` Tejun Heo
2022-02-23 3:08 ` Wang Jianchao
2022-02-23 3:10 ` Wang Jianchao
2022-02-23 21:37 ` Tejun Heo
2022-02-24 1:51 ` Wang Jianchao
2022-02-24 2:07 ` Tejun Heo
2022-02-24 2:50 ` Wang Jianchao
2022-02-24 16:53 ` Tejun Heo
2022-02-25 2:02 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 2/6] blk-wbt: make wbt pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:50 ` Christoph Hellwig
2022-02-18 3:41 ` Wang Jianchao
2022-02-22 8:12 ` Christoph Hellwig [this message]
2022-02-17 3:13 ` [RFC V4 3/6] blk-iolatency: make iolatency pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:51 ` Christoph Hellwig
2022-02-18 3:42 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 4/6] blk-iocost: make iocost pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:52 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 5/6] blk-ioprio: make ioprio pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 8:54 ` Christoph Hellwig
2022-02-17 3:13 ` [RFC V4 6/6] blk: export the sysfs for switching qos Wang Jianchao (Kuaishou)
2022-02-17 8:55 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:21 ` [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Jens Axboe
2022-02-17 3:53 ` Wang Jianchao
2022-02-17 8:43 ` Christoph Hellwig
2022-02-18 3:22 ` Wang Jianchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhSa30p1cPm4CVCg@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jbacik@fb.com \
--cc=jianchao.wan9@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.