From: Tejun Heo <tj@kernel.org>
To: Wang Jianchao <jianchao.wan9@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Josef Bacik <jbacik@fb.com>,
Bart Van Assche <bvanassche@acm.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC V4 1/6] blk: prepare to make blk-rq-qos pluggable and modular
Date: Wed, 23 Feb 2022 11:37:14 -1000 [thread overview]
Message-ID: <YhapCurbiI21WYmm@slm.duckdns.org> (raw)
In-Reply-To: <39db454d-ca30-fb42-3d72-899efa34fb78@gmail.com>
Hello,
> > We just want to provide the flexibility for the user to open/close a policy
> > per device. If we need to the policy on a device, we needn't to waste cpu
> sorry, it should be "If we don't need the policy on a device" ;)
Yeah, that's what modularization does but why does it need a separate user
interface for loading? Everything else inits on insmod and exits on rmmod
and autoloading has been delegated to udev a very long time ago. The
interface you added for loading module doesn't make sense to me.
Thanks.
--
tejun
next prev parent reply other threads:[~2022-02-23 21:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 3:13 [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 3:13 ` [RFC V4 1/6] blk: prepare to make blk-rq-qos " Wang Jianchao (Kuaishou)
2022-02-17 8:48 ` Christoph Hellwig
2022-02-18 3:34 ` Wang Jianchao
2022-02-22 17:19 ` Tejun Heo
2022-02-23 3:08 ` Wang Jianchao
2022-02-23 3:10 ` Wang Jianchao
2022-02-23 21:37 ` Tejun Heo [this message]
2022-02-24 1:51 ` Wang Jianchao
2022-02-24 2:07 ` Tejun Heo
2022-02-24 2:50 ` Wang Jianchao
2022-02-24 16:53 ` Tejun Heo
2022-02-25 2:02 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 2/6] blk-wbt: make wbt pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:50 ` Christoph Hellwig
2022-02-18 3:41 ` Wang Jianchao
2022-02-22 8:12 ` Christoph Hellwig
2022-02-17 3:13 ` [RFC V4 3/6] blk-iolatency: make iolatency pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:51 ` Christoph Hellwig
2022-02-18 3:42 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 4/6] blk-iocost: make iocost pluggable Wang Jianchao (Kuaishou)
2022-02-17 8:52 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:13 ` [RFC V4 5/6] blk-ioprio: make ioprio pluggable and modular Wang Jianchao (Kuaishou)
2022-02-17 8:54 ` Christoph Hellwig
2022-02-17 3:13 ` [RFC V4 6/6] blk: export the sysfs for switching qos Wang Jianchao (Kuaishou)
2022-02-17 8:55 ` Christoph Hellwig
2022-02-18 3:43 ` Wang Jianchao
2022-02-17 3:21 ` [RFC V4 0/6] blk: make blk-rq-qos policies pluggable and modular Jens Axboe
2022-02-17 3:53 ` Wang Jianchao
2022-02-17 8:43 ` Christoph Hellwig
2022-02-18 3:22 ` Wang Jianchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhapCurbiI21WYmm@slm.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=jbacik@fb.com \
--cc=jianchao.wan9@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.