[LTP] [PATCH 1/1] ci/debian: Temporarily not require libmm-dev

[LTP] [PATCH 1/1] ci/debian: Temporarily not require libmm-dev

[Petr Vorel]

It has been removed from Debian testing, thus it breaks build:
E: Unable to locate package libmm-dev
Error: Process completed with exit code 100.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi all,

do we even need libmm-dev?

https://packages.debian.org/sid/amd64/libmm-dev/filelist
...
/usr/bin/mm-config
/usr/include/mm.h
/usr/lib/libmm.a
/usr/lib/libmm.so

Kind regards,
Petr

 ci/debian.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/debian.sh b/ci/debian.sh
index f3dcb6e8d4..fb4c46f0a8 100755
--- a/ci/debian.sh
+++ b/ci/debian.sh
@@ -37,7 +37,6 @@ $apt \
 	libjson-perl \
 	libkeyutils-dev \
 	libkeyutils1 \
-	libmm-dev \
 	libmnl-dev \
 	libnuma-dev \
 	libnuma1 \
@@ -49,6 +48,7 @@ $apt \
 	lsb-release \
 	pkg-config
 
+$apt libmm-dev || true
 $apt ruby-asciidoctor-pdf || true
 $apt asciidoc-dblatex || true
 
-- 
2.35.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] ci/debian: Temporarily not require libmm-dev

[Cyril Hrubis]

Hi!
> do we even need libmm-dev?
> 
> https://packages.debian.org/sid/amd64/libmm-dev/filelist
> ...
> /usr/bin/mm-config
> /usr/include/mm.h
> /usr/lib/libmm.a
> /usr/lib/libmm.so

I do not think so. The only places where I found that we include mm.h
are actually a kernel modules and that include should be satisfied from
kernel-devel package.

So I guess that this has been added as a mistake to begin with.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] ci/debian: Temporarily not require libmm-dev

[Petr Vorel]

> Hi!
> > do we even need libmm-dev?

> > https://packages.debian.org/sid/amd64/libmm-dev/filelist
> > ...
> > /usr/bin/mm-config
> > /usr/include/mm.h
> > /usr/lib/libmm.a
> > /usr/lib/libmm.so

> I do not think so. The only places where I found that we include mm.h
> are actually a kernel modules and that include should be satisfied from
> kernel-devel package.

> So I guess that this has been added as a mistake to begin with.

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks! I'll remove it with changed message that it was added by accident
in initial Travis implementation.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] ci/debian: Temporarily not require libmm-dev

[Petr Vorel]

Hi all,

permanent remove merged as
0ee80c66e3 ("ci/debian: Remove libmm-dev")

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp