From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Yu Kuai <yukuai3@huawei.com>,
tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
yi.zhang@huawei.com
Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk()
Date: Mon, 28 Feb 2022 01:40:53 -0800 [thread overview]
Message-ID: <YhyYpWHGVhs3J/dk@infradead.org> (raw)
In-Reply-To: <Yhxnkg0AEaj36t+a@T590>
On Mon, Feb 28, 2022 at 02:11:30PM +0800, Ming Lei wrote:
> > FYI, this crashed left rigt and center when running xfstests with
> > traces pointing to throtl_pending_timer_fn.
>
> Can you share the exact xfstests test(fs, test)? Or panic log?
>
> I can't reproduce it when running './check -g auto' on XFS, meantime
> tracking throtl_pending_timer_fn().
From a quick run using f2fs:
generic/081 files ... [ 316.487861] run fstests generic/081 at 2022-02-28 09:38:40
[ 318.291133] F2FS-fs (dm-3): Found nat_bits in checkpoint
[ 318.298016] F2FS-fs (dm-3): Mounted with checkpoint version = 526422b7
[ 318.363888] device-mapper: snapshots: Invalidating snapshot: Unable to allocate exceptio.
[ 318.540023] general protection fault, probably for non-canonical address 0x6b6b6b6b6b6b6I
[ 318.541556] CPU: 0 PID: 13947 Comm: dmsetup Not tainted 5.17.0-rc2+ #1074
[ 318.542514] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/24
[ 318.543695] RIP: 0010:__lock_acquire+0x5b4/0x1de0
[ 318.544351] Code: 89 84 24 40 09 00 00 0f 87 2a 05 00 00 3b 05 17 c7 b2 03 41 bf 01 00 03
[ 318.546881] RSP: 0000:ffffc90000003cf8 EFLAGS: 00010002
[ 318.547610] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000000001
[ 318.548556] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 6b6b6b6b6b6b6bf3
[ 318.549497] RBP: 6b6b6b6b6b6b6bf3 R08: 0000000000000001 R09: 0000000000000001
[ 318.550438] R10: 0000000000000001 R11: 0000000000000000 R12: ffff8880117c8040
[ 318.551378] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[ 318.552323] FS: 0000000000000000(0000) GS:ffff88813bc00000(0000) knlGS:0000000000000000
[ 318.553380] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 318.554119] CR2: 00007f54883c9028 CR3: 0000000012a52000 CR4: 00000000000006f0
[ 318.555036] Call Trace:
[ 318.555360] <IRQ>
[ 318.555630] lock_acquire+0xd6/0x300
[ 318.556099] ? throtl_pending_timer_fn+0x69/0xa50
[ 318.556709] ? _raw_spin_lock_irq+0x4f/0x60
[ 318.557252] ? throtl_pd_offline+0x60/0x60
[ 318.557783] _raw_spin_lock_irq+0x40/0x60
[ 318.558303] ? throtl_pending_timer_fn+0x69/0xa50
[ 318.558915] throtl_pending_timer_fn+0x69/0xa50
[ 318.559485] ? throtl_pd_offline+0x60/0x60
[ 318.560003] ? throtl_pd_offline+0x60/0x60
[ 318.560520] call_timer_fn+0x9f/0x2c0
[ 318.560985] __run_timers.part.0+0x1fc/0x2f0
[ 318.561524] ? lock_is_held_type+0xe4/0x140
[ 318.562055] run_timer_softirq+0x2c/0x60
[ 318.562550] __do_softirq+0x174/0x512
[ 318.563016] __irq_exit_rcu+0xdf/0x130
[ 318.563491] irq_exit_rcu+0x5/0x20
[ 318.563926] sysvec_apic_timer_interrupt+0xa2/0xd0
[ 318.564529] </IRQ>
[ 318.564800] <TASK>
[ 318.565072] asm_sysvec_apic_timer_interrupt+0x12/0x20
next prev parent reply other threads:[~2022-02-28 9:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:56 [PATCH v9] block: cancel all throttled bios in del_gendisk() Yu Kuai
2022-02-10 11:56 ` Yu Kuai
2022-02-25 7:18 ` yukuai (C)
2022-02-25 7:18 ` yukuai (C)
2022-02-25 8:11 ` Ming Lei
[not found] ` <20220210115637.1074927-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-02-25 14:27 ` Jens Axboe
2022-02-25 14:27 ` Jens Axboe
2022-02-27 17:16 ` Christoph Hellwig
2022-02-27 17:16 ` Christoph Hellwig
[not found] ` <YhuyBgZSS6m/Mwu6-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-02-27 21:51 ` Jens Axboe
2022-02-27 21:51 ` Jens Axboe
2022-02-28 6:11 ` Ming Lei
2022-02-28 9:40 ` Christoph Hellwig [this message]
[not found] ` <YhyYpWHGVhs3J/dk-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-03-01 10:29 ` Ming Lei
2022-03-01 10:29 ` Ming Lei
2022-03-01 13:54 ` yukuai (C)
2022-03-01 13:54 ` yukuai (C)
[not found] ` <836f0686-4ac8-327d-2bab-64a762ea8673-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-03-02 0:51 ` Ming Lei
2022-03-02 0:51 ` Ming Lei
2022-03-17 11:22 ` yukuai (C)
2022-03-17 11:22 ` yukuai (C)
2022-03-18 7:04 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhyYpWHGVhs3J/dk@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.