From: Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
To: Yu Kuai <yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk()
Date: Fri, 25 Feb 2022 07:27:11 -0700 [thread overview]
Message-ID: <6db54b86-4f25-af15-692b-af067823d77e@kernel.dk> (raw)
In-Reply-To: <20220210115637.1074927-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On 2/10/22 4:56 AM, Yu Kuai wrote:
> Throttled bios can't be issued after del_gendisk() is done, thus
> it's better to cancel them immediately rather than waiting for
> throttle is done.
>
> For example, if user thread is throttled with low bps while it's
> issuing large io, and the device is deleted. The user thread will
> wait for a long time for io to return.
I hand applied this for 5.18 as it's conflicting with other
changes. Please double check the end result.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Yu Kuai <yukuai3@huawei.com>, ming.lei@redhat.com, tj@kernel.org
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk()
Date: Fri, 25 Feb 2022 07:27:11 -0700 [thread overview]
Message-ID: <6db54b86-4f25-af15-692b-af067823d77e@kernel.dk> (raw)
In-Reply-To: <20220210115637.1074927-1-yukuai3@huawei.com>
On 2/10/22 4:56 AM, Yu Kuai wrote:
> Throttled bios can't be issued after del_gendisk() is done, thus
> it's better to cancel them immediately rather than waiting for
> throttle is done.
>
> For example, if user thread is throttled with low bps while it's
> issuing large io, and the device is deleted. The user thread will
> wait for a long time for io to return.
I hand applied this for 5.18 as it's conflicting with other
changes. Please double check the end result.
--
Jens Axboe
next prev parent reply other threads:[~2022-02-25 14:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:56 [PATCH v9] block: cancel all throttled bios in del_gendisk() Yu Kuai
2022-02-10 11:56 ` Yu Kuai
2022-02-25 7:18 ` yukuai (C)
2022-02-25 7:18 ` yukuai (C)
2022-02-25 8:11 ` Ming Lei
[not found] ` <20220210115637.1074927-1-yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-02-25 14:27 ` Jens Axboe [this message]
2022-02-25 14:27 ` Jens Axboe
2022-02-27 17:16 ` Christoph Hellwig
2022-02-27 17:16 ` Christoph Hellwig
[not found] ` <YhuyBgZSS6m/Mwu6-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-02-27 21:51 ` Jens Axboe
2022-02-27 21:51 ` Jens Axboe
2022-02-28 6:11 ` Ming Lei
2022-02-28 9:40 ` Christoph Hellwig
[not found] ` <YhyYpWHGVhs3J/dk-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2022-03-01 10:29 ` Ming Lei
2022-03-01 10:29 ` Ming Lei
2022-03-01 13:54 ` yukuai (C)
2022-03-01 13:54 ` yukuai (C)
[not found] ` <836f0686-4ac8-327d-2bab-64a762ea8673-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2022-03-02 0:51 ` Ming Lei
2022-03-02 0:51 ` Ming Lei
2022-03-17 11:22 ` yukuai (C)
2022-03-17 11:22 ` yukuai (C)
2022-03-18 7:04 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6db54b86-4f25-af15-692b-af067823d77e@kernel.dk \
--to=axboe-tswwg44o7x1aa/9udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=ming.lei-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yi.zhang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=yukuai3-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.