From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] ksm06: lock memory about to be merged
Date: Mon, 28 Feb 2022 14:16:42 +0100 [thread overview]
Message-ID: <YhzLOrZDTTc/EffH@pevik> (raw)
In-Reply-To: <20220228094659.21959-3-chrubis@suse.cz>
Hi Cyril,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Good catch!
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
> testcases/kernel/mem/lib/mem.c | 3 +++
> 1 file changed, 3 insertions(+)
> diff --git a/testcases/kernel/mem/lib/mem.c b/testcases/kernel/mem/lib/mem.c
> index 39e3f1791..f1756b34a 100644
> --- a/testcases/kernel/mem/lib/mem.c
> +++ b/testcases/kernel/mem/lib/mem.c
> @@ -565,6 +565,9 @@ void test_ksm_merge_across_nodes(unsigned long nr_pages)
> #endif
> memset(memory[i], 10, length);
> +
> + if (mlock(memory[i], length))
> + tst_res(TINFO | TERRNO, "mlock() failed");
I'd consider using TWARN.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-28 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 9:46 [LTP] [PATCH 0/2] ksm06 fixes Cyril Hrubis
2022-02-28 9:46 ` [LTP] [PATCH 1/2] ksm06: Free memory at the end of the test Cyril Hrubis
2022-02-28 13:14 ` Petr Vorel
2022-02-28 9:46 ` [LTP] [PATCH 2/2] ksm06: lock memory about to be merged Cyril Hrubis
2022-02-28 13:16 ` Petr Vorel [this message]
2022-03-01 3:18 ` Li Wang
2022-03-01 8:09 ` Cyril Hrubis
2022-03-01 9:01 ` [LTP] [PATCH 0/2] ksm06 fixes Li Wang
2022-03-01 9:26 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhzLOrZDTTc/EffH@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.