All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] evaluate: init cmd pointer for new on-stack context
Date: Fri, 4 Mar 2022 14:41:25 +0100	[thread overview]
Message-ID: <YiIXBYZyMd8b5oKb@orbyte.nwl.cc> (raw)
In-Reply-To: <YiHv70Oqotbs5YCx@salvia>

On Fri, Mar 04, 2022 at 11:54:39AM +0100, Pablo Neira Ayuso wrote:
> On Fri, Mar 04, 2022 at 11:36:34AM +0100, Florian Westphal wrote:
> > else, this will segfault when trying to print the
> > "table 'x' doesn't exist" error message.
> 
> LGTM, thanks. One nitpick below:

This also fixes the segfault I was trying to avoid with my patch for
string_misspell_update(). I had definitely tried Florian's solution, but
it didn't work for me. Guess there's a bug in my test env or something.
:(

Thanks, Phil

      parent reply	other threads:[~2022-03-04 13:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 10:36 [PATCH nft] evaluate: init cmd pointer for new on-stack context Florian Westphal
2022-03-04 10:54 ` Pablo Neira Ayuso
2022-03-04 11:15   ` Florian Westphal
2022-03-04 13:41   ` Phil Sutter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiIXBYZyMd8b5oKb@orbyte.nwl.cc \
    --to=phil@nwl.cc \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.