From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org,
ezequiel@collabora.com, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 0/2] Fix the rkisp1 userspace API for later IP versions
Date: Fri, 4 Mar 2022 19:21:38 +0200 [thread overview]
Message-ID: <YiJKooCwFiFuC+Ue@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210111234011.3642481-1-heiko@sntech.de>
Hi Heiko,
On Tue, Jan 12, 2021 at 12:40:09AM +0100, Heiko Stuebner wrote:
> This NEEDs to go into 5.11 while we can still adapt the uapi
> during its RC-cycle.
>
>
> When looking into supporting the rkisp1 of the px30 I noticed that
> some fields got bigger in the uapi, caused by bigger number of samples
> for example for histograms or gamma values.
As I don't have access to a PX30 platform, I was wondering if you could
read the RKISP1_CIF_VI_ID register and report its value.
> The rkisp1 was destaged with 5.11-rc1 so we have still time during
> the 5.11 cycle to fix that without big hassles.
>
> This was discussed previously in a mail [0] and a rfc series [1]
> and this two-part series now splits out the important parts that
> really should become part of a 5.11-rc and thus the final 5.11.
>
>
> [0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego
> [1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de
>
> Heiko Stuebner (2):
> media: rockchip: rkisp1: carry ip version information
> media: rockchip: rkisp1: extend uapi array sizes
>
> .../platform/rockchip/rkisp1/rkisp1-common.h | 1 +
> .../platform/rockchip/rkisp1/rkisp1-dev.c | 22 +++++++++-------
> include/uapi/linux/rkisp1-config.h | 25 ++++++++++++++++---
> 3 files changed, 35 insertions(+), 13 deletions(-)
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: dafna.hirschfeld@collabora.com, helen.koike@collabora.com,
linux-media@vger.kernel.org, mchehab@kernel.org,
hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org,
ezequiel@collabora.com, christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 0/2] Fix the rkisp1 userspace API for later IP versions
Date: Fri, 4 Mar 2022 19:21:38 +0200 [thread overview]
Message-ID: <YiJKooCwFiFuC+Ue@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210111234011.3642481-1-heiko@sntech.de>
Hi Heiko,
On Tue, Jan 12, 2021 at 12:40:09AM +0100, Heiko Stuebner wrote:
> This NEEDs to go into 5.11 while we can still adapt the uapi
> during its RC-cycle.
>
>
> When looking into supporting the rkisp1 of the px30 I noticed that
> some fields got bigger in the uapi, caused by bigger number of samples
> for example for histograms or gamma values.
As I don't have access to a PX30 platform, I was wondering if you could
read the RKISP1_CIF_VI_ID register and report its value.
> The rkisp1 was destaged with 5.11-rc1 so we have still time during
> the 5.11 cycle to fix that without big hassles.
>
> This was discussed previously in a mail [0] and a rfc series [1]
> and this two-part series now splits out the important parts that
> really should become part of a 5.11-rc and thus the final 5.11.
>
>
> [0] http://lore.kernel.org/r/3342088.iIbC2pHGDl@diego
> [1] https://lore.kernel.org/r/20210108193311.3423236-2-heiko@sntech.de
>
> Heiko Stuebner (2):
> media: rockchip: rkisp1: carry ip version information
> media: rockchip: rkisp1: extend uapi array sizes
>
> .../platform/rockchip/rkisp1/rkisp1-common.h | 1 +
> .../platform/rockchip/rkisp1/rkisp1-dev.c | 22 +++++++++-------
> include/uapi/linux/rkisp1-config.h | 25 ++++++++++++++++---
> 3 files changed, 35 insertions(+), 13 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-03-04 17:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 23:40 [PATCH 0/2] Fix the rkisp1 userspace API for later IP versions Heiko Stuebner
2021-01-11 23:40 ` Heiko Stuebner
2021-01-11 23:40 ` [PATCH 1/2] media: rockchip: rkisp1: carry ip version information Heiko Stuebner
2021-01-11 23:40 ` Heiko Stuebner
2021-01-12 8:32 ` Hans Verkuil
2021-01-12 8:32 ` Hans Verkuil
2021-01-12 10:47 ` Dafna Hirschfeld
2021-01-12 10:47 ` Dafna Hirschfeld
2021-01-14 22:50 ` Heiko Stübner
2021-01-14 22:50 ` Heiko Stübner
2022-02-11 14:04 ` Laurent Pinchart
2022-02-11 14:04 ` Laurent Pinchart
2021-01-11 23:40 ` [PATCH 2/2] media: rockchip: rkisp1: extend uapi array sizes Heiko Stuebner
2021-01-11 23:40 ` Heiko Stuebner
2021-01-12 8:39 ` Hans Verkuil
2021-01-12 8:39 ` Hans Verkuil
2022-03-04 17:21 ` Laurent Pinchart [this message]
2022-03-04 17:21 ` [PATCH 0/2] Fix the rkisp1 userspace API for later IP versions Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2021-01-14 23:33 [PATCH v2 " Heiko Stuebner
2021-01-14 23:33 ` [PATCH " Heiko Stuebner
2021-01-14 23:33 ` Heiko Stuebner
2021-01-14 23:35 ` Heiko Stübner
2021-01-14 23:35 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YiJKooCwFiFuC+Ue@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.