All of lore.kernel.org
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: will@kernel.org, maz@kernel.org, joey.gouly@arm.com,
	mark.rutland@arm.com, akpm@linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] arm64: improve display about CPU architecture in cpuinfo
Date: Mon, 7 Mar 2022 08:43:34 +0000	[thread overview]
Message-ID: <YiXFtrK9O917eHQk@arm.com> (raw)
In-Reply-To: <20220307030417.22974-1-rongwei.wang@linux.alibaba.com>

On Mon, Mar 07, 2022 at 11:04:17AM +0800, Rongwei Wang wrote:
> Now, it is unsuitable for both ARMv8 and ARMv9 to show a
> fixed string "CPU architecture: 8" in /proc/cpuinfo.
> 
> Signed-off-by: Rongwei Wang <rongwei.wang@linux.alibaba.com>
> ---
>  arch/arm64/kernel/cpuinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 330b92e..6d9b7e8 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -195,7 +195,7 @@ static int c_show(struct seq_file *m, void *v)
>  
>  		seq_printf(m, "CPU implementer\t: 0x%02x\n",
>  			   MIDR_IMPLEMENTOR(midr));
> -		seq_printf(m, "CPU architecture: 8\n");
> +		seq_printf(m, "CPU architecture: aarch64\n");

In hindsight, 'aarch64' would have made more sense since 8/9/10 whatever
are just marketing. That said, we should not apply this patch as it has
potential ABI implications.

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Rongwei Wang <rongwei.wang@linux.alibaba.com>
Cc: will@kernel.org, maz@kernel.org, joey.gouly@arm.com,
	mark.rutland@arm.com, akpm@linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] arm64: improve display about CPU architecture in cpuinfo
Date: Mon, 7 Mar 2022 08:43:34 +0000	[thread overview]
Message-ID: <YiXFtrK9O917eHQk@arm.com> (raw)
In-Reply-To: <20220307030417.22974-1-rongwei.wang@linux.alibaba.com>

On Mon, Mar 07, 2022 at 11:04:17AM +0800, Rongwei Wang wrote:
> Now, it is unsuitable for both ARMv8 and ARMv9 to show a
> fixed string "CPU architecture: 8" in /proc/cpuinfo.
> 
> Signed-off-by: Rongwei Wang <rongwei.wang@linux.alibaba.com>
> ---
>  arch/arm64/kernel/cpuinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 330b92e..6d9b7e8 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -195,7 +195,7 @@ static int c_show(struct seq_file *m, void *v)
>  
>  		seq_printf(m, "CPU implementer\t: 0x%02x\n",
>  			   MIDR_IMPLEMENTOR(midr));
> -		seq_printf(m, "CPU architecture: 8\n");
> +		seq_printf(m, "CPU architecture: aarch64\n");

In hindsight, 'aarch64' would have made more sense since 8/9/10 whatever
are just marketing. That said, we should not apply this patch as it has
potential ABI implications.

-- 
Catalin

  reply	other threads:[~2022-03-07  8:44 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07  3:04 [PATCH RFC] arm64: improve display about CPU architecture in cpuinfo Rongwei Wang
2022-03-07  3:04 ` Rongwei Wang
2022-03-07  8:43 ` Catalin Marinas [this message]
2022-03-07  8:43   ` Catalin Marinas
2022-03-07  8:45 ` Marc Zyngier
2022-03-07  8:45   ` Marc Zyngier
2022-03-07 12:13   ` Rongwei Wang
2022-03-07 12:13     ` Rongwei Wang
2022-03-07 12:23     ` Marc Zyngier
2022-03-07 12:23       ` Marc Zyngier
2022-03-07 16:48       ` Robin Murphy
2022-03-07 16:48         ` Robin Murphy
2022-03-07 19:30         ` Arnd Bergmann
2022-03-07 19:30           ` Arnd Bergmann
2022-03-07 20:05           ` Robin Murphy
2022-03-07 20:05             ` Robin Murphy
2022-03-08 17:18             ` Catalin Marinas
2022-03-08 17:18               ` Catalin Marinas
2022-03-08 17:47               ` Robin Murphy
2022-03-08 17:47                 ` Robin Murphy
2022-03-08 17:57             ` Russell King (Oracle)
2022-03-08 17:57               ` Russell King (Oracle)
2022-03-08 19:09               ` Robin Murphy
2022-03-08 19:09                 ` Robin Murphy
2022-03-08 17:55           ` Russell King (Oracle)
2022-03-08 17:55             ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiXFtrK9O917eHQk@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=joey.gouly@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=rongwei.wang@linux.alibaba.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.