From: John Keeping <john@metanate.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Daniel Beer <daniel.beer@igorinstitute.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: tas5805m: fix pdn polarity
Date: Wed, 9 Mar 2022 12:34:28 +0000 [thread overview]
Message-ID: <Yiie1OUCvi49f1Q7@donbot> (raw)
In-Reply-To: <YiiZv7Fc8a4O1nYR@sirena.org.uk>
On Wed, Mar 09, 2022 at 12:12:47PM +0000, Mark Brown wrote:
> On Wed, Mar 09, 2022 at 10:41:04AM +0000, John Keeping wrote:
>
> > Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
>
> Please don't insert fixes tags unless you're actually fixing a bug,
> stylistic improvements like this - people try to use the tag for
> backporting bug fixes and so on so extra tags create noise for them.
This isn't purely stylistic - it affects the interpretation of pdn-gpios
in the device tree so that it matches all of the other bindings that use
this property: active means PDN asserted.
There are currently no in-tree users of the binding and the patch adding
it is queued for the next merge window.
WARNING: multiple messages have this Message-ID (diff)
From: John Keeping <john@metanate.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Daniel Beer <daniel.beer@igorinstitute.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tas5805m: fix pdn polarity
Date: Wed, 9 Mar 2022 12:34:28 +0000 [thread overview]
Message-ID: <Yiie1OUCvi49f1Q7@donbot> (raw)
In-Reply-To: <YiiZv7Fc8a4O1nYR@sirena.org.uk>
On Wed, Mar 09, 2022 at 12:12:47PM +0000, Mark Brown wrote:
> On Wed, Mar 09, 2022 at 10:41:04AM +0000, John Keeping wrote:
>
> > Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifier")
>
> Please don't insert fixes tags unless you're actually fixing a bug,
> stylistic improvements like this - people try to use the tag for
> backporting bug fixes and so on so extra tags create noise for them.
This isn't purely stylistic - it affects the interpretation of pdn-gpios
in the device tree so that it matches all of the other bindings that use
this property: active means PDN asserted.
There are currently no in-tree users of the binding and the patch adding
it is queued for the next merge window.
next prev parent reply other threads:[~2022-03-09 12:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-09 10:41 [PATCH] ASoC: tas5805m: fix pdn polarity John Keeping
2022-03-09 10:41 ` John Keeping
2022-03-09 12:12 ` Mark Brown
2022-03-09 12:12 ` Mark Brown
2022-03-09 12:34 ` John Keeping [this message]
2022-03-09 12:34 ` John Keeping
2022-03-09 13:00 ` Mark Brown
2022-03-09 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yiie1OUCvi49f1Q7@donbot \
--to=john@metanate.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.beer@igorinstitute.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.