All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Hector Martin <marcan@marcan.st>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/7] dt-bindings: interrupt-controller: apple,aic2: New binding for AICv2
Date: Thu, 10 Mar 2022 09:43:19 -0600	[thread overview]
Message-ID: <Yiocl203Ix7DLXKj@robh.at.kernel.org> (raw)
In-Reply-To: <20220309192123.152028-3-marcan@marcan.st>

On Thu, Mar 10, 2022 at 04:21:18AM +0900, Hector Martin wrote:
> This new incompatible revision of the AIC peripheral introduces
> multi-die support. This binding is based on apple,aic, but
> changes interrupt-cells to add a new die argument.
> 
> Also adds a second reg entry to specify the offset of the event
> register. Inexplicably, the capability registers allow us to compute
> other register offsets, but not this one. This allows us to keep
> forward-compatibility with future SoCs that will likely implement
> different die counts, thus shifting the event register. Apple also
> specify the offset explicitly in their their device tree...

their their

(checkpatch with codespell installed told me)

> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../interrupt-controller/apple,aic2.yaml      | 98 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  2 files changed, 99 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Hector Martin <marcan@marcan.st>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>, Sven Peter <sven@svenpeter.dev>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Mark Kettenis <mark.kettenis@xs4all.nl>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/7] dt-bindings: interrupt-controller: apple,aic2: New binding for AICv2
Date: Thu, 10 Mar 2022 09:43:19 -0600	[thread overview]
Message-ID: <Yiocl203Ix7DLXKj@robh.at.kernel.org> (raw)
In-Reply-To: <20220309192123.152028-3-marcan@marcan.st>

On Thu, Mar 10, 2022 at 04:21:18AM +0900, Hector Martin wrote:
> This new incompatible revision of the AIC peripheral introduces
> multi-die support. This binding is based on apple,aic, but
> changes interrupt-cells to add a new die argument.
> 
> Also adds a second reg entry to specify the offset of the event
> register. Inexplicably, the capability registers allow us to compute
> other register offsets, but not this one. This allows us to keep
> forward-compatibility with future SoCs that will likely implement
> different die counts, thus shifting the event register. Apple also
> specify the offset explicitly in their their device tree...

their their

(checkpatch with codespell installed told me)

> 
> Signed-off-by: Hector Martin <marcan@marcan.st>
> ---
>  .../interrupt-controller/apple,aic2.yaml      | 98 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  2 files changed, 99 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/apple,aic2.yaml

With that,

Reviewed-by: Rob Herring <robh@kernel.org>

  reply	other threads:[~2022-03-10 15:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09 19:21 [PATCH v3 0/7] irqchip/apple-aic: Add support for AICv2 Hector Martin
2022-03-09 19:21 ` Hector Martin
2022-03-09 19:21 ` [PATCH v3 1/7] PCI: apple: Change MSI handling to handle 4-cell AIC fwspec form Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 2/7] dt-bindings: interrupt-controller: apple, aic2: New binding for AICv2 Hector Martin
2022-03-09 19:21   ` [PATCH v3 2/7] dt-bindings: interrupt-controller: apple,aic2: " Hector Martin
2022-03-10 15:43   ` Rob Herring [this message]
2022-03-10 15:43     ` Rob Herring
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 3/7] irqchip/apple-aic: Add Fast IPI support Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-09 20:28   ` Alyssa Rosenzweig
2022-03-09 20:28     ` Alyssa Rosenzweig
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 4/7] irqchip/apple-aic: Switch to irq_domain_create_tree and sparse hwirqs Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 5/7] irqchip/apple-aic: Dynamically compute register offsets Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 6/7] irqchip/apple-aic: Support multiple dies Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 19:21 ` [PATCH v3 7/7] irqchip/apple-aic: Add support for AICv2 Hector Martin
2022-03-09 19:21   ` Hector Martin
2022-03-11  9:20   ` [irqchip: irq/irqchip-next] " irqchip-bot for Hector Martin
2022-03-09 20:30 ` [PATCH v3 0/7] " Alyssa Rosenzweig
2022-03-09 20:30   ` Alyssa Rosenzweig
2022-03-09 20:37   ` Marc Zyngier
2022-03-09 20:37     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yiocl203Ix7DLXKj@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=alyssa@rosenzweig.io \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=mark.kettenis@xs4all.nl \
    --cc=maz@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.