* [PATCH v2 0/2] Add support for ARTPEC-8 UART @ 2022-03-11 9:45 ` Vincent Whitchurch 0 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar This series adds support for the UART hardware on the ARTPEC-8 chip. This block is already supported by an existing driver so only a small patch to describe the properties of the variant is required. v2: - This version is based on top of Krzysztof's "minor fixes/cleanups" series since they will conflict otherwise. - Expand commit messages - Define required clocks in binding - Fix FIFO size Cc: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org Cc: alim.akhtar@samsung.com Vincent Whitchurch (2): dt-bindings: serial: samsung: Add ARTPEC-8 UART tty: serial: samsung: Add ARTPEC-8 support .../bindings/serial/samsung_uart.yaml | 2 + drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/samsung_tty.c | 37 +++++++++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) -- 2.34.1 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 0/2] Add support for ARTPEC-8 UART @ 2022-03-11 9:45 ` Vincent Whitchurch 0 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar This series adds support for the UART hardware on the ARTPEC-8 chip. This block is already supported by an existing driver so only a small patch to describe the properties of the variant is required. v2: - This version is based on top of Krzysztof's "minor fixes/cleanups" series since they will conflict otherwise. - Expand commit messages - Define required clocks in binding - Fix FIFO size Cc: linux-kernel@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org Cc: alim.akhtar@samsung.com Vincent Whitchurch (2): dt-bindings: serial: samsung: Add ARTPEC-8 UART tty: serial: samsung: Add ARTPEC-8 support .../bindings/serial/samsung_uart.yaml | 2 + drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/samsung_tty.c | 37 +++++++++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-) -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART 2022-03-11 9:45 ` Vincent Whitchurch @ 2022-03-11 9:45 ` Vincent Whitchurch -1 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block is closely related to the variants used on the Exynos chips. The register layout is identical to Exynos850 et al but the fifo size is different (64 bytes in each direction for all instances). Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> --- Notes: v2: - Expand commit message. - Define required clocks. Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index 2940afb874b3..c2423144a4d6 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -20,6 +20,7 @@ properties: items: - enum: - apple,s5l-uart + - axis,artpec8-uart - samsung,s3c2410-uart - samsung,s3c2412-uart - samsung,s3c2440-uart @@ -110,6 +111,7 @@ allOf: contains: enum: - apple,s5l-uart + - axis,artpec8-uart - samsung,exynos4210-uart then: properties: -- 2.34.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART @ 2022-03-11 9:45 ` Vincent Whitchurch 0 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block is closely related to the variants used on the Exynos chips. The register layout is identical to Exynos850 et al but the fifo size is different (64 bytes in each direction for all instances). Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> --- Notes: v2: - Expand commit message. - Define required clocks. Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/samsung_uart.yaml b/Documentation/devicetree/bindings/serial/samsung_uart.yaml index 2940afb874b3..c2423144a4d6 100644 --- a/Documentation/devicetree/bindings/serial/samsung_uart.yaml +++ b/Documentation/devicetree/bindings/serial/samsung_uart.yaml @@ -20,6 +20,7 @@ properties: items: - enum: - apple,s5l-uart + - axis,artpec8-uart - samsung,s3c2410-uart - samsung,s3c2412-uart - samsung,s3c2440-uart @@ -110,6 +111,7 @@ allOf: contains: enum: - apple,s5l-uart + - axis,artpec8-uart - samsung,exynos4210-uart then: properties: -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART 2022-03-11 9:45 ` Vincent Whitchurch @ 2022-03-11 10:40 ` Krzysztof Kozlowski -1 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:40 UTC (permalink / raw) To: Vincent Whitchurch, gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar On 11/03/2022 10:45, Vincent Whitchurch wrote: > Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block > is closely related to the variants used on the Exynos chips. The > register layout is identical to Exynos850 et al but the fifo size is > different (64 bytes in each direction for all instances). > > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART @ 2022-03-11 10:40 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:40 UTC (permalink / raw) To: Vincent Whitchurch, gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar On 11/03/2022 10:45, Vincent Whitchurch wrote: > Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block > is closely related to the variants used on the Exynos chips. The > register layout is identical to Exynos850 et al but the fifo size is > different (64 bytes in each direction for all instances). > > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART 2022-03-11 9:45 ` Vincent Whitchurch @ 2022-03-11 14:52 ` Rob Herring -1 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2022-03-11 14:52 UTC (permalink / raw) To: Vincent Whitchurch Cc: krzysztof.kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, jirislaby, kernel, linux-kernel, alim.akhtar, linux-serial, robh+dt, gregkh On Fri, 11 Mar 2022 10:45:14 +0100, Vincent Whitchurch wrote: > Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block > is closely related to the variants used on the Exynos chips. The > register layout is identical to Exynos850 et al but the fifo size is > different (64 bytes in each direction for all instances). > > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > > Notes: > v2: > - Expand commit message. > - Define required clocks. > > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: serial: samsung: Add ARTPEC-8 UART @ 2022-03-11 14:52 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2022-03-11 14:52 UTC (permalink / raw) To: Vincent Whitchurch Cc: krzysztof.kozlowski, devicetree, linux-arm-kernel, linux-samsung-soc, jirislaby, kernel, linux-kernel, alim.akhtar, linux-serial, robh+dt, gregkh On Fri, 11 Mar 2022 10:45:14 +0100, Vincent Whitchurch wrote: > Add a compatible for the UART on the ARTPEC-8 SoC. This hardware block > is closely related to the variants used on the Exynos chips. The > register layout is identical to Exynos850 et al but the fifo size is > different (64 bytes in each direction for all instances). > > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > > Notes: > v2: > - Expand commit message. > - Define required clocks. > > Documentation/devicetree/bindings/serial/samsung_uart.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support 2022-03-11 9:45 ` Vincent Whitchurch @ 2022-03-11 9:45 ` Vincent Whitchurch -1 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar Add support for the UART block on the ARTPEC-8 SoC. This is closely related to the variants used on the Exynos chips. The register layout is identical to Exynos850 et al but the fifo size is different (64 bytes in each direction for all instances). Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> --- Notes: v2: - Added Krzysztof's Reviewed-by. - Expanded commit message - Fixed fifo size - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a couple of fixes for build errors. (I'm always unsure if Reviewed-by should be carried over or not if the fixes are minor. I apologize in advance if carring it over was the wrong thing to do in this case.) drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/samsung_tty.c | 37 ++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 0e5ccb25bdb1..bd46e35ded40 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -236,7 +236,7 @@ config SERIAL_CLPS711X_CONSOLE config SERIAL_SAMSUNG tristate "Samsung SoC serial support" - depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || COMPILE_TEST + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || ARCH_ARTPEC || COMPILE_TEST select SERIAL_CORE help Support for the on-chip UARTs on the Samsung diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 74d466cc4152..7d011d3fa3a6 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2828,6 +2828,36 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = { #define S5L_SERIAL_DRV_DATA NULL #endif +#if defined(CONFIG_ARCH_ARTPEC) +static const struct s3c24xx_serial_drv_data artpec8_serial_drv_data = { + .info = { + .name = "Axis ARTPEC-8 UART", + .type = TYPE_S3C6400, + .port_type = PORT_S3C6400, + .fifosize = 64, + .has_divslot = 1, + .rx_fifomask = S5PV210_UFSTAT_RXMASK, + .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, + .rx_fifofull = S5PV210_UFSTAT_RXFULL, + .tx_fifofull = S5PV210_UFSTAT_TXFULL, + .tx_fifomask = S5PV210_UFSTAT_TXMASK, + .tx_fifoshift = S5PV210_UFSTAT_TXSHIFT, + .def_clk_sel = S3C2410_UCON_CLKSEL0, + .num_clks = 1, + .clksel_mask = 0, + .clksel_shift = 0, + }, + .def_cfg = { + .ucon = S5PV210_UCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + .has_fracval = 1, + } +}; +#define ARTPEC8_SERIAL_DRV_DATA (&artpec8_serial_drv_data) +#else +#define ARTPEC8_SERIAL_DRV_DATA (NULL) +#endif + static const struct platform_device_id s3c24xx_serial_driver_ids[] = { { .name = "s3c2410-uart", @@ -2856,6 +2886,9 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = { }, { .name = "exynos850-uart", .driver_data = (kernel_ulong_t)EXYNOS850_SERIAL_DRV_DATA, + }, { + .name = "artpec8-uart", + .driver_data = (kernel_ulong_t)ARTPEC8_SERIAL_DRV_DATA, }, { }, }; @@ -2881,6 +2914,8 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { .data = S5L_SERIAL_DRV_DATA }, { .compatible = "samsung,exynos850-uart", .data = EXYNOS850_SERIAL_DRV_DATA }, + { .compatible = "axis,artpec8-uart", + .data = ARTPEC8_SERIAL_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); @@ -3034,6 +3069,8 @@ OF_EARLYCON_DECLARE(s5pv210, "samsung,s5pv210-uart", s5pv210_early_console_setup); OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart", s5pv210_early_console_setup); +OF_EARLYCON_DECLARE(artpec8, "axis,artpec8-uart", + s5pv210_early_console_setup); /* Apple S5L */ static int __init apple_s5l_early_console_setup(struct earlycon_device *device, -- 2.34.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support @ 2022-03-11 9:45 ` Vincent Whitchurch 0 siblings, 0 replies; 14+ messages in thread From: Vincent Whitchurch @ 2022-03-11 9:45 UTC (permalink / raw) To: gregkh, jirislaby, krzysztof.kozlowski Cc: kernel, Vincent Whitchurch, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar Add support for the UART block on the ARTPEC-8 SoC. This is closely related to the variants used on the Exynos chips. The register layout is identical to Exynos850 et al but the fifo size is different (64 bytes in each direction for all instances). Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> --- Notes: v2: - Added Krzysztof's Reviewed-by. - Expanded commit message - Fixed fifo size - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a couple of fixes for build errors. (I'm always unsure if Reviewed-by should be carried over or not if the fixes are minor. I apologize in advance if carring it over was the wrong thing to do in this case.) drivers/tty/serial/Kconfig | 2 +- drivers/tty/serial/samsung_tty.c | 37 ++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 0e5ccb25bdb1..bd46e35ded40 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -236,7 +236,7 @@ config SERIAL_CLPS711X_CONSOLE config SERIAL_SAMSUNG tristate "Samsung SoC serial support" - depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || COMPILE_TEST + depends on PLAT_SAMSUNG || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_APPLE || ARCH_ARTPEC || COMPILE_TEST select SERIAL_CORE help Support for the on-chip UARTs on the Samsung diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c index 74d466cc4152..7d011d3fa3a6 100644 --- a/drivers/tty/serial/samsung_tty.c +++ b/drivers/tty/serial/samsung_tty.c @@ -2828,6 +2828,36 @@ static const struct s3c24xx_serial_drv_data s5l_serial_drv_data = { #define S5L_SERIAL_DRV_DATA NULL #endif +#if defined(CONFIG_ARCH_ARTPEC) +static const struct s3c24xx_serial_drv_data artpec8_serial_drv_data = { + .info = { + .name = "Axis ARTPEC-8 UART", + .type = TYPE_S3C6400, + .port_type = PORT_S3C6400, + .fifosize = 64, + .has_divslot = 1, + .rx_fifomask = S5PV210_UFSTAT_RXMASK, + .rx_fifoshift = S5PV210_UFSTAT_RXSHIFT, + .rx_fifofull = S5PV210_UFSTAT_RXFULL, + .tx_fifofull = S5PV210_UFSTAT_TXFULL, + .tx_fifomask = S5PV210_UFSTAT_TXMASK, + .tx_fifoshift = S5PV210_UFSTAT_TXSHIFT, + .def_clk_sel = S3C2410_UCON_CLKSEL0, + .num_clks = 1, + .clksel_mask = 0, + .clksel_shift = 0, + }, + .def_cfg = { + .ucon = S5PV210_UCON_DEFAULT, + .ufcon = S5PV210_UFCON_DEFAULT, + .has_fracval = 1, + } +}; +#define ARTPEC8_SERIAL_DRV_DATA (&artpec8_serial_drv_data) +#else +#define ARTPEC8_SERIAL_DRV_DATA (NULL) +#endif + static const struct platform_device_id s3c24xx_serial_driver_ids[] = { { .name = "s3c2410-uart", @@ -2856,6 +2886,9 @@ static const struct platform_device_id s3c24xx_serial_driver_ids[] = { }, { .name = "exynos850-uart", .driver_data = (kernel_ulong_t)EXYNOS850_SERIAL_DRV_DATA, + }, { + .name = "artpec8-uart", + .driver_data = (kernel_ulong_t)ARTPEC8_SERIAL_DRV_DATA, }, { }, }; @@ -2881,6 +2914,8 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { .data = S5L_SERIAL_DRV_DATA }, { .compatible = "samsung,exynos850-uart", .data = EXYNOS850_SERIAL_DRV_DATA }, + { .compatible = "axis,artpec8-uart", + .data = ARTPEC8_SERIAL_DRV_DATA }, {}, }; MODULE_DEVICE_TABLE(of, s3c24xx_uart_dt_match); @@ -3034,6 +3069,8 @@ OF_EARLYCON_DECLARE(s5pv210, "samsung,s5pv210-uart", s5pv210_early_console_setup); OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart", s5pv210_early_console_setup); +OF_EARLYCON_DECLARE(artpec8, "axis,artpec8-uart", + s5pv210_early_console_setup); /* Apple S5L */ static int __init apple_s5l_early_console_setup(struct earlycon_device *device, -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support 2022-03-11 9:45 ` Vincent Whitchurch @ 2022-03-11 10:42 ` Krzysztof Kozlowski -1 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:42 UTC (permalink / raw) To: Vincent Whitchurch, gregkh, jirislaby Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar On 11/03/2022 10:45, Vincent Whitchurch wrote: > Add support for the UART block on the ARTPEC-8 SoC. This is closely > related to the variants used on the Exynos chips. The register layout > is identical to Exynos850 et al but the fifo size is different (64 bytes > in each direction for all instances). > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > > Notes: > v2: > - Added Krzysztof's Reviewed-by. > - Expanded commit message > - Fixed fifo size > - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a > couple of fixes for build errors. > > (I'm always unsure if Reviewed-by should be carried over or not if the fixes > are minor. I apologize in advance if carring it over was the wrong thing to do > in this case.) For minor fixes, usually we carry Rb tag over. It's fine. LGTM Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support @ 2022-03-11 10:42 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:42 UTC (permalink / raw) To: Vincent Whitchurch, gregkh, jirislaby Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar On 11/03/2022 10:45, Vincent Whitchurch wrote: > Add support for the UART block on the ARTPEC-8 SoC. This is closely > related to the variants used on the Exynos chips. The register layout > is identical to Exynos850 et al but the fifo size is different (64 bytes > in each direction for all instances). > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> > --- > > Notes: > v2: > - Added Krzysztof's Reviewed-by. > - Expanded commit message > - Fixed fifo size > - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a > couple of fixes for build errors. > > (I'm always unsure if Reviewed-by should be carried over or not if the fixes > are minor. I apologize in advance if carring it over was the wrong thing to do > in this case.) For minor fixes, usually we carry Rb tag over. It's fine. LGTM Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support 2022-03-11 10:42 ` Krzysztof Kozlowski @ 2022-03-11 10:44 ` Krzysztof Kozlowski -1 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:44 UTC (permalink / raw) To: gregkh Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar, jirislaby, Vincent Whitchurch On 11/03/2022 11:42, Krzysztof Kozlowski wrote: > On 11/03/2022 10:45, Vincent Whitchurch wrote: >> Add support for the UART block on the ARTPEC-8 SoC. This is closely >> related to the variants used on the Exynos chips. The register layout >> is identical to Exynos850 et al but the fifo size is different (64 bytes >> in each direction for all instances). >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> >> --- >> >> Notes: >> v2: >> - Added Krzysztof's Reviewed-by. >> - Expanded commit message >> - Fixed fifo size >> - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a >> couple of fixes for build errors. >> >> (I'm always unsure if Reviewed-by should be carried over or not if the fixes >> are minor. I apologize in advance if carring it over was the wrong thing to do >> in this case.) > > For minor fixes, usually we carry Rb tag over. It's fine. > Hi Greg, Just one note for you - this depends now on my v3 patchset here: https://lore.kernel.org/all/20220308080919.152715-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support @ 2022-03-11 10:44 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-03-11 10:44 UTC (permalink / raw) To: gregkh Cc: kernel, linux-kernel, devicetree, linux-serial, linux-samsung-soc, linux-arm-kernel, robh+dt, alim.akhtar, jirislaby, Vincent Whitchurch On 11/03/2022 11:42, Krzysztof Kozlowski wrote: > On 11/03/2022 10:45, Vincent Whitchurch wrote: >> Add support for the UART block on the ARTPEC-8 SoC. This is closely >> related to the variants used on the Exynos chips. The register layout >> is identical to Exynos850 et al but the fifo size is different (64 bytes >> in each direction for all instances). >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> Signed-off-by: Vincent Whitchurch <vincent.whitchurch@axis.com> >> --- >> >> Notes: >> v2: >> - Added Krzysztof's Reviewed-by. >> - Expanded commit message >> - Fixed fifo size >> - Rebased on top of Krzysztof's "minor fixes/cleanups" series. This needed a >> couple of fixes for build errors. >> >> (I'm always unsure if Reviewed-by should be carried over or not if the fixes >> are minor. I apologize in advance if carring it over was the wrong thing to do >> in this case.) > > For minor fixes, usually we carry Rb tag over. It's fine. > Hi Greg, Just one note for you - this depends now on my v3 patchset here: https://lore.kernel.org/all/20220308080919.152715-1-krzysztof.kozlowski@canonical.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-03-11 15:11 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-03-11 9:45 [PATCH v2 0/2] Add support for ARTPEC-8 UART Vincent Whitchurch 2022-03-11 9:45 ` Vincent Whitchurch 2022-03-11 9:45 ` [PATCH v2 1/2] dt-bindings: serial: samsung: Add " Vincent Whitchurch 2022-03-11 9:45 ` Vincent Whitchurch 2022-03-11 10:40 ` Krzysztof Kozlowski 2022-03-11 10:40 ` Krzysztof Kozlowski 2022-03-11 14:52 ` Rob Herring 2022-03-11 14:52 ` Rob Herring 2022-03-11 9:45 ` [PATCH v2 2/2] tty: serial: samsung: Add ARTPEC-8 support Vincent Whitchurch 2022-03-11 9:45 ` Vincent Whitchurch 2022-03-11 10:42 ` Krzysztof Kozlowski 2022-03-11 10:42 ` Krzysztof Kozlowski 2022-03-11 10:44 ` Krzysztof Kozlowski 2022-03-11 10:44 ` Krzysztof Kozlowski
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.