All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk
Subject: Re: [PATCH] ARM: Spectre-BHB: provide empty stub for non-config
Date: Fri, 11 Mar 2022 19:28:32 +0000	[thread overview]
Message-ID: <Yiui4HUz8RxHMdYf@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220311191820.25771-1-rdunlap@infradead.org>

On Fri, Mar 11, 2022 at 11:18:20AM -0800, Randy Dunlap wrote:
> When CONFIG_GENERIC_CPU_VULNERABILITIES is not set, references
> to spectre_v2_update_state() cause a build error, so provide an
> empty stub for that function when the Kconfig option is not set.
> 
> Fixes this build error:
> 
> arm-linux-gnueabi-ld: arch/arm/mm/proc-v7-bugs.o: in function `cpu_v7_bugs_init':
> proc-v7-bugs.c:(.text+0x52): undefined reference to `spectre_v2_update_state'
> arm-linux-gnueabi-ld: proc-v7-bugs.c:(.text+0x82): undefined reference to `spectre_v2_update_state'
> 
> Fixes: b9baf5c8c5c3 ("ARM: Spectre-BHB workaround")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

I'd suggest sending this direct to Linus as I've been doing with the
other fixes for Spectre BHB. Trying to fit it now into a pull request
is just going to be very messy.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org, patches@armlinux.org.uk
Subject: Re: [PATCH] ARM: Spectre-BHB: provide empty stub for non-config
Date: Fri, 11 Mar 2022 19:28:32 +0000	[thread overview]
Message-ID: <Yiui4HUz8RxHMdYf@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220311191820.25771-1-rdunlap@infradead.org>

On Fri, Mar 11, 2022 at 11:18:20AM -0800, Randy Dunlap wrote:
> When CONFIG_GENERIC_CPU_VULNERABILITIES is not set, references
> to spectre_v2_update_state() cause a build error, so provide an
> empty stub for that function when the Kconfig option is not set.
> 
> Fixes this build error:
> 
> arm-linux-gnueabi-ld: arch/arm/mm/proc-v7-bugs.o: in function `cpu_v7_bugs_init':
> proc-v7-bugs.c:(.text+0x52): undefined reference to `spectre_v2_update_state'
> arm-linux-gnueabi-ld: proc-v7-bugs.c:(.text+0x82): undefined reference to `spectre_v2_update_state'
> 
> Fixes: b9baf5c8c5c3 ("ARM: Spectre-BHB workaround")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>

Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

I'd suggest sending this direct to Linus as I've been doing with the
other fixes for Spectre BHB. Trying to fit it now into a pull request
is just going to be very messy.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2022-03-11 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 19:18 [PATCH] ARM: Spectre-BHB: provide empty stub for non-config Randy Dunlap
2022-03-11 19:18 ` Randy Dunlap
2022-03-11 19:28 ` Russell King (Oracle) [this message]
2022-03-11 19:28   ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yiui4HUz8RxHMdYf@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=patches@armlinux.org.uk \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.