+ proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch added to -mm tree

+ proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch added to -mm tree

[Andrew Morton]

The patch titled
     Subject: proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes
has been added to the -mm tree.  Its filename is
     proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes

WARNING: braces {} are not necessary for single statement blocks
#31: FILE: fs/proc/generic.c:452:
+	if ((*parent)->proc_dops == &proc_net_dentry_ops) {
+		pde_force_lookup(ent);
+	}

total: 0 errors, 1 warnings, 19 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/proc-fix-dentry-inode-overinstantiating-under-proc-pid-net.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/proc/generic.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/proc/generic.c~proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes
+++ a/fs/proc/generic.c
@@ -449,9 +449,8 @@ static struct proc_dir_entry *__proc_cre
 
 	ent->proc_dops = &proc_misc_dentry_ops;
 	/* Revalidate everything under /proc/${pid}/net */
-	if ((*parent)->proc_dops == &proc_net_dentry_ops) {
+	if ((*parent)->proc_dops == &proc_net_dentry_ops)
 		pde_force_lookup(ent);
-	}
 
 out:
 	return ent;
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

mm.patch
mm-mempolicy-convert-from-atomic_t-to-refcount_t-on-mempolicy-refcnt-fix.patch
ksm-count-ksm-merging-pages-for-each-process-fix.patch
proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch
linux-next-rejects.patch
mm-oom_killc-fix-vm_oom_kill_table-ifdeffery.patch
mutex-subsystem-synchro-test-module-fix.patch
kernel-forkc-export-kernel_thread-to-modules.patch

Re: + proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch added to -mm tree

[Alexey Dobriyan]

On Fri, Mar 25, 2022 at 08:27:27PM -0700, Andrew Morton wrote:
 
> WARNING: braces {} are not necessary for single statement blocks

Who is inventing all these silly rules?

> #31: FILE: fs/proc/generic.c:452:
> +	if ((*parent)->proc_dops == &proc_net_dentry_ops) {
> +		pde_force_lookup(ent);
> +	}

Re: + proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch added to -mm tree

[Andrew Morton]

On Sat, 26 Mar 2022 17:33:34 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:

> On Fri, Mar 25, 2022 at 08:27:27PM -0700, Andrew Morton wrote:
>  
> > WARNING: braces {} are not necessary for single statement blocks
> 
> Who is inventing all these silly rules?

um, Linus?

: Do not unnecessarily use braces where a single statement will do.
: 
: .. code-block:: c
: 
: 	if (condition)
: 		action();

has been in Documentation/process/coding-style.rst since 2015 and it
was in Documentation/CodingStyle for infinity.