From: LABBE Corentin <clabbe@baylibre.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, john@metanate.com
Subject: Re: [PATCH v2 11/18] crypto: rockhip: do not handle dma clock
Date: Tue, 15 Mar 2022 12:45:55 +0100 [thread overview]
Message-ID: <YjB8c6gfPyUmzYpd@Red> (raw)
In-Reply-To: <9295c92e-e054-8817-c96c-b33821643ce7@gmail.com>
Le Thu, Mar 10, 2022 at 06:52:15PM +0100, Johan Jonker a écrit :
>
>
> On 3/10/22 15:45, LABBE Corentin wrote:
> > Le Fri, Mar 04, 2022 at 04:01:58PM +0100, Johan Jonker a écrit :
> >> Hi Corentin,
> >>
> >> Make your clock driver parsing portable.
> >>
> >> ===
> >> oneOf:
> >> - const: rockchip,rk3288-crypto
> >> - items:
> >> - enum:
> >> - rockchip,rk3328-crypto
> >> - const: rockchip,rk3288-crypto
> >>
> >> Compatible string must be SoC related!
> >>
> >> rk3288 was the first in line that had support, so we use that as fall
> >> back string.
> >>
> >> ===
> >>
> >> Make binding fit for more SoC types.
> >> Allow more clocks by using devm_clk_bulk_get_all.
> >
> > Hello
> >
> > Thanks for the hint of devm_clk_bulk_get_all, I will switch to it as it simplify clock handling.
> >
> >> Drop reset-names requirement for devm_reset_control_array_get_exclusive.
> >>
> >> ===
> >>
> >> Use a patch order to prevent the scripts generate notifications.
> >
>
> > which scripts ?
>
> For Linux users:
> ./scripts/checkpatch.pl --strict <patch1> <patch2>
>
> Device tree maintainer rob+dt:
> A bot with unknown scripts.
>
> >
> >>
>
>
> - dts rk3288 clock removal
>
> >> - dt-bindings conversion
> >>
> >> - add rk3328 compatible string in a separate patch
> + new clock names
>
>
> >>
> >> - your driver changes
> >>
> >> - dts patches
> >>
> >> A proposed maintainer must be able to submit patch series without errors. ;)
> >>
> >> ===
> >>
> >> When you remove a clock in a YAML conversion you must add a note to the
> >> DT maintainer.
> >>
> >> ===
> >>
> >> Johan
> >>
> >> On 3/2/22 22:11, Corentin Labbe wrote:
> >>> The DMA clock is handled by the DMA controller, so the crypto does not
> >>> have to touch it.
> >>>
> >>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> >>> ---
> >>> drivers/crypto/rockchip/rk3288_crypto.c | 16 +---------------
> >>> drivers/crypto/rockchip/rk3288_crypto.h | 1 -
> >>> 2 files changed, 1 insertion(+), 16 deletions(-)
> >>>
> >>> diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> index 94ef1283789f..645855d2651b 100644
> >>> --- a/drivers/crypto/rockchip/rk3288_crypto.c
> >>> +++ b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> @@ -40,15 +40,8 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>> __func__, __LINE__);
> >>> goto err_hclk;
> >>> }
> >>> - err = clk_prepare_enable(dev->dmaclk);
> >>> - if (err) {
> >>> - dev_err(dev->dev, "[%s:%d], Couldn't enable clock dmaclk\n",
> >>> - __func__, __LINE__);
> >>> - goto err_dmaclk;
> >>> - }
> >>> +
> >>> return err;
> >>> -err_dmaclk:
> >>> - clk_disable_unprepare(dev->hclk);
> >>> err_hclk:
> >>> clk_disable_unprepare(dev->aclk);
> >>> err_aclk:
> >>> @@ -59,7 +52,6 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>>
> >>> static void rk_crypto_disable_clk(struct rk_crypto_info *dev)
> >>> {
> >>> - clk_disable_unprepare(dev->dmaclk);
> >>> clk_disable_unprepare(dev->hclk);
> >>> clk_disable_unprepare(dev->aclk);
> >>> clk_disable_unprepare(dev->sclk);
> >>> @@ -199,12 +191,6 @@ static int rk_crypto_probe(struct platform_device *pdev)
> >>> goto err_crypto;
> >>> }
> >>>
> >>
> >>> - crypto_info->dmaclk = devm_clk_get(&pdev->dev, "apb_pclk");
> >>> - if (IS_ERR(crypto_info->dmaclk)) {
> >>> - err = PTR_ERR(crypto_info->dmaclk);
> >>> - goto err_crypto;
> >>> - }
> >>> -
> >>
> >> rk3288:
> >> clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> >> - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> >> - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >>
> >> rk3328:
> >> + clocks = <&cru HCLK_CRYPTO_MST>, <&cru HCLK_CRYPTO_SLV>,
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >> The HCLK_CRYPTO_MST not is related to ACLK_CRYPTO.
> >> You are reusing rk3288 names to not to change the driver.
> >> Give it an other name.
> >
> > You are right, I will change them.
> >
> >
> >>
> >> ===
> >>
>
> >> The sclk goes through a crypto_div_con.
> >> Does that need a frequency set?
> >> Or does that come from nowhere?
> >>
> >> From crypto_v1.c
> >> priv->frequency = dev_read_u32_default(dev, "clock-frequency",
> >> CRYPTO_V1_DEFAULT_RATE);
> >>
> >> ret = clk_set_rate(&priv->sclk, priv->frequency);
> >>
> >
>
> > The problem is that I dont see any hints for this in TRM, and their rockchips source are inconsistent, they do this in uboot not in linux....
>
> Rockchip RK3288TRM V1.2 Part2-20170321.pdf
> page 1419
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> For rk3228/rk3328:
> Rockchip RK3228TRM V0.1 20151016-Part3 Graphic and Multi-media.pdf
> page 476
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> Rockchip RK3399TRM V1.1 Part3 20160728.pdf
> page 781
>
> Make sure F crypto do not exceed 200M.
>
> ===
>
> They all have a limit.
> Rockchip uses a default in there drivers and in there TRM tables.
> Then stay consistant and use that too what is already set by the bootloader.
> (till someone comes up with a better (yet unknown) approuch)
>
> #define CRYPTO_V1_DEFAULT_RATE 100000000
>
> ===
>
> Could you disclose your sclk frequency table from:
>
> /sys/kernel/debug/clk/clk_summary
>
> Does that fit within the limits?
>
Hello
On my rk3328-rock64, sclk is 240Mhz, so far beyond the limit.
[ 32.416633] rk3288-crypto ff060000.crypto: CLK 0 hclk_master 75000000 75Mhz
[ 32.417292] rk3288-crypto ff060000.crypto: CLK 1 hclk_slave 75000000 75Mhz
[ 32.417926] rk3288-crypto ff060000.crypto: CLK 2 sclk 240000000 240Mhz
But everything is stable even with this value.
I remember trying overcloacking allwinner crypto, things broke really fast.
I will try to collect values from other SoCs.
enable prepare protect duty hardware
clock count count count rate accuracy phase cycle enable
-------------------------------------------------------------------------------------------------------
rk805-clkout2 0 0 0 32768 0 0 50000 Y
xin32k 0 0 0 32768 0 0 50000 Y
gmac_clkin 1 1 0 125000000 0 0 50000 Y
clk_mac2io 2 2 0 125000000 0 0 50000 Y
clk_mac2io_ref 0 0 0 125000000 0 0 50000 N
clk_mac2io_rx 0 0 0 125000000 0 0 50000 N
clk_mac2io_tx 1 1 0 125000000 0 0 50000 Y
clk_mac2io_refout 0 0 0 125000000 0 0 50000 N
clk_mac2io_ext 0 0 0 125000000 0 0 50000 Y
xin24m 8 8 0 24000000 0 0 50000 Y
hdmi_phy 0 0 0 148500000 0 0 50000 Y
usb480m_phy 4 4 0 480000000 0 0 50000 Y
usb480m 0 0 0 480000000 0 0 50000 Y
sclk_uart1 0 0 0 24000000 0 0 50000 Y
sclk_uart0 0 0 0 24000000 0 0 50000 Y
xin12m 0 0 0 12000000 0 0 50000 Y
clk_usb3otg_suspend 0 0 0 30770 0 0 50000 N
clk_usb3otg_ref 0 0 0 24000000 0 0 50000 N
clk_ref_usb3otg 0 0 0 24000000 0 0 50000 Y
clk_emmc 0 0 0 200000 0 0 50000 N
emmc_sample 0 0 0 100000 0 0 50000 Y
emmc_drv 0 0 0 100000 0 90 50000 Y
sclk_hdmi_sfc 0 0 0 24000000 0 0 50000 N
sclk_timer5 0 0 0 24000000 0 0 50000 N
sclk_timer4 0 0 0 24000000 0 0 50000 N
sclk_timer3 0 0 0 24000000 0 0 50000 N
sclk_timer2 0 0 0 24000000 0 0 50000 N
sclk_timer1 0 0 0 24000000 0 0 50000 N
sclk_timer0 0 0 0 24000000 0 0 50000 N
clk_efuse 0 0 0 12000000 0 0 50000 N
clk_otp 0 0 0 24000000 0 0 50000 N
sclk_uart2 1 1 0 24000000 0 0 50000 Y
clk_ddrmon 0 0 0 24000000 0 0 50000 Y
hdmiphy 0 0 0 24000000 0 0 50000 Y
dclk_lcdc 0 0 0 24000000 0 0 50000 Y
hdmiphy_peri 0 0 0 24000000 0 0 50000 Y
clk_24m 1 1 0 24000000 0 0 50000 Y
clk_saradc 0 0 0 49897 0 0 50000 N
clk_tsadc 1 1 0 50000 0 0 50000 Y
pll_npll 1 1 0 1200000000 0 0 50000 Y
npll 1 1 0 1200000000 0 0 50000 Y
npll_core 1 1 0 1200000000 0 0 50000 Y
armclk 2 2 0 1200000000 0 0 50000 Y
pclk_dbg 1 1 0 200000000 0 0 50000 Y
aclk_core 2 2 0 600000000 0 0 50000 Y
aclk_gic400 1 1 0 600000000 0 0 50000 Y
aclk_core_niu 1 1 0 600000000 0 0 50000 Y
pll_gpll 1 1 0 491520000 0 0 50000 Y
gpll 3 3 0 491520000 0 0 50000 Y
clk_rtc32k 0 0 0 32768 0 0 50000 N
aclk_gmac 3 3 0 163840000 0 0 50000 Y
aclk_gmac_niu 1 1 0 163840000 0 0 50000 Y
aclk_mac2io 1 1 0 163840000 0 0 50000 Y
aclk_mac2phy 0 0 0 163840000 0 0 50000 N
pclk_gmac 2 2 0 54613334 0 0 50000 Y
pclk_gmac_niu 1 1 0 54613334 0 0 50000 Y
pclk_mac2io 1 1 0 54613334 0 0 50000 Y
pclk_mac2phy 0 0 0 54613334 0 0 50000 N
gpll_peri 0 0 0 491520000 0 0 50000 N
clk_rga 0 0 0 163840000 0 0 50000 N
clk_spi 0 0 0 15360000 0 0 50000 N
aclk_gpu_pre 1 1 0 163840000 0 0 50000 Y
aclk_gpu_niu 1 1 0 163840000 0 0 50000 Y
aclk_gpu 0 0 0 163840000 0 0 50000 N
gpll_core 1 1 0 491520000 0 0 50000 Y
pll_cpll 1 1 0 1200000000 0 0 50000 Y
cpll 10 11 0 1200000000 0 0 50000 Y
clk_sdmmc 0 0 0 100000000 0 0 50000 N
sdmmc_sample 0 0 0 50000000 0 0 50000 Y
sdmmc_drv 0 0 0 50000000 0 90 50000 Y
aclk_bus_pre 4 5 0 150000000 0 0 50000 Y
aclk_dmac_bus 0 1 0 150000000 0 0 50000 N
aclk_intmem 1 1 0 150000000 0 0 50000 Y
aclk_tsp 0 0 0 150000000 0 0 50000 N
aclk_dcf 0 0 0 150000000 0 0 50000 N
aclk_bus_niu 1 1 0 150000000 0 0 50000 Y
pclk_bus_pre 2 2 0 75000000 0 0 50000 Y
pclk_phy_pre 3 3 0 75000000 0 0 50000 Y
pclk_phy_niu 1 1 0 75000000 0 0 50000 Y
pclk_vdacphy 0 0 0 75000000 0 0 50000 Y
pclk_hdmiphy 1 1 0 75000000 0 0 50000 Y
pclk_acodecphy 0 0 0 75000000 0 0 50000 N
pclk_ddrphy 1 1 0 75000000 0 0 50000 N
pclk_usb2_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3phy_pipe 0 0 0 75000000 0 0 50000 N
pclk_usb3phy_otg 0 0 0 75000000 0 0 50000 N
pclk_bus 14 15 0 75000000 0 0 50000 Y
pclk_wdt 1 1 0 75000000 0 0 50000 Y
pclk_pmu 1 1 0 75000000 0 0 50000 Y
pclk_saradc 0 0 0 75000000 0 0 50000 N
pclk_sim 0 0 0 75000000 0 0 50000 Y
pclk_sgrf 1 1 0 75000000 0 0 50000 Y
pclk_cru 1 1 0 75000000 0 0 50000 Y
pclk_grf 1 1 0 75000000 0 0 50000 Y
pclk_dcf 0 0 0 75000000 0 0 50000 N
pclk_tsadc 1 1 0 75000000 0 0 50000 Y
pclk_uart2 1 1 0 75000000 0 0 50000 Y
pclk_uart1 0 0 0 75000000 0 0 50000 N
pclk_uart0 0 0 0 75000000 0 0 50000 N
pclk_gpio3 1 1 0 75000000 0 0 50000 Y
pclk_gpio2 1 1 0 75000000 0 0 50000 Y
pclk_gpio1 1 1 0 75000000 0 0 50000 Y
pclk_gpio0 1 1 0 75000000 0 0 50000 Y
pclk_rk_pwm 0 0 0 75000000 0 0 50000 N
pclk_spi 0 0 0 75000000 0 0 50000 N
pclk_stimer 0 0 0 75000000 0 0 50000 N
pclk_timer0 1 1 0 75000000 0 0 50000 Y
pclk_i2c3 0 0 0 75000000 0 0 50000 N
pclk_i2c2 0 0 0 75000000 0 0 50000 N
pclk_i2c1 0 1 0 75000000 0 0 50000 N
pclk_i2c0 0 0 0 75000000 0 0 50000 N
pclk_otp 0 0 0 75000000 0 0 50000 Y
pclk_efuse 0 0 0 75000000 0 0 50000 Y
pclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_bus_pre 2 2 0 75000000 0 0 50000 Y
hclk_pdm 0 0 0 75000000 0 0 50000 N
hclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_crypto_slv 0 0 0 75000000 0 0 50000 N
hclk_crypto_mst 0 0 0 75000000 0 0 50000 N
hclk_tsp 0 0 0 75000000 0 0 50000 N
hclk_spdif_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s2_2ch 0 0 0 75000000 0 0 50000 N
hclk_i2s1_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s0_8ch 0 0 0 75000000 0 0 50000 N
hclk_rom 1 1 0 75000000 0 0 50000 Y
clk_wifi 0 0 0 24000000 0 0 50000 N
sclk_vdec_core 0 0 0 100000000 0 0 50000 N
sclk_vdec_cabac 0 0 0 100000000 0 0 50000 N
aclk_vpu_pre 2 3 0 400000000 0 0 50000 Y
aclk_vpu_niu 1 1 0 400000000 0 0 50000 Y
aclk_vpu 0 5 0 400000000 0 0 50000 N
hclk_vpu_pre 1 2 0 100000000 0 0 50000 Y
hclk_vpu_niu 1 1 0 100000000 0 0 50000 Y
hclk_vpu 0 5 0 100000000 0 0 50000 N
aclk_rga_pre 1 1 0 100000000 0 0 50000 Y
aclk_rga_niu 1 1 0 100000000 0 0 50000 Y
aclk_rga 0 0 0 100000000 0 0 50000 N
aclk_vio_pre 2 2 0 100000000 0 0 50000 Y
aclk_vio_niu 1 1 0 100000000 0 0 50000 Y
aclk_hdcp 0 0 0 100000000 0 0 50000 N
aclk_cif 0 0 0 100000000 0 0 50000 N
aclk_iep 0 0 0 100000000 0 0 50000 N
hclk_vio_pre 5 6 0 33333334 0 0 50000 Y
pclk_hdcp 0 0 0 33333334 0 0 50000 N
pclk_hdmi 0 0 0 33333334 0 0 50000 N
hclk_vio_niu 1 1 0 33333334 0 0 50000 Y
hclk_hdcp 0 0 0 33333334 0 0 50000 N
hclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
pclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
hclk_ahb1tom 1 1 0 33333334 0 0 50000 Y
hclk_rga 0 0 0 33333334 0 0 50000 N
hclk_cif 0 0 0 33333334 0 0 50000 N
hclk_iep 0 0 0 33333334 0 0 50000 N
hclk_vop_niu 1 1 0 33333334 0 0 50000 Y
hclk_vop 0 1 0 33333334 0 0 50000 N
clk_mac2phy_src 0 0 0 75000000 0 0 50000 N
clk_mac2phy 0 0 0 75000000 0 0 50000 Y
clk_mac2phy_ref 0 0 0 75000000 0 0 50000 N
clk_mac2phy_rxtx 0 0 0 75000000 0 0 50000 N
clk_mac2phy_out 0 0 0 75000000 0 0 50000 N
clk_mac2io_out 0 0 0 150000000 0 0 50000 N
clk_mac2io_src 0 0 0 200000000 0 0 50000 N
clk_ref_usb3otg_src 0 0 0 37500000 0 0 50000 N
clk_sdmmc_ext 0 0 0 300000000 0 0 50000 N
sdmmc_ext_sample 0 0 0 150000000 0 0 50000 Y
sdmmc_ext_drv 0 0 0 150000000 0 180 50000 Y
clk_sdio 0 0 0 50000000 0 0 50000 N
sdio_sample 0 0 0 25000000 0 0 50000 Y
sdio_drv 0 0 0 25000000 0 180 50000 Y
cpll_peri 1 1 0 1200000000 0 0 50000 Y
aclk_peri_pre 3 3 0 150000000 0 0 50000 Y
aclk_peri 1 1 0 150000000 0 0 50000 Y
aclk_usb3otg 0 0 0 150000000 0 0 50000 N
aclk_peri_noc 0 0 0 150000000 0 0 50000 Y
hclk_peri 7 7 0 75000000 0 0 50000 Y
pclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_otg_pmu 1 1 0 75000000 0 0 50000 Y
hclk_otg 1 1 0 75000000 0 0 50000 Y
hclk_host0_arb 0 0 0 75000000 0 0 50000 Y
hclk_host0 2 2 0 75000000 0 0 50000 Y
hclk_sdmmc_ext 0 0 0 75000000 0 0 50000 N
hclk_emmc 0 0 0 75000000 0 0 50000 N
hclk_sdio 0 0 0 75000000 0 0 50000 N
hclk_sdmmc 1 1 0 75000000 0 0 50000 Y
pclk_peri 1 1 0 75000000 0 0 50000 Y
dclk_lcdc_src 1 1 0 24000000 0 0 50000 Y
dclk_hdmiphy 1 1 0 8000000 0 0 50000 Y
clk_cif_src 0 0 0 1200000000 0 0 50000 N
clk_cif_out 0 0 0 60000000 0 0 50000 Y
aclk_vop_pre 1 2 0 100000000 0 0 50000 Y
aclk_vop_niu 1 1 0 100000000 0 0 50000 Y
aclk_vop 0 1 0 100000000 0 0 50000 N
sclk_venc_dsp 0 0 0 50000000 0 0 50000 N
sclk_venc_core 0 0 0 50000000 0 0 50000 N
aclk_rkvenc 2 2 0 50000000 0 0 50000 Y
aclk_axisram 0 0 0 50000000 0 0 50000 Y
aclk_h264 0 0 0 50000000 0 0 50000 N
aclk_h265 0 0 0 50000000 0 0 50000 N
aclk_rkvenc_niu 1 1 0 50000000 0 0 50000 Y
hclk_rkvenc 1 1 0 12500000 0 0 50000 Y
hclk_h264 0 0 0 12500000 0 0 50000 N
pclk_h265 0 0 0 12500000 0 0 50000 N
hclk_rkvenc_niu 1 1 0 12500000 0 0 50000 Y
aclk_rkvdec_pre 2 2 0 100000000 0 0 50000 Y
aclk_rkvdec_niu 1 1 0 100000000 0 0 50000 Y
aclk_rkvdec 0 0 0 100000000 0 0 50000 N
hclk_rkvdec_pre 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec_niu 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec 0 0 0 25000000 0 0 50000 N
clk_pwm 0 0 0 150000000 0 0 50000 N
clk_crypto 0 0 0 240000000 0 0 50000 N
clk_i2c3 0 0 0 150000000 0 0 50000 N
clk_i2c2 0 0 0 150000000 0 0 50000 N
clk_i2c1 0 1 0 150000000 0 0 50000 N
clk_i2c0 0 0 0 150000000 0 0 50000 N
clk_uart2_div 0 0 0 150000000 0 0 50000 N
clk_uart2_frac 0 0 0 7500000 0 0 50000 N
clk_uart1_div 0 0 0 150000000 0 0 50000 N
clk_uart1_frac 0 0 0 7500000 0 0 50000 N
clk_uart0_div 0 0 0 150000000 0 0 50000 N
clk_uart0_frac 0 0 0 7500000 0 0 50000 N
clk_spdif_div 0 0 0 75000000 0 0 50000 N
sclk_spdif 0 0 0 75000000 0 0 50000 Y
clk_spdif_frac 0 0 0 3750000 0 0 50000 N
clk_i2s2_div 0 0 0 75000000 0 0 50000 N
i2s2_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s2 0 0 0 75000000 0 0 50000 N
i2s2_out 0 0 0 75000000 0 0 50000 N
clk_i2s2_frac 0 0 0 3750000 0 0 50000 N
clk_i2s1_div 0 0 0 75000000 0 0 50000 N
i2s1_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s1 0 0 0 75000000 0 0 50000 N
i2s1_out 0 0 0 75000000 0 0 50000 N
clk_i2s1_frac 0 0 0 3750000 0 0 50000 N
clk_i2s0_div 0 0 0 75000000 0 0 50000 N
i2s0_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s0 0 0 0 75000000 0 0 50000 N
clk_i2s0_frac 0 0 0 3750000 0 0 50000 N
clk_tsp 0 0 0 50000000 0 0 50000 N
pclk_ddr 3 3 0 150000000 0 0 50000 Y
pclk_ddr_grf 1 1 0 150000000 0 0 50000 Y
pclk_ddrstdby 0 0 0 150000000 0 0 50000 Y
pclk_ddr_mon 1 1 0 150000000 0 0 50000 Y
pclk_ddr_msch 1 1 0 150000000 0 0 50000 Y
pclk_ddrupctl 0 0 0 150000000 0 0 50000 Y
pll_dpll 1 1 0 1596000000 0 0 50000 Y
dpll 1 1 0 1596000000 0 0 50000 Y
clk_ddr 2 2 0 1596000000 0 0 50000 Y
aclk_ddrupctl 0 0 0 1596000000 0 0 50000 Y
clk_ddrupctl 1 1 0 1596000000 0 0 50000 Y
clk_ddrmsch 1 1 0 1596000000 0 0 50000 Y
dpll_core 0 0 0 1596000000 0 0 50000 Y
pll_apll 0 0 0 61440000 0 0 50000 Y
apll 0 0 0 61440000 0 0 50000 Y
clk_pdm 0 0 0 61440000 0 0 50000 N
apll_core 0 0 0 61440000 0 0 50000 Y
clk_hsadc_tsp 0 0 0 0 0 0 50000 N
clk_jtag 1 1 0 0 0 0 50000 Y
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, john@metanate.com
Subject: Re: [PATCH v2 11/18] crypto: rockhip: do not handle dma clock
Date: Tue, 15 Mar 2022 12:45:55 +0100 [thread overview]
Message-ID: <YjB8c6gfPyUmzYpd@Red> (raw)
In-Reply-To: <9295c92e-e054-8817-c96c-b33821643ce7@gmail.com>
Le Thu, Mar 10, 2022 at 06:52:15PM +0100, Johan Jonker a écrit :
>
>
> On 3/10/22 15:45, LABBE Corentin wrote:
> > Le Fri, Mar 04, 2022 at 04:01:58PM +0100, Johan Jonker a écrit :
> >> Hi Corentin,
> >>
> >> Make your clock driver parsing portable.
> >>
> >> ===
> >> oneOf:
> >> - const: rockchip,rk3288-crypto
> >> - items:
> >> - enum:
> >> - rockchip,rk3328-crypto
> >> - const: rockchip,rk3288-crypto
> >>
> >> Compatible string must be SoC related!
> >>
> >> rk3288 was the first in line that had support, so we use that as fall
> >> back string.
> >>
> >> ===
> >>
> >> Make binding fit for more SoC types.
> >> Allow more clocks by using devm_clk_bulk_get_all.
> >
> > Hello
> >
> > Thanks for the hint of devm_clk_bulk_get_all, I will switch to it as it simplify clock handling.
> >
> >> Drop reset-names requirement for devm_reset_control_array_get_exclusive.
> >>
> >> ===
> >>
> >> Use a patch order to prevent the scripts generate notifications.
> >
>
> > which scripts ?
>
> For Linux users:
> ./scripts/checkpatch.pl --strict <patch1> <patch2>
>
> Device tree maintainer rob+dt:
> A bot with unknown scripts.
>
> >
> >>
>
>
> - dts rk3288 clock removal
>
> >> - dt-bindings conversion
> >>
> >> - add rk3328 compatible string in a separate patch
> + new clock names
>
>
> >>
> >> - your driver changes
> >>
> >> - dts patches
> >>
> >> A proposed maintainer must be able to submit patch series without errors. ;)
> >>
> >> ===
> >>
> >> When you remove a clock in a YAML conversion you must add a note to the
> >> DT maintainer.
> >>
> >> ===
> >>
> >> Johan
> >>
> >> On 3/2/22 22:11, Corentin Labbe wrote:
> >>> The DMA clock is handled by the DMA controller, so the crypto does not
> >>> have to touch it.
> >>>
> >>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> >>> ---
> >>> drivers/crypto/rockchip/rk3288_crypto.c | 16 +---------------
> >>> drivers/crypto/rockchip/rk3288_crypto.h | 1 -
> >>> 2 files changed, 1 insertion(+), 16 deletions(-)
> >>>
> >>> diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> index 94ef1283789f..645855d2651b 100644
> >>> --- a/drivers/crypto/rockchip/rk3288_crypto.c
> >>> +++ b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> @@ -40,15 +40,8 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>> __func__, __LINE__);
> >>> goto err_hclk;
> >>> }
> >>> - err = clk_prepare_enable(dev->dmaclk);
> >>> - if (err) {
> >>> - dev_err(dev->dev, "[%s:%d], Couldn't enable clock dmaclk\n",
> >>> - __func__, __LINE__);
> >>> - goto err_dmaclk;
> >>> - }
> >>> +
> >>> return err;
> >>> -err_dmaclk:
> >>> - clk_disable_unprepare(dev->hclk);
> >>> err_hclk:
> >>> clk_disable_unprepare(dev->aclk);
> >>> err_aclk:
> >>> @@ -59,7 +52,6 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>>
> >>> static void rk_crypto_disable_clk(struct rk_crypto_info *dev)
> >>> {
> >>> - clk_disable_unprepare(dev->dmaclk);
> >>> clk_disable_unprepare(dev->hclk);
> >>> clk_disable_unprepare(dev->aclk);
> >>> clk_disable_unprepare(dev->sclk);
> >>> @@ -199,12 +191,6 @@ static int rk_crypto_probe(struct platform_device *pdev)
> >>> goto err_crypto;
> >>> }
> >>>
> >>
> >>> - crypto_info->dmaclk = devm_clk_get(&pdev->dev, "apb_pclk");
> >>> - if (IS_ERR(crypto_info->dmaclk)) {
> >>> - err = PTR_ERR(crypto_info->dmaclk);
> >>> - goto err_crypto;
> >>> - }
> >>> -
> >>
> >> rk3288:
> >> clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> >> - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> >> - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >>
> >> rk3328:
> >> + clocks = <&cru HCLK_CRYPTO_MST>, <&cru HCLK_CRYPTO_SLV>,
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >> The HCLK_CRYPTO_MST not is related to ACLK_CRYPTO.
> >> You are reusing rk3288 names to not to change the driver.
> >> Give it an other name.
> >
> > You are right, I will change them.
> >
> >
> >>
> >> ===
> >>
>
> >> The sclk goes through a crypto_div_con.
> >> Does that need a frequency set?
> >> Or does that come from nowhere?
> >>
> >> From crypto_v1.c
> >> priv->frequency = dev_read_u32_default(dev, "clock-frequency",
> >> CRYPTO_V1_DEFAULT_RATE);
> >>
> >> ret = clk_set_rate(&priv->sclk, priv->frequency);
> >>
> >
>
> > The problem is that I dont see any hints for this in TRM, and their rockchips source are inconsistent, they do this in uboot not in linux....
>
> Rockchip RK3288TRM V1.2 Part2-20170321.pdf
> page 1419
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> For rk3228/rk3328:
> Rockchip RK3228TRM V0.1 20151016-Part3 Graphic and Multi-media.pdf
> page 476
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> Rockchip RK3399TRM V1.1 Part3 20160728.pdf
> page 781
>
> Make sure F crypto do not exceed 200M.
>
> ===
>
> They all have a limit.
> Rockchip uses a default in there drivers and in there TRM tables.
> Then stay consistant and use that too what is already set by the bootloader.
> (till someone comes up with a better (yet unknown) approuch)
>
> #define CRYPTO_V1_DEFAULT_RATE 100000000
>
> ===
>
> Could you disclose your sclk frequency table from:
>
> /sys/kernel/debug/clk/clk_summary
>
> Does that fit within the limits?
>
Hello
On my rk3328-rock64, sclk is 240Mhz, so far beyond the limit.
[ 32.416633] rk3288-crypto ff060000.crypto: CLK 0 hclk_master 75000000 75Mhz
[ 32.417292] rk3288-crypto ff060000.crypto: CLK 1 hclk_slave 75000000 75Mhz
[ 32.417926] rk3288-crypto ff060000.crypto: CLK 2 sclk 240000000 240Mhz
But everything is stable even with this value.
I remember trying overcloacking allwinner crypto, things broke really fast.
I will try to collect values from other SoCs.
enable prepare protect duty hardware
clock count count count rate accuracy phase cycle enable
-------------------------------------------------------------------------------------------------------
rk805-clkout2 0 0 0 32768 0 0 50000 Y
xin32k 0 0 0 32768 0 0 50000 Y
gmac_clkin 1 1 0 125000000 0 0 50000 Y
clk_mac2io 2 2 0 125000000 0 0 50000 Y
clk_mac2io_ref 0 0 0 125000000 0 0 50000 N
clk_mac2io_rx 0 0 0 125000000 0 0 50000 N
clk_mac2io_tx 1 1 0 125000000 0 0 50000 Y
clk_mac2io_refout 0 0 0 125000000 0 0 50000 N
clk_mac2io_ext 0 0 0 125000000 0 0 50000 Y
xin24m 8 8 0 24000000 0 0 50000 Y
hdmi_phy 0 0 0 148500000 0 0 50000 Y
usb480m_phy 4 4 0 480000000 0 0 50000 Y
usb480m 0 0 0 480000000 0 0 50000 Y
sclk_uart1 0 0 0 24000000 0 0 50000 Y
sclk_uart0 0 0 0 24000000 0 0 50000 Y
xin12m 0 0 0 12000000 0 0 50000 Y
clk_usb3otg_suspend 0 0 0 30770 0 0 50000 N
clk_usb3otg_ref 0 0 0 24000000 0 0 50000 N
clk_ref_usb3otg 0 0 0 24000000 0 0 50000 Y
clk_emmc 0 0 0 200000 0 0 50000 N
emmc_sample 0 0 0 100000 0 0 50000 Y
emmc_drv 0 0 0 100000 0 90 50000 Y
sclk_hdmi_sfc 0 0 0 24000000 0 0 50000 N
sclk_timer5 0 0 0 24000000 0 0 50000 N
sclk_timer4 0 0 0 24000000 0 0 50000 N
sclk_timer3 0 0 0 24000000 0 0 50000 N
sclk_timer2 0 0 0 24000000 0 0 50000 N
sclk_timer1 0 0 0 24000000 0 0 50000 N
sclk_timer0 0 0 0 24000000 0 0 50000 N
clk_efuse 0 0 0 12000000 0 0 50000 N
clk_otp 0 0 0 24000000 0 0 50000 N
sclk_uart2 1 1 0 24000000 0 0 50000 Y
clk_ddrmon 0 0 0 24000000 0 0 50000 Y
hdmiphy 0 0 0 24000000 0 0 50000 Y
dclk_lcdc 0 0 0 24000000 0 0 50000 Y
hdmiphy_peri 0 0 0 24000000 0 0 50000 Y
clk_24m 1 1 0 24000000 0 0 50000 Y
clk_saradc 0 0 0 49897 0 0 50000 N
clk_tsadc 1 1 0 50000 0 0 50000 Y
pll_npll 1 1 0 1200000000 0 0 50000 Y
npll 1 1 0 1200000000 0 0 50000 Y
npll_core 1 1 0 1200000000 0 0 50000 Y
armclk 2 2 0 1200000000 0 0 50000 Y
pclk_dbg 1 1 0 200000000 0 0 50000 Y
aclk_core 2 2 0 600000000 0 0 50000 Y
aclk_gic400 1 1 0 600000000 0 0 50000 Y
aclk_core_niu 1 1 0 600000000 0 0 50000 Y
pll_gpll 1 1 0 491520000 0 0 50000 Y
gpll 3 3 0 491520000 0 0 50000 Y
clk_rtc32k 0 0 0 32768 0 0 50000 N
aclk_gmac 3 3 0 163840000 0 0 50000 Y
aclk_gmac_niu 1 1 0 163840000 0 0 50000 Y
aclk_mac2io 1 1 0 163840000 0 0 50000 Y
aclk_mac2phy 0 0 0 163840000 0 0 50000 N
pclk_gmac 2 2 0 54613334 0 0 50000 Y
pclk_gmac_niu 1 1 0 54613334 0 0 50000 Y
pclk_mac2io 1 1 0 54613334 0 0 50000 Y
pclk_mac2phy 0 0 0 54613334 0 0 50000 N
gpll_peri 0 0 0 491520000 0 0 50000 N
clk_rga 0 0 0 163840000 0 0 50000 N
clk_spi 0 0 0 15360000 0 0 50000 N
aclk_gpu_pre 1 1 0 163840000 0 0 50000 Y
aclk_gpu_niu 1 1 0 163840000 0 0 50000 Y
aclk_gpu 0 0 0 163840000 0 0 50000 N
gpll_core 1 1 0 491520000 0 0 50000 Y
pll_cpll 1 1 0 1200000000 0 0 50000 Y
cpll 10 11 0 1200000000 0 0 50000 Y
clk_sdmmc 0 0 0 100000000 0 0 50000 N
sdmmc_sample 0 0 0 50000000 0 0 50000 Y
sdmmc_drv 0 0 0 50000000 0 90 50000 Y
aclk_bus_pre 4 5 0 150000000 0 0 50000 Y
aclk_dmac_bus 0 1 0 150000000 0 0 50000 N
aclk_intmem 1 1 0 150000000 0 0 50000 Y
aclk_tsp 0 0 0 150000000 0 0 50000 N
aclk_dcf 0 0 0 150000000 0 0 50000 N
aclk_bus_niu 1 1 0 150000000 0 0 50000 Y
pclk_bus_pre 2 2 0 75000000 0 0 50000 Y
pclk_phy_pre 3 3 0 75000000 0 0 50000 Y
pclk_phy_niu 1 1 0 75000000 0 0 50000 Y
pclk_vdacphy 0 0 0 75000000 0 0 50000 Y
pclk_hdmiphy 1 1 0 75000000 0 0 50000 Y
pclk_acodecphy 0 0 0 75000000 0 0 50000 N
pclk_ddrphy 1 1 0 75000000 0 0 50000 N
pclk_usb2_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3phy_pipe 0 0 0 75000000 0 0 50000 N
pclk_usb3phy_otg 0 0 0 75000000 0 0 50000 N
pclk_bus 14 15 0 75000000 0 0 50000 Y
pclk_wdt 1 1 0 75000000 0 0 50000 Y
pclk_pmu 1 1 0 75000000 0 0 50000 Y
pclk_saradc 0 0 0 75000000 0 0 50000 N
pclk_sim 0 0 0 75000000 0 0 50000 Y
pclk_sgrf 1 1 0 75000000 0 0 50000 Y
pclk_cru 1 1 0 75000000 0 0 50000 Y
pclk_grf 1 1 0 75000000 0 0 50000 Y
pclk_dcf 0 0 0 75000000 0 0 50000 N
pclk_tsadc 1 1 0 75000000 0 0 50000 Y
pclk_uart2 1 1 0 75000000 0 0 50000 Y
pclk_uart1 0 0 0 75000000 0 0 50000 N
pclk_uart0 0 0 0 75000000 0 0 50000 N
pclk_gpio3 1 1 0 75000000 0 0 50000 Y
pclk_gpio2 1 1 0 75000000 0 0 50000 Y
pclk_gpio1 1 1 0 75000000 0 0 50000 Y
pclk_gpio0 1 1 0 75000000 0 0 50000 Y
pclk_rk_pwm 0 0 0 75000000 0 0 50000 N
pclk_spi 0 0 0 75000000 0 0 50000 N
pclk_stimer 0 0 0 75000000 0 0 50000 N
pclk_timer0 1 1 0 75000000 0 0 50000 Y
pclk_i2c3 0 0 0 75000000 0 0 50000 N
pclk_i2c2 0 0 0 75000000 0 0 50000 N
pclk_i2c1 0 1 0 75000000 0 0 50000 N
pclk_i2c0 0 0 0 75000000 0 0 50000 N
pclk_otp 0 0 0 75000000 0 0 50000 Y
pclk_efuse 0 0 0 75000000 0 0 50000 Y
pclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_bus_pre 2 2 0 75000000 0 0 50000 Y
hclk_pdm 0 0 0 75000000 0 0 50000 N
hclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_crypto_slv 0 0 0 75000000 0 0 50000 N
hclk_crypto_mst 0 0 0 75000000 0 0 50000 N
hclk_tsp 0 0 0 75000000 0 0 50000 N
hclk_spdif_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s2_2ch 0 0 0 75000000 0 0 50000 N
hclk_i2s1_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s0_8ch 0 0 0 75000000 0 0 50000 N
hclk_rom 1 1 0 75000000 0 0 50000 Y
clk_wifi 0 0 0 24000000 0 0 50000 N
sclk_vdec_core 0 0 0 100000000 0 0 50000 N
sclk_vdec_cabac 0 0 0 100000000 0 0 50000 N
aclk_vpu_pre 2 3 0 400000000 0 0 50000 Y
aclk_vpu_niu 1 1 0 400000000 0 0 50000 Y
aclk_vpu 0 5 0 400000000 0 0 50000 N
hclk_vpu_pre 1 2 0 100000000 0 0 50000 Y
hclk_vpu_niu 1 1 0 100000000 0 0 50000 Y
hclk_vpu 0 5 0 100000000 0 0 50000 N
aclk_rga_pre 1 1 0 100000000 0 0 50000 Y
aclk_rga_niu 1 1 0 100000000 0 0 50000 Y
aclk_rga 0 0 0 100000000 0 0 50000 N
aclk_vio_pre 2 2 0 100000000 0 0 50000 Y
aclk_vio_niu 1 1 0 100000000 0 0 50000 Y
aclk_hdcp 0 0 0 100000000 0 0 50000 N
aclk_cif 0 0 0 100000000 0 0 50000 N
aclk_iep 0 0 0 100000000 0 0 50000 N
hclk_vio_pre 5 6 0 33333334 0 0 50000 Y
pclk_hdcp 0 0 0 33333334 0 0 50000 N
pclk_hdmi 0 0 0 33333334 0 0 50000 N
hclk_vio_niu 1 1 0 33333334 0 0 50000 Y
hclk_hdcp 0 0 0 33333334 0 0 50000 N
hclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
pclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
hclk_ahb1tom 1 1 0 33333334 0 0 50000 Y
hclk_rga 0 0 0 33333334 0 0 50000 N
hclk_cif 0 0 0 33333334 0 0 50000 N
hclk_iep 0 0 0 33333334 0 0 50000 N
hclk_vop_niu 1 1 0 33333334 0 0 50000 Y
hclk_vop 0 1 0 33333334 0 0 50000 N
clk_mac2phy_src 0 0 0 75000000 0 0 50000 N
clk_mac2phy 0 0 0 75000000 0 0 50000 Y
clk_mac2phy_ref 0 0 0 75000000 0 0 50000 N
clk_mac2phy_rxtx 0 0 0 75000000 0 0 50000 N
clk_mac2phy_out 0 0 0 75000000 0 0 50000 N
clk_mac2io_out 0 0 0 150000000 0 0 50000 N
clk_mac2io_src 0 0 0 200000000 0 0 50000 N
clk_ref_usb3otg_src 0 0 0 37500000 0 0 50000 N
clk_sdmmc_ext 0 0 0 300000000 0 0 50000 N
sdmmc_ext_sample 0 0 0 150000000 0 0 50000 Y
sdmmc_ext_drv 0 0 0 150000000 0 180 50000 Y
clk_sdio 0 0 0 50000000 0 0 50000 N
sdio_sample 0 0 0 25000000 0 0 50000 Y
sdio_drv 0 0 0 25000000 0 180 50000 Y
cpll_peri 1 1 0 1200000000 0 0 50000 Y
aclk_peri_pre 3 3 0 150000000 0 0 50000 Y
aclk_peri 1 1 0 150000000 0 0 50000 Y
aclk_usb3otg 0 0 0 150000000 0 0 50000 N
aclk_peri_noc 0 0 0 150000000 0 0 50000 Y
hclk_peri 7 7 0 75000000 0 0 50000 Y
pclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_otg_pmu 1 1 0 75000000 0 0 50000 Y
hclk_otg 1 1 0 75000000 0 0 50000 Y
hclk_host0_arb 0 0 0 75000000 0 0 50000 Y
hclk_host0 2 2 0 75000000 0 0 50000 Y
hclk_sdmmc_ext 0 0 0 75000000 0 0 50000 N
hclk_emmc 0 0 0 75000000 0 0 50000 N
hclk_sdio 0 0 0 75000000 0 0 50000 N
hclk_sdmmc 1 1 0 75000000 0 0 50000 Y
pclk_peri 1 1 0 75000000 0 0 50000 Y
dclk_lcdc_src 1 1 0 24000000 0 0 50000 Y
dclk_hdmiphy 1 1 0 8000000 0 0 50000 Y
clk_cif_src 0 0 0 1200000000 0 0 50000 N
clk_cif_out 0 0 0 60000000 0 0 50000 Y
aclk_vop_pre 1 2 0 100000000 0 0 50000 Y
aclk_vop_niu 1 1 0 100000000 0 0 50000 Y
aclk_vop 0 1 0 100000000 0 0 50000 N
sclk_venc_dsp 0 0 0 50000000 0 0 50000 N
sclk_venc_core 0 0 0 50000000 0 0 50000 N
aclk_rkvenc 2 2 0 50000000 0 0 50000 Y
aclk_axisram 0 0 0 50000000 0 0 50000 Y
aclk_h264 0 0 0 50000000 0 0 50000 N
aclk_h265 0 0 0 50000000 0 0 50000 N
aclk_rkvenc_niu 1 1 0 50000000 0 0 50000 Y
hclk_rkvenc 1 1 0 12500000 0 0 50000 Y
hclk_h264 0 0 0 12500000 0 0 50000 N
pclk_h265 0 0 0 12500000 0 0 50000 N
hclk_rkvenc_niu 1 1 0 12500000 0 0 50000 Y
aclk_rkvdec_pre 2 2 0 100000000 0 0 50000 Y
aclk_rkvdec_niu 1 1 0 100000000 0 0 50000 Y
aclk_rkvdec 0 0 0 100000000 0 0 50000 N
hclk_rkvdec_pre 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec_niu 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec 0 0 0 25000000 0 0 50000 N
clk_pwm 0 0 0 150000000 0 0 50000 N
clk_crypto 0 0 0 240000000 0 0 50000 N
clk_i2c3 0 0 0 150000000 0 0 50000 N
clk_i2c2 0 0 0 150000000 0 0 50000 N
clk_i2c1 0 1 0 150000000 0 0 50000 N
clk_i2c0 0 0 0 150000000 0 0 50000 N
clk_uart2_div 0 0 0 150000000 0 0 50000 N
clk_uart2_frac 0 0 0 7500000 0 0 50000 N
clk_uart1_div 0 0 0 150000000 0 0 50000 N
clk_uart1_frac 0 0 0 7500000 0 0 50000 N
clk_uart0_div 0 0 0 150000000 0 0 50000 N
clk_uart0_frac 0 0 0 7500000 0 0 50000 N
clk_spdif_div 0 0 0 75000000 0 0 50000 N
sclk_spdif 0 0 0 75000000 0 0 50000 Y
clk_spdif_frac 0 0 0 3750000 0 0 50000 N
clk_i2s2_div 0 0 0 75000000 0 0 50000 N
i2s2_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s2 0 0 0 75000000 0 0 50000 N
i2s2_out 0 0 0 75000000 0 0 50000 N
clk_i2s2_frac 0 0 0 3750000 0 0 50000 N
clk_i2s1_div 0 0 0 75000000 0 0 50000 N
i2s1_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s1 0 0 0 75000000 0 0 50000 N
i2s1_out 0 0 0 75000000 0 0 50000 N
clk_i2s1_frac 0 0 0 3750000 0 0 50000 N
clk_i2s0_div 0 0 0 75000000 0 0 50000 N
i2s0_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s0 0 0 0 75000000 0 0 50000 N
clk_i2s0_frac 0 0 0 3750000 0 0 50000 N
clk_tsp 0 0 0 50000000 0 0 50000 N
pclk_ddr 3 3 0 150000000 0 0 50000 Y
pclk_ddr_grf 1 1 0 150000000 0 0 50000 Y
pclk_ddrstdby 0 0 0 150000000 0 0 50000 Y
pclk_ddr_mon 1 1 0 150000000 0 0 50000 Y
pclk_ddr_msch 1 1 0 150000000 0 0 50000 Y
pclk_ddrupctl 0 0 0 150000000 0 0 50000 Y
pll_dpll 1 1 0 1596000000 0 0 50000 Y
dpll 1 1 0 1596000000 0 0 50000 Y
clk_ddr 2 2 0 1596000000 0 0 50000 Y
aclk_ddrupctl 0 0 0 1596000000 0 0 50000 Y
clk_ddrupctl 1 1 0 1596000000 0 0 50000 Y
clk_ddrmsch 1 1 0 1596000000 0 0 50000 Y
dpll_core 0 0 0 1596000000 0 0 50000 Y
pll_apll 0 0 0 61440000 0 0 50000 Y
apll 0 0 0 61440000 0 0 50000 Y
clk_pdm 0 0 0 61440000 0 0 50000 N
apll_core 0 0 0 61440000 0 0 50000 Y
clk_hsadc_tsp 0 0 0 0 0 0 50000 N
clk_jtag 1 1 0 0 0 0 50000 Y
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: heiko@sntech.de, herbert@gondor.apana.org.au, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, john@metanate.com
Subject: Re: [PATCH v2 11/18] crypto: rockhip: do not handle dma clock
Date: Tue, 15 Mar 2022 12:45:55 +0100 [thread overview]
Message-ID: <YjB8c6gfPyUmzYpd@Red> (raw)
In-Reply-To: <9295c92e-e054-8817-c96c-b33821643ce7@gmail.com>
Le Thu, Mar 10, 2022 at 06:52:15PM +0100, Johan Jonker a écrit :
>
>
> On 3/10/22 15:45, LABBE Corentin wrote:
> > Le Fri, Mar 04, 2022 at 04:01:58PM +0100, Johan Jonker a écrit :
> >> Hi Corentin,
> >>
> >> Make your clock driver parsing portable.
> >>
> >> ===
> >> oneOf:
> >> - const: rockchip,rk3288-crypto
> >> - items:
> >> - enum:
> >> - rockchip,rk3328-crypto
> >> - const: rockchip,rk3288-crypto
> >>
> >> Compatible string must be SoC related!
> >>
> >> rk3288 was the first in line that had support, so we use that as fall
> >> back string.
> >>
> >> ===
> >>
> >> Make binding fit for more SoC types.
> >> Allow more clocks by using devm_clk_bulk_get_all.
> >
> > Hello
> >
> > Thanks for the hint of devm_clk_bulk_get_all, I will switch to it as it simplify clock handling.
> >
> >> Drop reset-names requirement for devm_reset_control_array_get_exclusive.
> >>
> >> ===
> >>
> >> Use a patch order to prevent the scripts generate notifications.
> >
>
> > which scripts ?
>
> For Linux users:
> ./scripts/checkpatch.pl --strict <patch1> <patch2>
>
> Device tree maintainer rob+dt:
> A bot with unknown scripts.
>
> >
> >>
>
>
> - dts rk3288 clock removal
>
> >> - dt-bindings conversion
> >>
> >> - add rk3328 compatible string in a separate patch
> + new clock names
>
>
> >>
> >> - your driver changes
> >>
> >> - dts patches
> >>
> >> A proposed maintainer must be able to submit patch series without errors. ;)
> >>
> >> ===
> >>
> >> When you remove a clock in a YAML conversion you must add a note to the
> >> DT maintainer.
> >>
> >> ===
> >>
> >> Johan
> >>
> >> On 3/2/22 22:11, Corentin Labbe wrote:
> >>> The DMA clock is handled by the DMA controller, so the crypto does not
> >>> have to touch it.
> >>>
> >>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> >>> ---
> >>> drivers/crypto/rockchip/rk3288_crypto.c | 16 +---------------
> >>> drivers/crypto/rockchip/rk3288_crypto.h | 1 -
> >>> 2 files changed, 1 insertion(+), 16 deletions(-)
> >>>
> >>> diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> index 94ef1283789f..645855d2651b 100644
> >>> --- a/drivers/crypto/rockchip/rk3288_crypto.c
> >>> +++ b/drivers/crypto/rockchip/rk3288_crypto.c
> >>> @@ -40,15 +40,8 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>> __func__, __LINE__);
> >>> goto err_hclk;
> >>> }
> >>> - err = clk_prepare_enable(dev->dmaclk);
> >>> - if (err) {
> >>> - dev_err(dev->dev, "[%s:%d], Couldn't enable clock dmaclk\n",
> >>> - __func__, __LINE__);
> >>> - goto err_dmaclk;
> >>> - }
> >>> +
> >>> return err;
> >>> -err_dmaclk:
> >>> - clk_disable_unprepare(dev->hclk);
> >>> err_hclk:
> >>> clk_disable_unprepare(dev->aclk);
> >>> err_aclk:
> >>> @@ -59,7 +52,6 @@ static int rk_crypto_enable_clk(struct rk_crypto_info *dev)
> >>>
> >>> static void rk_crypto_disable_clk(struct rk_crypto_info *dev)
> >>> {
> >>> - clk_disable_unprepare(dev->dmaclk);
> >>> clk_disable_unprepare(dev->hclk);
> >>> clk_disable_unprepare(dev->aclk);
> >>> clk_disable_unprepare(dev->sclk);
> >>> @@ -199,12 +191,6 @@ static int rk_crypto_probe(struct platform_device *pdev)
> >>> goto err_crypto;
> >>> }
> >>>
> >>
> >>> - crypto_info->dmaclk = devm_clk_get(&pdev->dev, "apb_pclk");
> >>> - if (IS_ERR(crypto_info->dmaclk)) {
> >>> - err = PTR_ERR(crypto_info->dmaclk);
> >>> - goto err_crypto;
> >>> - }
> >>> -
> >>
> >> rk3288:
> >> clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> >> - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> >> - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >>
> >> rk3328:
> >> + clocks = <&cru HCLK_CRYPTO_MST>, <&cru HCLK_CRYPTO_SLV>,
> >> + <&cru SCLK_CRYPTO>;
> >> + clock-names = "aclk", "hclk", "sclk";
> >>
> >> The HCLK_CRYPTO_MST not is related to ACLK_CRYPTO.
> >> You are reusing rk3288 names to not to change the driver.
> >> Give it an other name.
> >
> > You are right, I will change them.
> >
> >
> >>
> >> ===
> >>
>
> >> The sclk goes through a crypto_div_con.
> >> Does that need a frequency set?
> >> Or does that come from nowhere?
> >>
> >> From crypto_v1.c
> >> priv->frequency = dev_read_u32_default(dev, "clock-frequency",
> >> CRYPTO_V1_DEFAULT_RATE);
> >>
> >> ret = clk_set_rate(&priv->sclk, priv->frequency);
> >>
> >
>
> > The problem is that I dont see any hints for this in TRM, and their rockchips source are inconsistent, they do this in uboot not in linux....
>
> Rockchip RK3288TRM V1.2 Part2-20170321.pdf
> page 1419
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> For rk3228/rk3328:
> Rockchip RK3228TRM V0.1 20151016-Part3 Graphic and Multi-media.pdf
> page 476
>
> Make sure F crypto do not exceed 150M.
>
> ===
>
> Rockchip RK3399TRM V1.1 Part3 20160728.pdf
> page 781
>
> Make sure F crypto do not exceed 200M.
>
> ===
>
> They all have a limit.
> Rockchip uses a default in there drivers and in there TRM tables.
> Then stay consistant and use that too what is already set by the bootloader.
> (till someone comes up with a better (yet unknown) approuch)
>
> #define CRYPTO_V1_DEFAULT_RATE 100000000
>
> ===
>
> Could you disclose your sclk frequency table from:
>
> /sys/kernel/debug/clk/clk_summary
>
> Does that fit within the limits?
>
Hello
On my rk3328-rock64, sclk is 240Mhz, so far beyond the limit.
[ 32.416633] rk3288-crypto ff060000.crypto: CLK 0 hclk_master 75000000 75Mhz
[ 32.417292] rk3288-crypto ff060000.crypto: CLK 1 hclk_slave 75000000 75Mhz
[ 32.417926] rk3288-crypto ff060000.crypto: CLK 2 sclk 240000000 240Mhz
But everything is stable even with this value.
I remember trying overcloacking allwinner crypto, things broke really fast.
I will try to collect values from other SoCs.
enable prepare protect duty hardware
clock count count count rate accuracy phase cycle enable
-------------------------------------------------------------------------------------------------------
rk805-clkout2 0 0 0 32768 0 0 50000 Y
xin32k 0 0 0 32768 0 0 50000 Y
gmac_clkin 1 1 0 125000000 0 0 50000 Y
clk_mac2io 2 2 0 125000000 0 0 50000 Y
clk_mac2io_ref 0 0 0 125000000 0 0 50000 N
clk_mac2io_rx 0 0 0 125000000 0 0 50000 N
clk_mac2io_tx 1 1 0 125000000 0 0 50000 Y
clk_mac2io_refout 0 0 0 125000000 0 0 50000 N
clk_mac2io_ext 0 0 0 125000000 0 0 50000 Y
xin24m 8 8 0 24000000 0 0 50000 Y
hdmi_phy 0 0 0 148500000 0 0 50000 Y
usb480m_phy 4 4 0 480000000 0 0 50000 Y
usb480m 0 0 0 480000000 0 0 50000 Y
sclk_uart1 0 0 0 24000000 0 0 50000 Y
sclk_uart0 0 0 0 24000000 0 0 50000 Y
xin12m 0 0 0 12000000 0 0 50000 Y
clk_usb3otg_suspend 0 0 0 30770 0 0 50000 N
clk_usb3otg_ref 0 0 0 24000000 0 0 50000 N
clk_ref_usb3otg 0 0 0 24000000 0 0 50000 Y
clk_emmc 0 0 0 200000 0 0 50000 N
emmc_sample 0 0 0 100000 0 0 50000 Y
emmc_drv 0 0 0 100000 0 90 50000 Y
sclk_hdmi_sfc 0 0 0 24000000 0 0 50000 N
sclk_timer5 0 0 0 24000000 0 0 50000 N
sclk_timer4 0 0 0 24000000 0 0 50000 N
sclk_timer3 0 0 0 24000000 0 0 50000 N
sclk_timer2 0 0 0 24000000 0 0 50000 N
sclk_timer1 0 0 0 24000000 0 0 50000 N
sclk_timer0 0 0 0 24000000 0 0 50000 N
clk_efuse 0 0 0 12000000 0 0 50000 N
clk_otp 0 0 0 24000000 0 0 50000 N
sclk_uart2 1 1 0 24000000 0 0 50000 Y
clk_ddrmon 0 0 0 24000000 0 0 50000 Y
hdmiphy 0 0 0 24000000 0 0 50000 Y
dclk_lcdc 0 0 0 24000000 0 0 50000 Y
hdmiphy_peri 0 0 0 24000000 0 0 50000 Y
clk_24m 1 1 0 24000000 0 0 50000 Y
clk_saradc 0 0 0 49897 0 0 50000 N
clk_tsadc 1 1 0 50000 0 0 50000 Y
pll_npll 1 1 0 1200000000 0 0 50000 Y
npll 1 1 0 1200000000 0 0 50000 Y
npll_core 1 1 0 1200000000 0 0 50000 Y
armclk 2 2 0 1200000000 0 0 50000 Y
pclk_dbg 1 1 0 200000000 0 0 50000 Y
aclk_core 2 2 0 600000000 0 0 50000 Y
aclk_gic400 1 1 0 600000000 0 0 50000 Y
aclk_core_niu 1 1 0 600000000 0 0 50000 Y
pll_gpll 1 1 0 491520000 0 0 50000 Y
gpll 3 3 0 491520000 0 0 50000 Y
clk_rtc32k 0 0 0 32768 0 0 50000 N
aclk_gmac 3 3 0 163840000 0 0 50000 Y
aclk_gmac_niu 1 1 0 163840000 0 0 50000 Y
aclk_mac2io 1 1 0 163840000 0 0 50000 Y
aclk_mac2phy 0 0 0 163840000 0 0 50000 N
pclk_gmac 2 2 0 54613334 0 0 50000 Y
pclk_gmac_niu 1 1 0 54613334 0 0 50000 Y
pclk_mac2io 1 1 0 54613334 0 0 50000 Y
pclk_mac2phy 0 0 0 54613334 0 0 50000 N
gpll_peri 0 0 0 491520000 0 0 50000 N
clk_rga 0 0 0 163840000 0 0 50000 N
clk_spi 0 0 0 15360000 0 0 50000 N
aclk_gpu_pre 1 1 0 163840000 0 0 50000 Y
aclk_gpu_niu 1 1 0 163840000 0 0 50000 Y
aclk_gpu 0 0 0 163840000 0 0 50000 N
gpll_core 1 1 0 491520000 0 0 50000 Y
pll_cpll 1 1 0 1200000000 0 0 50000 Y
cpll 10 11 0 1200000000 0 0 50000 Y
clk_sdmmc 0 0 0 100000000 0 0 50000 N
sdmmc_sample 0 0 0 50000000 0 0 50000 Y
sdmmc_drv 0 0 0 50000000 0 90 50000 Y
aclk_bus_pre 4 5 0 150000000 0 0 50000 Y
aclk_dmac_bus 0 1 0 150000000 0 0 50000 N
aclk_intmem 1 1 0 150000000 0 0 50000 Y
aclk_tsp 0 0 0 150000000 0 0 50000 N
aclk_dcf 0 0 0 150000000 0 0 50000 N
aclk_bus_niu 1 1 0 150000000 0 0 50000 Y
pclk_bus_pre 2 2 0 75000000 0 0 50000 Y
pclk_phy_pre 3 3 0 75000000 0 0 50000 Y
pclk_phy_niu 1 1 0 75000000 0 0 50000 Y
pclk_vdacphy 0 0 0 75000000 0 0 50000 Y
pclk_hdmiphy 1 1 0 75000000 0 0 50000 Y
pclk_acodecphy 0 0 0 75000000 0 0 50000 N
pclk_ddrphy 1 1 0 75000000 0 0 50000 N
pclk_usb2_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3_grf 0 0 0 75000000 0 0 50000 Y
pclk_usb3phy_pipe 0 0 0 75000000 0 0 50000 N
pclk_usb3phy_otg 0 0 0 75000000 0 0 50000 N
pclk_bus 14 15 0 75000000 0 0 50000 Y
pclk_wdt 1 1 0 75000000 0 0 50000 Y
pclk_pmu 1 1 0 75000000 0 0 50000 Y
pclk_saradc 0 0 0 75000000 0 0 50000 N
pclk_sim 0 0 0 75000000 0 0 50000 Y
pclk_sgrf 1 1 0 75000000 0 0 50000 Y
pclk_cru 1 1 0 75000000 0 0 50000 Y
pclk_grf 1 1 0 75000000 0 0 50000 Y
pclk_dcf 0 0 0 75000000 0 0 50000 N
pclk_tsadc 1 1 0 75000000 0 0 50000 Y
pclk_uart2 1 1 0 75000000 0 0 50000 Y
pclk_uart1 0 0 0 75000000 0 0 50000 N
pclk_uart0 0 0 0 75000000 0 0 50000 N
pclk_gpio3 1 1 0 75000000 0 0 50000 Y
pclk_gpio2 1 1 0 75000000 0 0 50000 Y
pclk_gpio1 1 1 0 75000000 0 0 50000 Y
pclk_gpio0 1 1 0 75000000 0 0 50000 Y
pclk_rk_pwm 0 0 0 75000000 0 0 50000 N
pclk_spi 0 0 0 75000000 0 0 50000 N
pclk_stimer 0 0 0 75000000 0 0 50000 N
pclk_timer0 1 1 0 75000000 0 0 50000 Y
pclk_i2c3 0 0 0 75000000 0 0 50000 N
pclk_i2c2 0 0 0 75000000 0 0 50000 N
pclk_i2c1 0 1 0 75000000 0 0 50000 N
pclk_i2c0 0 0 0 75000000 0 0 50000 N
pclk_otp 0 0 0 75000000 0 0 50000 Y
pclk_efuse 0 0 0 75000000 0 0 50000 Y
pclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_bus_pre 2 2 0 75000000 0 0 50000 Y
hclk_pdm 0 0 0 75000000 0 0 50000 N
hclk_bus_niu 1 1 0 75000000 0 0 50000 Y
hclk_crypto_slv 0 0 0 75000000 0 0 50000 N
hclk_crypto_mst 0 0 0 75000000 0 0 50000 N
hclk_tsp 0 0 0 75000000 0 0 50000 N
hclk_spdif_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s2_2ch 0 0 0 75000000 0 0 50000 N
hclk_i2s1_8ch 0 0 0 75000000 0 0 50000 N
hclk_i2s0_8ch 0 0 0 75000000 0 0 50000 N
hclk_rom 1 1 0 75000000 0 0 50000 Y
clk_wifi 0 0 0 24000000 0 0 50000 N
sclk_vdec_core 0 0 0 100000000 0 0 50000 N
sclk_vdec_cabac 0 0 0 100000000 0 0 50000 N
aclk_vpu_pre 2 3 0 400000000 0 0 50000 Y
aclk_vpu_niu 1 1 0 400000000 0 0 50000 Y
aclk_vpu 0 5 0 400000000 0 0 50000 N
hclk_vpu_pre 1 2 0 100000000 0 0 50000 Y
hclk_vpu_niu 1 1 0 100000000 0 0 50000 Y
hclk_vpu 0 5 0 100000000 0 0 50000 N
aclk_rga_pre 1 1 0 100000000 0 0 50000 Y
aclk_rga_niu 1 1 0 100000000 0 0 50000 Y
aclk_rga 0 0 0 100000000 0 0 50000 N
aclk_vio_pre 2 2 0 100000000 0 0 50000 Y
aclk_vio_niu 1 1 0 100000000 0 0 50000 Y
aclk_hdcp 0 0 0 100000000 0 0 50000 N
aclk_cif 0 0 0 100000000 0 0 50000 N
aclk_iep 0 0 0 100000000 0 0 50000 N
hclk_vio_pre 5 6 0 33333334 0 0 50000 Y
pclk_hdcp 0 0 0 33333334 0 0 50000 N
pclk_hdmi 0 0 0 33333334 0 0 50000 N
hclk_vio_niu 1 1 0 33333334 0 0 50000 Y
hclk_hdcp 0 0 0 33333334 0 0 50000 N
hclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
pclk_vio_h2p 1 1 0 33333334 0 0 50000 Y
hclk_ahb1tom 1 1 0 33333334 0 0 50000 Y
hclk_rga 0 0 0 33333334 0 0 50000 N
hclk_cif 0 0 0 33333334 0 0 50000 N
hclk_iep 0 0 0 33333334 0 0 50000 N
hclk_vop_niu 1 1 0 33333334 0 0 50000 Y
hclk_vop 0 1 0 33333334 0 0 50000 N
clk_mac2phy_src 0 0 0 75000000 0 0 50000 N
clk_mac2phy 0 0 0 75000000 0 0 50000 Y
clk_mac2phy_ref 0 0 0 75000000 0 0 50000 N
clk_mac2phy_rxtx 0 0 0 75000000 0 0 50000 N
clk_mac2phy_out 0 0 0 75000000 0 0 50000 N
clk_mac2io_out 0 0 0 150000000 0 0 50000 N
clk_mac2io_src 0 0 0 200000000 0 0 50000 N
clk_ref_usb3otg_src 0 0 0 37500000 0 0 50000 N
clk_sdmmc_ext 0 0 0 300000000 0 0 50000 N
sdmmc_ext_sample 0 0 0 150000000 0 0 50000 Y
sdmmc_ext_drv 0 0 0 150000000 0 180 50000 Y
clk_sdio 0 0 0 50000000 0 0 50000 N
sdio_sample 0 0 0 25000000 0 0 50000 Y
sdio_drv 0 0 0 25000000 0 180 50000 Y
cpll_peri 1 1 0 1200000000 0 0 50000 Y
aclk_peri_pre 3 3 0 150000000 0 0 50000 Y
aclk_peri 1 1 0 150000000 0 0 50000 Y
aclk_usb3otg 0 0 0 150000000 0 0 50000 N
aclk_peri_noc 0 0 0 150000000 0 0 50000 Y
hclk_peri 7 7 0 75000000 0 0 50000 Y
pclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_peri_niu 1 1 0 75000000 0 0 50000 Y
hclk_otg_pmu 1 1 0 75000000 0 0 50000 Y
hclk_otg 1 1 0 75000000 0 0 50000 Y
hclk_host0_arb 0 0 0 75000000 0 0 50000 Y
hclk_host0 2 2 0 75000000 0 0 50000 Y
hclk_sdmmc_ext 0 0 0 75000000 0 0 50000 N
hclk_emmc 0 0 0 75000000 0 0 50000 N
hclk_sdio 0 0 0 75000000 0 0 50000 N
hclk_sdmmc 1 1 0 75000000 0 0 50000 Y
pclk_peri 1 1 0 75000000 0 0 50000 Y
dclk_lcdc_src 1 1 0 24000000 0 0 50000 Y
dclk_hdmiphy 1 1 0 8000000 0 0 50000 Y
clk_cif_src 0 0 0 1200000000 0 0 50000 N
clk_cif_out 0 0 0 60000000 0 0 50000 Y
aclk_vop_pre 1 2 0 100000000 0 0 50000 Y
aclk_vop_niu 1 1 0 100000000 0 0 50000 Y
aclk_vop 0 1 0 100000000 0 0 50000 N
sclk_venc_dsp 0 0 0 50000000 0 0 50000 N
sclk_venc_core 0 0 0 50000000 0 0 50000 N
aclk_rkvenc 2 2 0 50000000 0 0 50000 Y
aclk_axisram 0 0 0 50000000 0 0 50000 Y
aclk_h264 0 0 0 50000000 0 0 50000 N
aclk_h265 0 0 0 50000000 0 0 50000 N
aclk_rkvenc_niu 1 1 0 50000000 0 0 50000 Y
hclk_rkvenc 1 1 0 12500000 0 0 50000 Y
hclk_h264 0 0 0 12500000 0 0 50000 N
pclk_h265 0 0 0 12500000 0 0 50000 N
hclk_rkvenc_niu 1 1 0 12500000 0 0 50000 Y
aclk_rkvdec_pre 2 2 0 100000000 0 0 50000 Y
aclk_rkvdec_niu 1 1 0 100000000 0 0 50000 Y
aclk_rkvdec 0 0 0 100000000 0 0 50000 N
hclk_rkvdec_pre 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec_niu 1 1 0 25000000 0 0 50000 Y
hclk_rkvdec 0 0 0 25000000 0 0 50000 N
clk_pwm 0 0 0 150000000 0 0 50000 N
clk_crypto 0 0 0 240000000 0 0 50000 N
clk_i2c3 0 0 0 150000000 0 0 50000 N
clk_i2c2 0 0 0 150000000 0 0 50000 N
clk_i2c1 0 1 0 150000000 0 0 50000 N
clk_i2c0 0 0 0 150000000 0 0 50000 N
clk_uart2_div 0 0 0 150000000 0 0 50000 N
clk_uart2_frac 0 0 0 7500000 0 0 50000 N
clk_uart1_div 0 0 0 150000000 0 0 50000 N
clk_uart1_frac 0 0 0 7500000 0 0 50000 N
clk_uart0_div 0 0 0 150000000 0 0 50000 N
clk_uart0_frac 0 0 0 7500000 0 0 50000 N
clk_spdif_div 0 0 0 75000000 0 0 50000 N
sclk_spdif 0 0 0 75000000 0 0 50000 Y
clk_spdif_frac 0 0 0 3750000 0 0 50000 N
clk_i2s2_div 0 0 0 75000000 0 0 50000 N
i2s2_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s2 0 0 0 75000000 0 0 50000 N
i2s2_out 0 0 0 75000000 0 0 50000 N
clk_i2s2_frac 0 0 0 3750000 0 0 50000 N
clk_i2s1_div 0 0 0 75000000 0 0 50000 N
i2s1_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s1 0 0 0 75000000 0 0 50000 N
i2s1_out 0 0 0 75000000 0 0 50000 N
clk_i2s1_frac 0 0 0 3750000 0 0 50000 N
clk_i2s0_div 0 0 0 75000000 0 0 50000 N
i2s0_pre 0 0 0 75000000 0 0 50000 Y
clk_i2s0 0 0 0 75000000 0 0 50000 N
clk_i2s0_frac 0 0 0 3750000 0 0 50000 N
clk_tsp 0 0 0 50000000 0 0 50000 N
pclk_ddr 3 3 0 150000000 0 0 50000 Y
pclk_ddr_grf 1 1 0 150000000 0 0 50000 Y
pclk_ddrstdby 0 0 0 150000000 0 0 50000 Y
pclk_ddr_mon 1 1 0 150000000 0 0 50000 Y
pclk_ddr_msch 1 1 0 150000000 0 0 50000 Y
pclk_ddrupctl 0 0 0 150000000 0 0 50000 Y
pll_dpll 1 1 0 1596000000 0 0 50000 Y
dpll 1 1 0 1596000000 0 0 50000 Y
clk_ddr 2 2 0 1596000000 0 0 50000 Y
aclk_ddrupctl 0 0 0 1596000000 0 0 50000 Y
clk_ddrupctl 1 1 0 1596000000 0 0 50000 Y
clk_ddrmsch 1 1 0 1596000000 0 0 50000 Y
dpll_core 0 0 0 1596000000 0 0 50000 Y
pll_apll 0 0 0 61440000 0 0 50000 Y
apll 0 0 0 61440000 0 0 50000 Y
clk_pdm 0 0 0 61440000 0 0 50000 N
apll_core 0 0 0 61440000 0 0 50000 Y
clk_hsadc_tsp 0 0 0 0 0 0 50000 N
clk_jtag 1 1 0 0 0 0 50000 Y
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-15 11:46 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 21:10 [PATCH v2 00/18] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` [PATCH v2 01/18] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` [PATCH v2 02/18] crypto: rockchip: do not use uninit variable Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` [PATCH v2 03/18] crypto: rockchip: do not do custom power management Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` [PATCH v2 04/18] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:10 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 05/18] crypto: rockchip: do not store mode globally Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 06/18] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-03 14:21 ` John Keeping
2022-03-03 14:21 ` John Keeping
2022-03-03 14:21 ` John Keeping
2022-03-03 19:54 ` LABBE Corentin
2022-03-03 19:54 ` LABBE Corentin
2022-03-03 19:54 ` LABBE Corentin
2022-03-02 21:11 ` [PATCH v2 07/18] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 08/18] crypto: rockchip: better handle cipher key Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 09/18] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 10/18] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 11/18] crypto: rockhip: do not handle dma clock Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-04 15:01 ` Johan Jonker
2022-03-04 15:01 ` Johan Jonker
2022-03-04 15:01 ` Johan Jonker
2022-03-10 14:45 ` LABBE Corentin
2022-03-10 14:45 ` LABBE Corentin
2022-03-10 14:45 ` LABBE Corentin
2022-03-10 17:52 ` Johan Jonker
2022-03-10 17:52 ` Johan Jonker
2022-03-10 17:52 ` Johan Jonker
2022-03-15 11:45 ` LABBE Corentin [this message]
2022-03-15 11:45 ` LABBE Corentin
2022-03-15 11:45 ` LABBE Corentin
2022-03-02 21:11 ` [PATCH v2 12/18] ARM: dts: rk3288: crypto do not need " Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 13/18] crypto: rockchip: rewrite type Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 14/18] crypto: rockchip: add debugfs Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 15/18] crypto: rockchip: introduce PM Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-03 12:57 ` John Keeping
2022-03-03 12:57 ` John Keeping
2022-03-03 12:57 ` John Keeping
2022-03-02 21:11 ` [PATCH v2 16/18] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` [PATCH v2 17/18] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-03 13:44 ` Rob Herring
2022-03-03 13:44 ` Rob Herring
2022-03-03 13:44 ` Rob Herring
2022-03-03 19:40 ` LABBE Corentin
2022-03-03 19:40 ` LABBE Corentin
2022-03-03 19:40 ` LABBE Corentin
2022-03-08 0:52 ` Rob Herring
2022-03-08 0:52 ` Rob Herring
2022-03-08 0:52 ` Rob Herring
2022-03-02 21:11 ` [PATCH v2 18/18] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
2022-03-02 21:11 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjB8c6gfPyUmzYpd@Red \
--to=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=jbx6244@gmail.com \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.