From: gregkh <gregkh@linuxfoundation.org>
To: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: "dan.carpenter" <dan.carpenter@oracle.com>,
nsaenz <nsaenz@kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-staging <linux-staging@lists.linux.dev>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: mmal-vchiq: add a check for the return of vmalloc()
Date: Wed, 16 Mar 2022 15:08:20 +0100 [thread overview]
Message-ID: <YjHvVM3kug3ritca@kroah.com> (raw)
In-Reply-To: <tencent_84264ACEFF062098CC35B9C01C7A1464E108@qq.com>
On Wed, Mar 16, 2022 at 12:23:05AM +0800, Xiaoke Wang wrote:
> On Tue, 15 Mar 2022 16:27:38 +0100, Greg KH wrote:
> > Your change just crashed the kernel :(
> >
> > Please be more careful
>
> I am sorry. I ever been told that vfree(NULL) or kfree(NULL) is safe,
Sorry, you are right, I was thinking that there would be an error value
there. My mistake.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh <gregkh@linuxfoundation.org>
To: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: "dan.carpenter" <dan.carpenter@oracle.com>,
nsaenz <nsaenz@kernel.org>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-staging <linux-staging@lists.linux.dev>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: mmal-vchiq: add a check for the return of vmalloc()
Date: Wed, 16 Mar 2022 15:08:20 +0100 [thread overview]
Message-ID: <YjHvVM3kug3ritca@kroah.com> (raw)
In-Reply-To: <tencent_84264ACEFF062098CC35B9C01C7A1464E108@qq.com>
On Wed, Mar 16, 2022 at 12:23:05AM +0800, Xiaoke Wang wrote:
> On Tue, 15 Mar 2022 16:27:38 +0100, Greg KH wrote:
> > Your change just crashed the kernel :(
> >
> > Please be more careful
>
> I am sorry. I ever been told that vfree(NULL) or kfree(NULL) is safe,
Sorry, you are right, I was thinking that there would be an error value
there. My mistake.
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-03-16 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-15 14:42 [PATCH v2] staging: mmal-vchiq: add a check for the return of vmalloc() xkernel.wang
2022-03-15 14:42 ` xkernel.wang
2022-03-15 15:27 ` Greg KH
2022-03-15 15:27 ` Greg KH
2022-03-15 15:53 ` Dan Carpenter
2022-03-15 15:53 ` Dan Carpenter
2022-03-15 16:23 ` Xiaoke Wang
2022-03-15 16:23 ` Xiaoke Wang
2022-03-16 14:08 ` gregkh [this message]
2022-03-16 14:08 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjHvVM3kug3ritca@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=xkernel.wang@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.