From: Catalin Marinas <catalin.marinas@arm.com>
To: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
chinwen.chang@mediatek.com, nicholas.tang@mediatek.com,
yee.lee@mediatek.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mm/kmemleak: Reset tag when compare object pointer
Date: Fri, 18 Mar 2022 14:30:43 +0000 [thread overview]
Message-ID: <YjSXkyq6icIFx4GS@arm.com> (raw)
In-Reply-To: <20220318034051.30687-1-Kuan-Ying.Lee@mediatek.com>
On Fri, Mar 18, 2022 at 11:40:48AM +0800, Kuan-Ying Lee wrote:
> When we use HW-tag based kasan and enable vmalloc support, we hit
> the following bug. It is due to comparison between tagged object
> and non-tagged pointer.
>
> We need to reset the kasan tag when we need to compare tagged object
> and non-tagged pointer.
>
> [ 7.690429][T400001] init: kmemleak: [name:kmemleak&]Scan area larger than object 0xffffffe77076f440
> [ 7.691762][T400001] init: CPU: 4 PID: 1 Comm: init Tainted: G S W 5.15.25-android13-0-g5cacf919c2bc #1
> [ 7.693218][T400001] init: Hardware name: MT6983(ENG) (DT)
> [ 7.693983][T400001] init: Call trace:
> [ 7.694508][T400001] init: dump_backtrace.cfi_jt+0x0/0x8
> [ 7.695272][T400001] init: dump_stack_lvl+0xac/0x120
> [ 7.695985][T400001] init: add_scan_area+0xc4/0x244
> [ 7.696685][T400001] init: kmemleak_scan_area+0x40/0x9c
> [ 7.697428][T400001] init: layout_and_allocate+0x1e8/0x288
> [ 7.698211][T400001] init: load_module+0x2c8/0xf00
> [ 7.698895][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.699701][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.700517][T400001] init: invoke_syscall+0x60/0x170
> [ 7.701225][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.701933][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.702580][T400001] init: el0_svc+0x60/0xf8
> [ 7.703196][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.703964][T400001] init: el0t_64_sync+0x1b4/0x1b8
> [ 7.704658][T400001] init: kmemleak: [name:kmemleak&]Object 0xf5ffffe77076b000 (size 32768):
> [ 7.705824][T400001] init: kmemleak: [name:kmemleak&] comm "init", pid 1, jiffies 4294894197
> [ 7.707002][T400001] init: kmemleak: [name:kmemleak&] min_count = 0
> [ 7.707886][T400001] init: kmemleak: [name:kmemleak&] count = 0
> [ 7.708718][T400001] init: kmemleak: [name:kmemleak&] flags = 0x1
> [ 7.709574][T400001] init: kmemleak: [name:kmemleak&] checksum = 0
> [ 7.710440][T400001] init: kmemleak: [name:kmemleak&] backtrace:
> [ 7.711284][T400001] init: module_alloc+0x9c/0x120
> [ 7.712015][T400001] init: move_module+0x34/0x19c
> [ 7.712735][T400001] init: layout_and_allocate+0x1c4/0x288
> [ 7.713561][T400001] init: load_module+0x2c8/0xf00
> [ 7.714291][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.715142][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.716004][T400001] init: invoke_syscall+0x60/0x170
> [ 7.716758][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.717512][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.718207][T400001] init: el0_svc+0x60/0xf8
> [ 7.718869][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.719683][T400001] init: el0t_64_sync+0x1b4/0x1b8
>
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
chinwen.chang@mediatek.com, nicholas.tang@mediatek.com,
yee.lee@mediatek.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mm/kmemleak: Reset tag when compare object pointer
Date: Fri, 18 Mar 2022 14:30:43 +0000 [thread overview]
Message-ID: <YjSXkyq6icIFx4GS@arm.com> (raw)
In-Reply-To: <20220318034051.30687-1-Kuan-Ying.Lee@mediatek.com>
On Fri, Mar 18, 2022 at 11:40:48AM +0800, Kuan-Ying Lee wrote:
> When we use HW-tag based kasan and enable vmalloc support, we hit
> the following bug. It is due to comparison between tagged object
> and non-tagged pointer.
>
> We need to reset the kasan tag when we need to compare tagged object
> and non-tagged pointer.
>
> [ 7.690429][T400001] init: kmemleak: [name:kmemleak&]Scan area larger than object 0xffffffe77076f440
> [ 7.691762][T400001] init: CPU: 4 PID: 1 Comm: init Tainted: G S W 5.15.25-android13-0-g5cacf919c2bc #1
> [ 7.693218][T400001] init: Hardware name: MT6983(ENG) (DT)
> [ 7.693983][T400001] init: Call trace:
> [ 7.694508][T400001] init: dump_backtrace.cfi_jt+0x0/0x8
> [ 7.695272][T400001] init: dump_stack_lvl+0xac/0x120
> [ 7.695985][T400001] init: add_scan_area+0xc4/0x244
> [ 7.696685][T400001] init: kmemleak_scan_area+0x40/0x9c
> [ 7.697428][T400001] init: layout_and_allocate+0x1e8/0x288
> [ 7.698211][T400001] init: load_module+0x2c8/0xf00
> [ 7.698895][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.699701][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.700517][T400001] init: invoke_syscall+0x60/0x170
> [ 7.701225][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.701933][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.702580][T400001] init: el0_svc+0x60/0xf8
> [ 7.703196][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.703964][T400001] init: el0t_64_sync+0x1b4/0x1b8
> [ 7.704658][T400001] init: kmemleak: [name:kmemleak&]Object 0xf5ffffe77076b000 (size 32768):
> [ 7.705824][T400001] init: kmemleak: [name:kmemleak&] comm "init", pid 1, jiffies 4294894197
> [ 7.707002][T400001] init: kmemleak: [name:kmemleak&] min_count = 0
> [ 7.707886][T400001] init: kmemleak: [name:kmemleak&] count = 0
> [ 7.708718][T400001] init: kmemleak: [name:kmemleak&] flags = 0x1
> [ 7.709574][T400001] init: kmemleak: [name:kmemleak&] checksum = 0
> [ 7.710440][T400001] init: kmemleak: [name:kmemleak&] backtrace:
> [ 7.711284][T400001] init: module_alloc+0x9c/0x120
> [ 7.712015][T400001] init: move_module+0x34/0x19c
> [ 7.712735][T400001] init: layout_and_allocate+0x1c4/0x288
> [ 7.713561][T400001] init: load_module+0x2c8/0xf00
> [ 7.714291][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.715142][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.716004][T400001] init: invoke_syscall+0x60/0x170
> [ 7.716758][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.717512][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.718207][T400001] init: el0_svc+0x60/0xf8
> [ 7.718869][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.719683][T400001] init: el0t_64_sync+0x1b4/0x1b8
>
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
chinwen.chang@mediatek.com, nicholas.tang@mediatek.com,
yee.lee@mediatek.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mm/kmemleak: Reset tag when compare object pointer
Date: Fri, 18 Mar 2022 14:30:43 +0000 [thread overview]
Message-ID: <YjSXkyq6icIFx4GS@arm.com> (raw)
In-Reply-To: <20220318034051.30687-1-Kuan-Ying.Lee@mediatek.com>
On Fri, Mar 18, 2022 at 11:40:48AM +0800, Kuan-Ying Lee wrote:
> When we use HW-tag based kasan and enable vmalloc support, we hit
> the following bug. It is due to comparison between tagged object
> and non-tagged pointer.
>
> We need to reset the kasan tag when we need to compare tagged object
> and non-tagged pointer.
>
> [ 7.690429][T400001] init: kmemleak: [name:kmemleak&]Scan area larger than object 0xffffffe77076f440
> [ 7.691762][T400001] init: CPU: 4 PID: 1 Comm: init Tainted: G S W 5.15.25-android13-0-g5cacf919c2bc #1
> [ 7.693218][T400001] init: Hardware name: MT6983(ENG) (DT)
> [ 7.693983][T400001] init: Call trace:
> [ 7.694508][T400001] init: dump_backtrace.cfi_jt+0x0/0x8
> [ 7.695272][T400001] init: dump_stack_lvl+0xac/0x120
> [ 7.695985][T400001] init: add_scan_area+0xc4/0x244
> [ 7.696685][T400001] init: kmemleak_scan_area+0x40/0x9c
> [ 7.697428][T400001] init: layout_and_allocate+0x1e8/0x288
> [ 7.698211][T400001] init: load_module+0x2c8/0xf00
> [ 7.698895][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.699701][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.700517][T400001] init: invoke_syscall+0x60/0x170
> [ 7.701225][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.701933][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.702580][T400001] init: el0_svc+0x60/0xf8
> [ 7.703196][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.703964][T400001] init: el0t_64_sync+0x1b4/0x1b8
> [ 7.704658][T400001] init: kmemleak: [name:kmemleak&]Object 0xf5ffffe77076b000 (size 32768):
> [ 7.705824][T400001] init: kmemleak: [name:kmemleak&] comm "init", pid 1, jiffies 4294894197
> [ 7.707002][T400001] init: kmemleak: [name:kmemleak&] min_count = 0
> [ 7.707886][T400001] init: kmemleak: [name:kmemleak&] count = 0
> [ 7.708718][T400001] init: kmemleak: [name:kmemleak&] flags = 0x1
> [ 7.709574][T400001] init: kmemleak: [name:kmemleak&] checksum = 0
> [ 7.710440][T400001] init: kmemleak: [name:kmemleak&] backtrace:
> [ 7.711284][T400001] init: module_alloc+0x9c/0x120
> [ 7.712015][T400001] init: move_module+0x34/0x19c
> [ 7.712735][T400001] init: layout_and_allocate+0x1c4/0x288
> [ 7.713561][T400001] init: load_module+0x2c8/0xf00
> [ 7.714291][T400001] init: __se_sys_finit_module+0x190/0x1d0
> [ 7.715142][T400001] init: __arm64_sys_finit_module+0x20/0x30
> [ 7.716004][T400001] init: invoke_syscall+0x60/0x170
> [ 7.716758][T400001] init: el0_svc_common+0xc8/0x114
> [ 7.717512][T400001] init: do_el0_svc+0x28/0xa0
> [ 7.718207][T400001] init: el0_svc+0x60/0xf8
> [ 7.718869][T400001] init: el0t_64_sync_handler+0x88/0xec
> [ 7.719683][T400001] init: el0t_64_sync+0x1b4/0x1b8
>
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2022-03-18 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 3:40 [PATCH] mm/kmemleak: Reset tag when compare object pointer Kuan-Ying Lee
2022-03-18 3:40 ` Kuan-Ying Lee
2022-03-18 3:40 ` Kuan-Ying Lee
2022-03-18 14:30 ` Catalin Marinas [this message]
2022-03-18 14:30 ` Catalin Marinas
2022-03-18 14:30 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjSXkyq6icIFx4GS@arm.com \
--to=catalin.marinas@arm.com \
--cc=Kuan-Ying.Lee@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=chinwen.chang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=nicholas.tang@mediatek.com \
--cc=yee.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.