Re: [RFC PATCH 07/16] debugfs: Add signed versions of debugfs_create_u32/64 helpers - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, sudeep.holla@arm.com,
	james.quinlan@broadcom.com, Jonathan.Cameron@huawei.com,
	f.fainelli@gmail.com, vincent.guittot@linaro.org,
	souvik.chakravarty@arm.com, peter.hilber@opensynergy.com,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [RFC PATCH 07/16] debugfs: Add signed versions of debugfs_create_u32/64 helpers
Date: Fri, 18 Mar 2022 16:49:59 +0100	[thread overview]
Message-ID: <YjSqJ7KgM1spnT31@kroah.com> (raw)
In-Reply-To: <YjSnvKV7dElpzTcd@e120937-lin>

On Fri, Mar 18, 2022 at 03:39:40PM +0000, Cristian Marussi wrote:
> On Fri, Mar 18, 2022 at 02:21:32PM +0100, Greg Kroah-Hartman wrote:
> > On Sun, Feb 27, 2022 at 08:55:59PM +0000, Cristian Marussi wrote:
> > > Add a few helpers to deal with signed values integers; built on existing
> > > debugfs internal helpers as the existing unsigned functions already do.
> > > 
> > > Make the simple_attr_write() internal helper detect the sign of the
> > > requested set operation from the related format string: this is needed
> > > to be able to properly parse negatively signed input strings.
> > > 
> > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > > Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> > > ---
> 
> Hi Greg,
> 
> thanks for the feedback.
> 
> > > Note that in the rest of the series I do NOT need the s64 WRITE/SET
> > > operations, that required the more invasive simple_attr_write() change,
> > > but it seemed odd to implement a get only debug_create_s32/64 API.
> > 
> > Let's wait to add them when we have a need for them with a in-kernel
> > user.  Otherwise I'll just end up removing them eventually when I sweep
> > for "is this used" cleanups.
> > 
> 
> Ok, so just to double check what I understood(or not), I'll leave out the
> setters ops and implement instead the debufs_create_s32/s64 with only RO
> fops support, right ?

Only create what you actually need.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel