All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH V2 5/5] openrisc: Move to ticket-spinlock
Date: Mon, 21 Mar 2022 06:13:16 +0900	[thread overview]
Message-ID: <YjeY7CfaFKjr8IUc@antec> (raw)
In-Reply-To: <CAAfxs74xtts3bzMGsVp9fOyxfZzj1vQPgrEsquXFa6AGAAC+_w@mail.gmail.com>

On Sun, Mar 20, 2022 at 12:36:31PM +0900, Stafford Horne wrote:
> On Sun, Mar 20, 2022, 12:05 PM Guo Ren <guoren@kernel.org> wrote:
> 
> > Hi openrisc guys,
> >
> > >    kernel/signal.c:2625:49: sparse:     expected struct sighand_struct
> > *sighand
> > >    kernel/signal.c:2625:49: sparse:     got struct sighand_struct
> > [noderef] __rcu *sighand
> >
> > Some warning here, Is that all right? I don't think it is because of
> > changing arch_spinlock_t from struct qspinlock to atomic_t.
> >
> 
> I haven't built or tested this series yet.  But this doesn't look like a
> new problem. It looks like this patch series may have introduced a new
> instance of the existing issue.
> 
> I have some patches to clean up sparse warnings and I've seen this pattern
> before but haven't spent the time to clean it up. This is a good
> opportunity to do that now.  Let me have a look in the next few days.

Hello Guo Ren,

I was able to build the patch series for OpenRISC, but after applying the
openrisc SMP kernel build no longer can boot.  It doesn't boot on single core
system or multi-core systems.  I don't get any console output to help with
debugging it.

It may take be a bit longer to debug this.

-Stafford

WARNING: multiple messages have this Message-ID (diff)
From: Stafford Horne <shorne@gmail.com>
To: Guo Ren <guoren@kernel.org>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	Jonas Bonn <jonas@southpole.se>,
	Openrisc <openrisc@lists.librecores.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 5/5] openrisc: Move to ticket-spinlock
Date: Mon, 21 Mar 2022 06:13:16 +0900	[thread overview]
Message-ID: <YjeY7CfaFKjr8IUc@antec> (raw)
In-Reply-To: <CAAfxs74xtts3bzMGsVp9fOyxfZzj1vQPgrEsquXFa6AGAAC+_w@mail.gmail.com>

On Sun, Mar 20, 2022 at 12:36:31PM +0900, Stafford Horne wrote:
> On Sun, Mar 20, 2022, 12:05 PM Guo Ren <guoren@kernel.org> wrote:
> 
> > Hi openrisc guys,
> >
> > >    kernel/signal.c:2625:49: sparse:     expected struct sighand_struct
> > *sighand
> > >    kernel/signal.c:2625:49: sparse:     got struct sighand_struct
> > [noderef] __rcu *sighand
> >
> > Some warning here, Is that all right? I don't think it is because of
> > changing arch_spinlock_t from struct qspinlock to atomic_t.
> >
> 
> I haven't built or tested this series yet.  But this doesn't look like a
> new problem. It looks like this patch series may have introduced a new
> instance of the existing issue.
> 
> I have some patches to clean up sparse warnings and I've seen this pattern
> before but haven't spent the time to clean it up. This is a good
> opportunity to do that now.  Let me have a look in the next few days.

Hello Guo Ren,

I was able to build the patch series for OpenRISC, but after applying the
openrisc SMP kernel build no longer can boot.  It doesn't boot on single core
system or multi-core systems.  I don't get any console output to help with
debugging it.

It may take be a bit longer to debug this.

-Stafford

  reply	other threads:[~2022-03-20 21:13 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-19  3:54 [PATCH V2 0/5] Generic Ticket Spinlocks guoren
2022-03-19  3:54 ` [OpenRISC] " guoren
2022-03-19  3:54 ` guoren
2022-03-19  3:54 ` [PATCH V2 1/5] asm-generic: ticket-lock: New generic ticket-based spinlock guoren
2022-03-19  3:54   ` [OpenRISC] " guoren
2022-03-19  3:54   ` guoren
2022-03-19 11:52   ` Arnd Bergmann
2022-03-19 11:52     ` [OpenRISC] " Arnd Bergmann
2022-03-19 11:52     ` Arnd Bergmann
2022-03-19 13:26     ` Guo Ren
2022-03-19 13:26       ` [OpenRISC] " Guo Ren
2022-03-19 13:26       ` Guo Ren
2022-03-22  3:10   ` [OpenRISC] " Stafford Horne
2022-03-22  3:10     ` Stafford Horne
2022-03-22  3:10     ` Stafford Horne
2022-03-22 15:54     ` Waiman Long
2022-03-22 15:54       ` Waiman Long
2022-03-22 15:54       ` Waiman Long
2022-03-22 21:06       ` Stafford Horne
2022-03-22 21:06         ` Stafford Horne
2022-03-22 21:06         ` Stafford Horne
2022-03-22 21:14         ` Waiman Long
2022-03-22 21:14           ` Waiman Long
2022-03-22 21:14           ` Waiman Long
2022-03-22 21:24           ` Stafford Horne
2022-03-22 21:24             ` Stafford Horne
2022-03-22 21:24             ` Stafford Horne
2022-03-19  3:54 ` [PATCH V2 2/5] asm-generic: qspinlock: Indicate the use of mixed-size atomics guoren
2022-03-19  3:54   ` [OpenRISC] " guoren
2022-03-19  3:54   ` guoren
2022-03-19  3:54 ` [PATCH V2 3/5] csky: Move to generic ticket-spinlock guoren
2022-03-19  3:54   ` [OpenRISC] " guoren
2022-03-19  3:54   ` guoren
2022-03-19  3:54 ` [PATCH V2 4/5] RISC-V: Move to ticket-spinlocks & RW locks guoren
2022-03-19  3:54   ` [OpenRISC] " guoren
2022-03-19  3:54   ` guoren
2022-03-19  3:54 ` [PATCH V2 5/5] openrisc: Move to ticket-spinlock guoren
2022-03-19  3:54   ` [OpenRISC] " guoren
2022-03-19  3:54   ` guoren
     [not found]   ` <202203200824.EQJTy8pW-lkp@intel.com>
2022-03-20  3:05     ` [OpenRISC] " Guo Ren
2022-03-20  3:36       ` Stafford Horne
2022-03-20 21:13         ` Stafford Horne [this message]
2022-03-20 21:13           ` Stafford Horne
2022-03-22  5:26       ` [OpenRISC] " Stafford Horne
2022-03-22  5:26         ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjeY7CfaFKjr8IUc@antec \
    --to=shorne@gmail.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.