From: Jarkko Sakkinen <jarkko@kernel.org>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org,
peterhuewe@gmx.de, jgg@ziepe.ca, nayna@linux.ibm.com,
stefanb@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
Date: Sun, 20 Mar 2022 23:21:48 +0200 [thread overview]
Message-ID: <Yjea7INzTZ2T9RWz@kernel.org> (raw)
In-Reply-To: <20220318060201.50488-1-xiujianfeng@huawei.com>
On Fri, Mar 18, 2022 at 02:02:01PM +0800, Xiu Jianfeng wrote:
> Currently it returns zero when CRQ response timed out, it should return
> an error code instead.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..d3989b257f42 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> + rc = -ENODEV;
> dev_err(dev, "CRQ response timed out\n");
> goto init_irq_cleanup;
> }
> --
> 2.17.1
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
This will require reviewed by from someone who knows this driver
better.
BR, Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Xiu Jianfeng <xiujianfeng@huawei.com>
Cc: nayna@linux.ibm.com, linux-kernel@vger.kernel.org, jgg@ziepe.ca,
paulus@samba.org, peterhuewe@gmx.de,
linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org,
stefanb@linux.ibm.com
Subject: Re: [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe()
Date: Sun, 20 Mar 2022 23:21:48 +0200 [thread overview]
Message-ID: <Yjea7INzTZ2T9RWz@kernel.org> (raw)
In-Reply-To: <20220318060201.50488-1-xiujianfeng@huawei.com>
On Fri, Mar 18, 2022 at 02:02:01PM +0800, Xiu Jianfeng wrote:
> Currently it returns zero when CRQ response timed out, it should return
> an error code instead.
>
> Fixes: d8d74ea3c002 ("tpm: ibmvtpm: Wait for buffer to be set before proceeding")
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
> ---
> drivers/char/tpm/tpm_ibmvtpm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..d3989b257f42 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -681,6 +681,7 @@ static int tpm_ibmvtpm_probe(struct vio_dev *vio_dev,
> if (!wait_event_timeout(ibmvtpm->crq_queue.wq,
> ibmvtpm->rtce_buf != NULL,
> HZ)) {
> + rc = -ENODEV;
> dev_err(dev, "CRQ response timed out\n");
> goto init_irq_cleanup;
> }
> --
> 2.17.1
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
This will require reviewed by from someone who knows this driver
better.
BR, Jarkko
next prev parent reply other threads:[~2022-03-20 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 6:02 [PATCH -next] tpm: ibmvtpm: Correct the return value in tpm_ibmvtpm_probe() Xiu Jianfeng
2022-03-18 6:02 ` Xiu Jianfeng
2022-03-18 13:54 ` Stefan Berger
2022-03-18 13:54 ` Stefan Berger
2022-03-20 21:23 ` Jarkko Sakkinen
2022-03-20 21:23 ` Jarkko Sakkinen
2022-03-20 21:21 ` Jarkko Sakkinen [this message]
2022-03-20 21:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjea7INzTZ2T9RWz@kernel.org \
--to=jarkko@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=paulus@samba.org \
--cc=peterhuewe@gmx.de \
--cc=stefanb@linux.ibm.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.