All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	"huziji@marvell.com" <huziji@marvell.com>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"kostap@marvell.com" <kostap@marvell.com>,
	"robert.marko@sartura.hr" <robert.marko@sartura.hr>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5
Date: Wed, 23 Mar 2022 13:34:22 -0500	[thread overview]
Message-ID: <YjtoLkeyYsT6Fih5@robh.at.kernel.org> (raw)
In-Reply-To: <Yi/dhK0NXg9g6J9T@lunn.ch>

On Tue, Mar 15, 2022 at 01:27:48AM +0100, Andrew Lunn wrote:
> > I think it can. I vaguely remember seeing conditional clauses based on 
> > compatible strings in other yaml bindings.
> > 
> > I started a new binding document because I expected adding significant 
> > additions to the existing .txt files would be rejected. If I get some 
> > cycles I could look at converting the existing docs from txt to yaml.
> > 
> > I'm not sure that there will be much in the way of a common 
> > mvebu-pinctrl.yaml as you'd end up repeating most of the common stuff to 
> > make things conditional anyway.
> 
> We should wait for Rob to comment. But is suspect you are right, there
> will not be much savings.

It's always a judgement call of amount of if/then schema vs. duplicating 
the common parts. If it's the function/pin parts that vary, then that's 
probably best as separate schema for each case. Otherwise, I'm not sure 
without seeing something.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chris Packham <Chris.Packham@alliedtelesis.co.nz>,
	 "huziji@marvell.com" <huziji@marvell.com>,
	"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
	 "davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	 "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	 "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	 "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
	 "sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>,
	 "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
	 "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"kostap@marvell.com" <kostap@marvell.com>,
	 "robert.marko@sartura.hr" <robert.marko@sartura.hr>,
	 "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	 "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	 "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	 "linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5
Date: Wed, 23 Mar 2022 13:34:22 -0500	[thread overview]
Message-ID: <YjtoLkeyYsT6Fih5@robh.at.kernel.org> (raw)
In-Reply-To: <Yi/dhK0NXg9g6J9T@lunn.ch>

On Tue, Mar 15, 2022 at 01:27:48AM +0100, Andrew Lunn wrote:
> > I think it can. I vaguely remember seeing conditional clauses based on 
> > compatible strings in other yaml bindings.
> > 
> > I started a new binding document because I expected adding significant 
> > additions to the existing .txt files would be rejected. If I get some 
> > cycles I could look at converting the existing docs from txt to yaml.
> > 
> > I'm not sure that there will be much in the way of a common 
> > mvebu-pinctrl.yaml as you'd end up repeating most of the common stuff to 
> > make things conditional anyway.
> 
> We should wait for Rob to comment. But is suspect you are right, there
> will not be much savings.

It's always a judgement call of amount of if/then schema vs. duplicating 
the common parts. If it's the function/pin parts that vary, then that's 
probably best as separate schema for each case. Otherwise, I'm not sure 
without seeing something.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-23 18:34 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 21:31 [PATCH v2 0/8] arm64: mvebu: Support for Marvell 98DX2530 (and variants) Chris Packham
2022-03-14 21:31 ` Chris Packham
2022-03-14 21:31 ` [PATCH v2 1/8] dt-bindings: pinctrl: mvebu: Document bindings for AC5 Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:07   ` Andrew Lunn
2022-03-15  0:07     ` Andrew Lunn
2022-03-15  0:22     ` Chris Packham
2022-03-15  0:22       ` Chris Packham
2022-03-15  0:27       ` Andrew Lunn
2022-03-15  0:27         ` Andrew Lunn
2022-03-23 18:34         ` Rob Herring [this message]
2022-03-23 18:34           ` Rob Herring
2022-03-15 10:46   ` Krzysztof Kozlowski
2022-03-15 10:46     ` Krzysztof Kozlowski
2022-03-15 21:12     ` Chris Packham
2022-03-15 21:12       ` Chris Packham
2022-03-16  8:16       ` Krzysztof Kozlowski
2022-03-16  8:16         ` Krzysztof Kozlowski
2022-03-16 20:21         ` Chris Packham
2022-03-16 20:21           ` Chris Packham
2022-03-17  7:26           ` Krzysztof Kozlowski
2022-03-17  7:26             ` Krzysztof Kozlowski
2022-03-17 14:14             ` Andrew Lunn
2022-03-17 14:14               ` Andrew Lunn
2022-03-17 15:16               ` Krzysztof Kozlowski
2022-03-17 15:16                 ` Krzysztof Kozlowski
2022-03-14 21:31 ` [PATCH v2 2/8] dt-bindings: net: mvneta: Add marvell,armada-ac5-neta Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:10   ` Andrew Lunn
2022-03-15  0:10     ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 3/8] dt-bindings: mmc: xenon: add AC5 compatible string Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:14   ` Andrew Lunn
2022-03-15  0:14     ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 4/8] pinctrl: mvebu: pinctrl driver for 98DX2530 SoC Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:16   ` Andrew Lunn
2022-03-15  0:16     ` Andrew Lunn
2022-03-15 10:49   ` Krzysztof Kozlowski
2022-03-15 10:49     ` Krzysztof Kozlowski
2022-03-15 14:33     ` Andrew Lunn
2022-03-15 14:33       ` Andrew Lunn
2022-03-15 14:39       ` Krzysztof Kozlowski
2022-03-15 14:39         ` Krzysztof Kozlowski
2022-03-14 21:31 ` [PATCH v2 5/8] net: mvneta: Add support for 98DX2530 Ethernet port Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:12   ` Andrew Lunn
2022-03-15  0:12     ` Andrew Lunn
2022-03-15  0:27     ` Chris Packham
2022-03-15  0:27       ` Chris Packham
2022-03-14 21:31 ` [PATCH v2 6/8] mmc: xenon: add AC5 compatible string Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:14   ` Andrew Lunn
2022-03-15  0:14     ` Andrew Lunn
2022-03-14 21:31 ` [PATCH v2 7/8] arm64: dts: marvell: Add Armada 98DX2530 SoC and RD-AC5X board Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:24   ` Andrew Lunn
2022-03-15  0:24     ` Andrew Lunn
2022-03-15  2:11     ` Chris Packham
2022-03-15  2:11       ` Chris Packham
2022-03-15 14:28       ` Andrew Lunn
2022-03-15 14:28         ` Andrew Lunn
2022-03-16 11:49   ` Marc Zyngier
2022-03-16 11:49     ` Marc Zyngier
2022-03-14 21:31 ` [PATCH v2 8/8] arm64: marvell: enable the 98DX2530 pinctrl driver Chris Packham
2022-03-14 21:31   ` Chris Packham
2022-03-15  0:25   ` Andrew Lunn
2022-03-15  0:25     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjtoLkeyYsT6Fih5@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Chris.Packham@alliedtelesis.co.nz \
    --cc=adrian.hunter@intel.com \
    --cc=andrew@lunn.ch \
    --cc=catalin.marinas@arm.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=huziji@marvell.com \
    --cc=kostap@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.