All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keerthy <j-keerthy@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] dt-bindings: timer: Update TI timer to yaml and add compatible for am6
Date: Fri, 8 Apr 2022 11:33:41 +0300	[thread overview]
Message-ID: <Yk/zZW+HKkEEc75C@atomide.com> (raw)
In-Reply-To: <20220408082757.3cnhvekpty4o4j2k@ladder>

* Nishanth Menon <nm@ti.com> [220408 08:25]:
> On 11:12-20220408, Tony Lindgren wrote:
> [...]
> 
> > +  ti,hwmods:
> > +    description:
> > +      Name of the HWMOD associated with timer. This is for legacy
> > +      omap2/3 platforms only.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    deprecated: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> 
> Should we strengthen the check like in 8250_omap.yaml - something to the
> effect of:
> 
> if:
>   properties:
>     compatible:
>       contains:
>         enum:
>           - ti,omap2420-timer
>           - ti,omap3430-timer
>           - ti,omap4430-timer
> 
> then:
>   properties:
>     ti,hwmods:
>       items:
>         - pattern: "^timer([1-9]+)$"
> 
> else:
>   properties:
>     ti,hwmods: false

Sure, sounds good to me. I need to check again what all SoCs are already
using ti-sysc for all the timers. I believe system timers only got updated
for some SoCs.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Keerthy <j-keerthy@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH] dt-bindings: timer: Update TI timer to yaml and add compatible for am6
Date: Fri, 8 Apr 2022 11:33:41 +0300	[thread overview]
Message-ID: <Yk/zZW+HKkEEc75C@atomide.com> (raw)
In-Reply-To: <20220408082757.3cnhvekpty4o4j2k@ladder>

* Nishanth Menon <nm@ti.com> [220408 08:25]:
> On 11:12-20220408, Tony Lindgren wrote:
> [...]
> 
> > +  ti,hwmods:
> > +    description:
> > +      Name of the HWMOD associated with timer. This is for legacy
> > +      omap2/3 platforms only.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    deprecated: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> 
> Should we strengthen the check like in 8250_omap.yaml - something to the
> effect of:
> 
> if:
>   properties:
>     compatible:
>       contains:
>         enum:
>           - ti,omap2420-timer
>           - ti,omap3430-timer
>           - ti,omap4430-timer
> 
> then:
>   properties:
>     ti,hwmods:
>       items:
>         - pattern: "^timer([1-9]+)$"
> 
> else:
>   properties:
>     ti,hwmods: false

Sure, sounds good to me. I need to check again what all SoCs are already
using ti-sysc for all the timers. I believe system timers only got updated
for some SoCs.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-08  8:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08  8:12 [PATCH] dt-bindings: timer: Update TI timer to yaml and add compatible for am6 Tony Lindgren
2022-04-08  8:12 ` Tony Lindgren
2022-04-08  8:27 ` Nishanth Menon
2022-04-08  8:27   ` Nishanth Menon
2022-04-08  8:33   ` Tony Lindgren [this message]
2022-04-08  8:33     ` Tony Lindgren
2022-04-08  8:34   ` Krzysztof Kozlowski
2022-04-08  8:34     ` Krzysztof Kozlowski
2022-04-08  8:32 ` Krzysztof Kozlowski
2022-04-08  8:32   ` Krzysztof Kozlowski
2022-04-08 10:07   ` Tony Lindgren
2022-04-08 10:07     ` Tony Lindgren
2022-04-08 15:41 ` Rob Herring
2022-04-08 15:41   ` Rob Herring
2022-04-11  8:00   ` Tony Lindgren
2022-04-11  8:00     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk/zZW+HKkEEc75C@atomide.com \
    --to=tony@atomide.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.