All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/i915/kms_big_fb: move start of crc calculation past first commit
@ 2022-04-06 19:11 Juha-Pekka Heikkila
  2022-04-06 19:20 ` Ville Syrjälä
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Juha-Pekka Heikkila @ 2022-04-06 19:11 UTC (permalink / raw)
  To: igt-dev

First commit may cause modeset which can on some machines take enough
time to fill up crc buffer causing crc buffer overflow messages. Moved
crc calcualtion start past first commit to avoid these messages.

I changed small fb not to be cleared with green color, this seem
to take portion of execution time away.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/i915/kms_big_fb.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 8724d6069..6c6d674cb 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -370,12 +370,12 @@ static bool test_plane(data_t *data)
 		 * rendering pipeline introduces slight differences into
 		 * the result if we try that, and so the crc will not match.
 		 */
-		igt_pipe_crc_start(data->pipe_crc);
 		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
 			     small_fb->width, small_fb->height);
 
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
+		igt_pipe_crc_start(data->pipe_crc);
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
@@ -420,9 +420,8 @@ static bool test_pipe(data_t *data)
 	if (igt_rotation_90_or_270(data->rotation))
 		igt_swap(width, height);
 
-	igt_create_color_fb(data->drm_fd, width, height,
-			    data->format, data->modifier,
-			    0, 1, 0, &data->small_fb);
+	igt_create_fb(data->drm_fd, width, height, data->format,
+		      data->modifier, &data->small_fb);
 
 	igt_output_set_pipe(data->output, data->pipe);
 
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-07  5:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-06 19:11 [igt-dev] [PATCH i-g-t] tests/i915/kms_big_fb: move start of crc calculation past first commit Juha-Pekka Heikkila
2022-04-06 19:20 ` Ville Syrjälä
2022-04-06 19:35   ` Juha-Pekka Heikkilä
2022-04-06 23:02 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-07  5:46 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.