All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions
Date: Thu, 7 Apr 2022 11:53:03 +0300	[thread overview]
Message-ID: <Yk6mb1HjEH4H/b7p@atomide.com> (raw)
In-Reply-To: <7f3cbdf3-401c-6c30-20fa-b5121bd3f63d@linaro.org>

* Daniel Lezcano <daniel.lezcano@linaro.org> [220407 08:23]:
> On 07/04/2022 10:15, Tony Lindgren wrote:
> > * Daniel Lezcano <daniel.lezcano@linaro.org> [220407 08:01]:
> > > On 07/04/2022 09:10, Tony Lindgren wrote:
> > > > @@ -251,7 +251,8 @@ int omap_dm_timers_active(void);
> > > >     * The below are inlined to optimize code size for system timers. Other code
> > > >     * should not need these at all.
> > > >     */
> > > > -#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS)
> > > > +#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) || \
> > > > +	defined(CONFIG_ARCH_K3)
> > > 
> > > Why not replace the above by CONFIG_OMAP_DM_TIMER ?
> > 
> > Hmm that's a good question for why it was not that way earlier.
> > 
> > This series changes things for tristate "OMAP dual-mode timer driver" if
> > ARCH_K3 || COMPILE_TEST though. So the inline stubs are still needed for
> > COMPILE_TEST it seems.
> 
> But if ARCH_K3 or COMPILE_TEST is set, CONFIG_DM_TIMER is also set, no?

Right but I suspect that COMPILE_TEST will produce a build error on other
architectures. I need to check that though, maybe that is no longer the
case.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, Keerthy <j-keerthy@ti.com>,
	Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions
Date: Thu, 7 Apr 2022 11:53:03 +0300	[thread overview]
Message-ID: <Yk6mb1HjEH4H/b7p@atomide.com> (raw)
In-Reply-To: <7f3cbdf3-401c-6c30-20fa-b5121bd3f63d@linaro.org>

* Daniel Lezcano <daniel.lezcano@linaro.org> [220407 08:23]:
> On 07/04/2022 10:15, Tony Lindgren wrote:
> > * Daniel Lezcano <daniel.lezcano@linaro.org> [220407 08:01]:
> > > On 07/04/2022 09:10, Tony Lindgren wrote:
> > > > @@ -251,7 +251,8 @@ int omap_dm_timers_active(void);
> > > >     * The below are inlined to optimize code size for system timers. Other code
> > > >     * should not need these at all.
> > > >     */
> > > > -#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS)
> > > > +#if defined(CONFIG_ARCH_OMAP1) || defined(CONFIG_ARCH_OMAP2PLUS) || \
> > > > +	defined(CONFIG_ARCH_K3)
> > > 
> > > Why not replace the above by CONFIG_OMAP_DM_TIMER ?
> > 
> > Hmm that's a good question for why it was not that way earlier.
> > 
> > This series changes things for tristate "OMAP dual-mode timer driver" if
> > ARCH_K3 || COMPILE_TEST though. So the inline stubs are still needed for
> > COMPILE_TEST it seems.
> 
> But if ARCH_K3 or COMPILE_TEST is set, CONFIG_DM_TIMER is also set, no?

Right but I suspect that COMPILE_TEST will produce a build error on other
architectures. I need to check that though, maybe that is no longer the
case.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-07  8:53 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07  7:10 [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer Tony Lindgren
2022-04-07  7:10 ` Tony Lindgren
2022-04-07  7:10 ` [PATCH 2/4] clocksource/drivers/timer-ti-dm: Update defines for am6 for inline functions Tony Lindgren
2022-04-07  7:10   ` Tony Lindgren
2022-04-07  8:04   ` Daniel Lezcano
2022-04-07  8:04     ` Daniel Lezcano
2022-04-07  8:15     ` Tony Lindgren
2022-04-07  8:15       ` Tony Lindgren
2022-04-07  8:26       ` Daniel Lezcano
2022-04-07  8:26         ` Daniel Lezcano
2022-04-07  8:53         ` Tony Lindgren [this message]
2022-04-07  8:53           ` Tony Lindgren
2022-04-07 10:26           ` Tony Lindgren
2022-04-07 10:26             ` Tony Lindgren
2022-04-07 11:48             ` Daniel Lezcano
2022-04-07 11:48               ` Daniel Lezcano
2022-04-07  7:10 ` [PATCH 3/4] clocksource/drivers/timer-ti-dm: Add compatible for am6 Tony Lindgren
2022-04-07  7:10   ` Tony Lindgren
2022-04-07  7:10 ` [PATCH 4/4] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3 Tony Lindgren
2022-04-07  7:10   ` Tony Lindgren
2022-04-07  7:56 ` [PATCH 1/4] dt-bindings: timer: Add am6 compatible for ti-timer Krzysztof Kozlowski
2022-04-07  7:56   ` Krzysztof Kozlowski
2022-04-07 13:31 ` Nishanth Menon
2022-04-07 13:31   ` Nishanth Menon
2022-04-08  4:28   ` Tony Lindgren
2022-04-08  4:28     ` Tony Lindgren
2022-04-07 13:33 ` Nishanth Menon
2022-04-07 13:33   ` Nishanth Menon
2022-04-08  4:38   ` Tony Lindgren
2022-04-08  4:38     ` Tony Lindgren
2022-04-08  7:34     ` Nishanth Menon
2022-04-08  7:34       ` Nishanth Menon
2022-04-08  7:43       ` Tony Lindgren
2022-04-08  7:43         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk6mb1HjEH4H/b7p@atomide.com \
    --to=tony@atomide.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.