From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>,
Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC 2/2] btrfs: do data read repair in synchronous mode
Date: Mon, 28 Mar 2022 23:16:56 -0700 [thread overview]
Message-ID: <YkKkWBZ90mLnMM0V@infradead.org> (raw)
In-Reply-To: <84178851-8c88-dea1-1d0e-844b6ba7bb7c@gmx.com>
On Sat, Mar 26, 2022 at 08:13:33AM +0800, Qu Wenruo wrote:
> > I'm not understanding the reason why each bvec can only have one page...
> > as far as I know, a bvec could have any number of contiguous pages,
> > making it infeasible for x86_64 too, but maybe I'm missing some
> > constraint in their construction to make it one-to-one.
>
> Btrfs doesn't utilize that multi-page bvec at all.
That is not true. multi-page bvec are automatically created by
bio_add_page which is used by btrfs everywhere.
next prev parent reply other threads:[~2022-03-29 6:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 9:42 [PATCH RFC 0/2] btrfs: make read repair work in synchronous mode Qu Wenruo
2022-03-25 9:42 ` [PATCH RFC 1/2] btrfs: introduce a pure data checksum checking helper Qu Wenruo
2022-03-25 10:14 ` Johannes Thumshirn
2022-03-25 9:42 ` [PATCH RFC 2/2] btrfs: do data read repair in synchronous mode Qu Wenruo
2022-03-25 10:27 ` Christoph Hellwig
2022-03-25 10:53 ` Qu Wenruo
2022-03-25 14:58 ` Sweet Tea Dorminy
2022-03-26 0:13 ` Qu Wenruo
2022-03-26 1:10 ` Qu Wenruo
2022-03-29 6:17 ` Christoph Hellwig
2022-03-29 6:16 ` Christoph Hellwig [this message]
2022-03-25 16:43 ` Christoph Hellwig
2022-03-26 0:12 ` Qu Wenruo
2022-04-19 19:19 ` [PATCH RFC 0/2] btrfs: make read repair work " David Sterba
2022-04-19 23:22 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkKkWBZ90mLnMM0V@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=sweettea-kernel@dorminy.me \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.