All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH RFC 0/2] btrfs: make read repair work in synchronous mode
Date: Fri, 25 Mar 2022 17:42:47 +0800	[thread overview]
Message-ID: <cover.1648201268.git.wqu@suse.com> (raw)

The first patch is just a preparation for the 2nd patch, which is also
the core.

It will make repair_one_sector() to wait for the read from other copies
finish, before returning.

This will make the code easier to read, but huge drop in concurrency and
performance for read-repair.

My only justification is read-repair should be a cold path, and we may
be able to afford the change.

Qu Wenruo (2):
  btrfs: introduce a pure data checksum checking helper
  btrfs: do data read repair in synchronous mode

 fs/btrfs/ctree.h     |   2 +
 fs/btrfs/extent_io.c | 111 ++++++++++++++++++++++++++++++-------------
 fs/btrfs/extent_io.h |   3 +-
 fs/btrfs/inode.c     |  73 ++++++++++++++--------------
 4 files changed, 120 insertions(+), 69 deletions(-)

-- 
2.35.1


             reply	other threads:[~2022-03-25  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-25  9:42 Qu Wenruo [this message]
2022-03-25  9:42 ` [PATCH RFC 1/2] btrfs: introduce a pure data checksum checking helper Qu Wenruo
2022-03-25 10:14   ` Johannes Thumshirn
2022-03-25  9:42 ` [PATCH RFC 2/2] btrfs: do data read repair in synchronous mode Qu Wenruo
2022-03-25 10:27   ` Christoph Hellwig
2022-03-25 10:53     ` Qu Wenruo
2022-03-25 14:58       ` Sweet Tea Dorminy
2022-03-26  0:13         ` Qu Wenruo
2022-03-26  1:10           ` Qu Wenruo
2022-03-29  6:17             ` Christoph Hellwig
2022-03-29  6:16           ` Christoph Hellwig
2022-03-25 16:43       ` Christoph Hellwig
2022-03-26  0:12         ` Qu Wenruo
2022-04-19 19:19 ` [PATCH RFC 0/2] btrfs: make read repair work " David Sterba
2022-04-19 23:22   ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1648201268.git.wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.