From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Wei Yang <richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH 2/3] mm/memcg: set pos to prev unconditionally
Date: Wed, 30 Mar 2022 08:08:49 -0400 [thread overview]
Message-ID: <YkRIUbEGHVIbVRNO@cmpxchg.org> (raw)
In-Reply-To: <20220330004750.fx4jr4bnehz4ynpf@master>
On Wed, Mar 30, 2022 at 12:47:50AM +0000, Wei Yang wrote:
> Something like this?
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index eed9916cdce5..5d433b79ba47 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1005,9 +1005,6 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> if (!root)
> root = root_mem_cgroup;
>
> - if (prev && !reclaim)
> - pos = prev;
> -
> rcu_read_lock();
>
> if (reclaim) {
> @@ -1033,6 +1030,8 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> */
> (void)cmpxchg(&iter->position, pos, NULL);
> }
> + } else if (prev) {
> + pos = prev;
> }
>
> if (pos)
Yep!
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/3] mm/memcg: set pos to prev unconditionally
Date: Wed, 30 Mar 2022 08:08:49 -0400 [thread overview]
Message-ID: <YkRIUbEGHVIbVRNO@cmpxchg.org> (raw)
In-Reply-To: <20220330004750.fx4jr4bnehz4ynpf@master>
On Wed, Mar 30, 2022 at 12:47:50AM +0000, Wei Yang wrote:
> Something like this?
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index eed9916cdce5..5d433b79ba47 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -1005,9 +1005,6 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> if (!root)
> root = root_mem_cgroup;
>
> - if (prev && !reclaim)
> - pos = prev;
> -
> rcu_read_lock();
>
> if (reclaim) {
> @@ -1033,6 +1030,8 @@ struct mem_cgroup *mem_cgroup_iter(struct mem_cgroup *root,
> */
> (void)cmpxchg(&iter->position, pos, NULL);
> }
> + } else if (prev) {
> + pos = prev;
> }
>
> if (pos)
Yep!
next prev parent reply other threads:[~2022-03-30 12:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-25 0:34 [PATCH 0/3] mm/memcg: some cleanup for mem_cgroup_iter() Wei Yang
2022-02-25 0:34 ` Wei Yang
[not found] ` <20220225003437.12620-1-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-02-25 0:34 ` [PATCH 1/3] mm/memcg: set memcg after css verified and got reference Wei Yang
2022-02-25 0:34 ` Wei Yang
[not found] ` <20220225003437.12620-2-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-03-29 18:44 ` Johannes Weiner
2022-03-29 18:44 ` Johannes Weiner
2022-02-25 0:34 ` [PATCH 2/3] mm/memcg: set pos to prev unconditionally Wei Yang
2022-02-25 0:34 ` Wei Yang
[not found] ` <20220225003437.12620-3-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-03-29 18:48 ` Johannes Weiner
2022-03-29 18:48 ` Johannes Weiner
[not found] ` <YkNUZYrSHPjJ1XOb-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-03-30 0:47 ` Wei Yang
2022-03-30 0:47 ` Wei Yang
2022-03-30 12:08 ` Johannes Weiner [this message]
2022-03-30 12:08 ` Johannes Weiner
[not found] ` <YkRIUbEGHVIbVRNO-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-03-30 14:22 ` Wei Yang
2022-03-30 14:22 ` Wei Yang
2022-02-25 0:34 ` [PATCH 3/3] mm/memcg: move generation assignment and comparison together Wei Yang
2022-02-25 0:34 ` Wei Yang
[not found] ` <20220225003437.12620-4-richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2022-03-30 15:57 ` Johannes Weiner
2022-03-30 15:57 ` Johannes Weiner
[not found] ` <YkR902CHgavwleet-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2022-03-30 23:04 ` Wei Yang
2022-03-30 23:04 ` Wei Yang
2022-02-25 8:13 ` [PATCH 0/3] mm/memcg: some cleanup for mem_cgroup_iter() Michal Hocko
2022-02-25 8:13 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkRIUbEGHVIbVRNO@cmpxchg.org \
--to=hannes-druugvl0lcnafugrpc6u6w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.