All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: Fix regression for smc calls for vmap stack
Date: Thu, 31 Mar 2022 19:30:26 +0300	[thread overview]
Message-ID: <YkXXImoeFDpV+w+y@atomide.com> (raw)
In-Reply-To: <CAK8P3a2-ik1e+DZV5g9hera8qzpBOURPLrPHPst3UKhwLKEOMg@mail.gmail.com>

* Arnd Bergmann <arnd@arndb.de> [220331 15:25]:
> On Thu, Mar 31, 2022 at 4:42 PM Tony Lindgren <tony@atomide.com> wrote:
> > diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
> > --- a/arch/arm/mach-omap2/omap-secure.c
> > +++ b/arch/arm/mach-omap2/omap-secure.c
> > @@ -59,8 +59,8 @@ static void __init omap_optee_init_check(void)
> >  u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2,
> >                                                          u32 arg3, u32 arg4)
> >  {
> > +       static u32 param[5];
> >         u32 ret;
> > -       u32 param[5];
> 
> I think for this one, you do need to use a DEFINE_PER_CPU() to make it
> work when multiple cores run into the function concurrently. This is entered
> on OMAP44xx from irq_notifier() with cmd==CPU_CLUSTER_PM_ENTER
> and from start_secondary(). I suspect that one can show these never happen
> on more than one CPU at a time, but I have not been able to prove that
> myself.

Yeah makes sense. Will post v2.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] ARM: OMAP2+: Fix regression for smc calls for vmap stack
Date: Thu, 31 Mar 2022 19:30:26 +0300	[thread overview]
Message-ID: <YkXXImoeFDpV+w+y@atomide.com> (raw)
In-Reply-To: <CAK8P3a2-ik1e+DZV5g9hera8qzpBOURPLrPHPst3UKhwLKEOMg@mail.gmail.com>

* Arnd Bergmann <arnd@arndb.de> [220331 15:25]:
> On Thu, Mar 31, 2022 at 4:42 PM Tony Lindgren <tony@atomide.com> wrote:
> > diff --git a/arch/arm/mach-omap2/omap-secure.c b/arch/arm/mach-omap2/omap-secure.c
> > --- a/arch/arm/mach-omap2/omap-secure.c
> > +++ b/arch/arm/mach-omap2/omap-secure.c
> > @@ -59,8 +59,8 @@ static void __init omap_optee_init_check(void)
> >  u32 omap_secure_dispatcher(u32 idx, u32 flag, u32 nargs, u32 arg1, u32 arg2,
> >                                                          u32 arg3, u32 arg4)
> >  {
> > +       static u32 param[5];
> >         u32 ret;
> > -       u32 param[5];
> 
> I think for this one, you do need to use a DEFINE_PER_CPU() to make it
> work when multiple cores run into the function concurrently. This is entered
> on OMAP44xx from irq_notifier() with cmd==CPU_CLUSTER_PM_ENTER
> and from start_secondary(). I suspect that one can show these never happen
> on more than one CPU at a time, but I have not been able to prove that
> myself.

Yeah makes sense. Will post v2.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-31 16:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31 14:42 [PATCH] ARM: OMAP2+: Fix regression for smc calls for vmap stack Tony Lindgren
2022-03-31 14:42 ` Tony Lindgren
2022-03-31 15:26 ` Arnd Bergmann
2022-03-31 15:26   ` Arnd Bergmann
2022-03-31 16:30   ` Tony Lindgren [this message]
2022-03-31 16:30     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YkXXImoeFDpV+w+y@atomide.com \
    --to=tony@atomide.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.