From: Jarkko Sakkinen <jarkko@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-integrity@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] char: tpm: Prepare cleanup of powerpc's asm/prom.h
Date: Sun, 3 Apr 2022 13:23:05 +0300 [thread overview]
Message-ID: <Ykl1ibvVxJUBrhfK@kernel.org> (raw)
In-Reply-To: <cfd3a718e147b39620dfa7c779a7ae1af2f6b575.1648895074.git.christophe.leroy@csgroup.eu>
On Sat, Apr 02, 2022 at 12:29:19PM +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I don't understand this. It changes nothing as far as kernel is concerned.
> ---
> drivers/char/tpm/tpm_atmel.h | 2 --
> drivers/char/tpm/tpm_ibmvtpm.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
> index ba37e77e8af3..959f7cce8301 100644
> --- a/drivers/char/tpm/tpm_atmel.h
> +++ b/drivers/char/tpm/tpm_atmel.h
> @@ -26,8 +26,6 @@ struct tpm_atmel_priv {
>
> #ifdef CONFIG_PPC64
>
> -#include <asm/prom.h>
> -
> #define atmel_getb(priv, offset) readb(priv->iobase + offset)
> #define atmel_putb(val, priv, offset) writeb(val, priv->iobase + offset)
> #define atmel_request_region request_mem_region
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..1180cce7067a 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -20,7 +20,6 @@
> #include <linux/spinlock.h>
> #include <linux/interrupt.h>
> #include <linux/wait.h>
> -#include <asm/prom.h>
>
> #include "tpm.h"
> #include "tpm_ibmvtpm.h"
> --
> 2.35.1
>
BR, Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
linuxppc-dev@lists.ozlabs.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] char: tpm: Prepare cleanup of powerpc's asm/prom.h
Date: Sun, 3 Apr 2022 13:23:05 +0300 [thread overview]
Message-ID: <Ykl1ibvVxJUBrhfK@kernel.org> (raw)
In-Reply-To: <cfd3a718e147b39620dfa7c779a7ae1af2f6b575.1648895074.git.christophe.leroy@csgroup.eu>
On Sat, Apr 02, 2022 at 12:29:19PM +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I don't understand this. It changes nothing as far as kernel is concerned.
> ---
> drivers/char/tpm/tpm_atmel.h | 2 --
> drivers/char/tpm/tpm_ibmvtpm.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
> index ba37e77e8af3..959f7cce8301 100644
> --- a/drivers/char/tpm/tpm_atmel.h
> +++ b/drivers/char/tpm/tpm_atmel.h
> @@ -26,8 +26,6 @@ struct tpm_atmel_priv {
>
> #ifdef CONFIG_PPC64
>
> -#include <asm/prom.h>
> -
> #define atmel_getb(priv, offset) readb(priv->iobase + offset)
> #define atmel_putb(val, priv, offset) writeb(val, priv->iobase + offset)
> #define atmel_request_region request_mem_region
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..1180cce7067a 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -20,7 +20,6 @@
> #include <linux/spinlock.h>
> #include <linux/interrupt.h>
> #include <linux/wait.h>
> -#include <asm/prom.h>
>
> #include "tpm.h"
> #include "tpm_ibmvtpm.h"
> --
> 2.35.1
>
BR, Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko@kernel.org>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
linuxppc-dev@lists.ozlabs.org,
Claudiu Beznea <claudiu.beznea@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] char: tpm: Prepare cleanup of powerpc's asm/prom.h
Date: Sun, 3 Apr 2022 13:23:05 +0300 [thread overview]
Message-ID: <Ykl1ibvVxJUBrhfK@kernel.org> (raw)
In-Reply-To: <cfd3a718e147b39620dfa7c779a7ae1af2f6b575.1648895074.git.christophe.leroy@csgroup.eu>
On Sat, Apr 02, 2022 at 12:29:19PM +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
>
> In order to clean it up, first add missing headers in
> users of asm/prom.h
>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
I don't understand this. It changes nothing as far as kernel is concerned.
> ---
> drivers/char/tpm/tpm_atmel.h | 2 --
> drivers/char/tpm/tpm_ibmvtpm.c | 1 -
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_atmel.h b/drivers/char/tpm/tpm_atmel.h
> index ba37e77e8af3..959f7cce8301 100644
> --- a/drivers/char/tpm/tpm_atmel.h
> +++ b/drivers/char/tpm/tpm_atmel.h
> @@ -26,8 +26,6 @@ struct tpm_atmel_priv {
>
> #ifdef CONFIG_PPC64
>
> -#include <asm/prom.h>
> -
> #define atmel_getb(priv, offset) readb(priv->iobase + offset)
> #define atmel_putb(val, priv, offset) writeb(val, priv->iobase + offset)
> #define atmel_request_region request_mem_region
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index 3af4c07a9342..1180cce7067a 100644
> --- a/drivers/char/tpm/tpm_ibmvtpm.c
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -20,7 +20,6 @@
> #include <linux/spinlock.h>
> #include <linux/interrupt.h>
> #include <linux/wait.h>
> -#include <asm/prom.h>
>
> #include "tpm.h"
> #include "tpm_ibmvtpm.h"
> --
> 2.35.1
>
BR, Jarkko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-03 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-02 10:29 [PATCH] char: agp: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
2022-04-02 10:29 ` Christophe Leroy
2022-04-02 10:29 ` [PATCH] char: tpm: " Christophe Leroy
2022-04-02 10:29 ` Christophe Leroy
2022-04-02 10:29 ` Christophe Leroy
2022-04-03 10:23 ` Jarkko Sakkinen [this message]
2022-04-03 10:23 ` Jarkko Sakkinen
2022-04-03 10:23 ` Jarkko Sakkinen
2022-04-15 8:44 ` Christophe Leroy
2022-04-15 8:44 ` Christophe Leroy
2022-04-15 8:44 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ykl1ibvVxJUBrhfK@kernel.org \
--to=jarkko@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.ferre@microchip.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.