All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: 常凤楠 <changfengnan@vivo.com>
Cc: "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"chao@kernel.org" <chao@kernel.org>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
	"axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt
Date: Mon, 18 Apr 2022 20:18:50 -0700	[thread overview]
Message-ID: <Yl4qGkrfMT7FqbJj@sol.localdomain> (raw)
In-Reply-To: <KL1PR0601MB4003A659B51814320E156C35BBF29@KL1PR0601MB4003.apcprd06.prod.outlook.com>

On Tue, Apr 19, 2022 at 03:14:51AM +0000, 常凤楠 wrote:
> 
> Thanks for your explanation, this patchset has too many case to forget to handle...
> Back to my first thought, maybe there should have one sysfs node to indicate the 
> device support inlinecrypt or not ? So user can know it's device not support inlinecrypt
> and not for other reasons.
> 

Linux v5.18 has that.  See https://git.kernel.org/linus/20f01f1632036660
("blk-crypto: show crypto capabilities in sysfs").

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: 常凤楠 <changfengnan@vivo.com>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"tytso@mit.edu" <tytso@mit.edu>,
	"linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
	"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [f2fs-dev] [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt
Date: Mon, 18 Apr 2022 20:18:50 -0700	[thread overview]
Message-ID: <Yl4qGkrfMT7FqbJj@sol.localdomain> (raw)
In-Reply-To: <KL1PR0601MB4003A659B51814320E156C35BBF29@KL1PR0601MB4003.apcprd06.prod.outlook.com>

On Tue, Apr 19, 2022 at 03:14:51AM +0000, 常凤楠 wrote:
> 
> Thanks for your explanation, this patchset has too many case to forget to handle...
> Back to my first thought, maybe there should have one sysfs node to indicate the 
> device support inlinecrypt or not ? So user can know it's device not support inlinecrypt
> and not for other reasons.
> 

Linux v5.18 has that.  See https://git.kernel.org/linus/20f01f1632036660
("blk-crypto: show crypto capabilities in sysfs").

- Eric


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2022-04-19  3:18 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-18  6:33 [PATCH 1/3] blk-crypto: introduce blk_crypto_supported Fengnan Chang
2022-04-18  6:33 ` [f2fs-dev] " Fengnan Chang via Linux-f2fs-devel
2022-04-18  6:33 ` [PATCH 2/3] f2fs: notify when device not supprt inlinecrypt Fengnan Chang
2022-04-18  6:33   ` [f2fs-dev] " Fengnan Chang via Linux-f2fs-devel
2022-04-18  7:22   ` Eric Biggers
2022-04-18  7:22     ` [f2fs-dev] " Eric Biggers
2022-04-18  7:34     ` 常凤楠
2022-04-18  7:34       ` [f2fs-dev] " 常凤楠 via Linux-f2fs-devel
2022-04-18 22:27       ` Eric Biggers
2022-04-18 22:27         ` [f2fs-dev] " Eric Biggers
2022-04-18 22:43         ` Theodore Ts'o
2022-04-18 22:43           ` [f2fs-dev] " Theodore Ts'o
2022-04-19  3:14         ` 常凤楠
2022-04-19  3:14           ` [f2fs-dev] " 常凤楠 via Linux-f2fs-devel
2022-04-19  3:18           ` Eric Biggers [this message]
2022-04-19  3:18             ` Eric Biggers
2022-04-19  3:22             ` 常凤楠
2022-04-19  3:22               ` [f2fs-dev] " 常凤楠 via Linux-f2fs-devel
2022-04-18  6:33 ` [PATCH 3/3] ext4: " Fengnan Chang
2022-04-18  6:33   ` [f2fs-dev] " Fengnan Chang via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yl4qGkrfMT7FqbJj@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=axboe@kernel.dk \
    --cc=changfengnan@vivo.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.