From: Christoph Hellwig <hch@infradead.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
"jon@solid-run.com" <jon@solid-run.com>,
Linuxarm <linuxarm@huawei.com>,
"steven.price@arm.com" <steven.price@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>,
yangyicong <yangyicong@huawei.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
"will@kernel.org" <will@kernel.org>,
wanghuiqiang <wanghuiqiang@huawei.com>
Subject: Re: [PATCH v9 06/11] ACPI/IORT: Add support to retrieve IORT RMR reserved regions
Date: Tue, 19 Apr 2022 02:04:46 -0700 [thread overview]
Message-ID: <Yl57LuiR0JC4AZrw@infradead.org> (raw)
In-Reply-To: <955601f02f3b474da3327963fb1630f0@huawei.com>
On Tue, Apr 19, 2022 at 08:31:55AM +0000, Shameerali Kolothum Thodi via iommu wrote:
> Sorry for the delayed response(was on holidays). So if we move the
> iommu_dma_put_resv_region() call to generic_iommu_put_resv_regions() ,
> will that address the concerns here?
>
> I think it will resolve the issue in 05/11 as well pointed out by Christoph
> where we end up not releasing reserved regions when
> CONFIG_IOMMU_DMA is not set.
As Robin pointed out we might not really deduct that ACPI means RMR.
I suspect the best would be to just attach a free callback to the
regions. Either by adding it directly to struct iommu_resv_region
if we thing there are few enough regions to not be worried about
the memory use, or other by adding a container struct for the list_head
that contains the free callback.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: "will@kernel.org" <will@kernel.org>,
"jon@solid-run.com" <jon@solid-run.com>,
Linuxarm <linuxarm@huawei.com>,
"steven.price@arm.com" <steven.price@arm.com>,
Christoph Hellwig <hch@infradead.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
wanghuiqiang <wanghuiqiang@huawei.com>,
"Guohanjun \(Hanjun Guo\)" <guohanjun@huawei.com>,
yangyicong <yangyicong@huawei.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v9 06/11] ACPI/IORT: Add support to retrieve IORT RMR reserved regions
Date: Tue, 19 Apr 2022 02:04:46 -0700 [thread overview]
Message-ID: <Yl57LuiR0JC4AZrw@infradead.org> (raw)
In-Reply-To: <955601f02f3b474da3327963fb1630f0@huawei.com>
On Tue, Apr 19, 2022 at 08:31:55AM +0000, Shameerali Kolothum Thodi via iommu wrote:
> Sorry for the delayed response(was on holidays). So if we move the
> iommu_dma_put_resv_region() call to generic_iommu_put_resv_regions() ,
> will that address the concerns here?
>
> I think it will resolve the issue in 05/11 as well pointed out by Christoph
> where we end up not releasing reserved regions when
> CONFIG_IOMMU_DMA is not set.
As Robin pointed out we might not really deduct that ACPI means RMR.
I suspect the best would be to just attach a free callback to the
regions. Either by adding it directly to struct iommu_resv_region
if we thing there are few enough regions to not be worried about
the memory use, or other by adding a container struct for the list_head
that contains the free callback.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Robin Murphy <robin.murphy@arm.com>,
"jon@solid-run.com" <jon@solid-run.com>,
Linuxarm <linuxarm@huawei.com>,
"steven.price@arm.com" <steven.price@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Guohanjun (Hanjun Guo)" <guohanjun@huawei.com>,
yangyicong <yangyicong@huawei.com>,
"Sami.Mujawar@arm.com" <Sami.Mujawar@arm.com>,
"will@kernel.org" <will@kernel.org>,
wanghuiqiang <wanghuiqiang@huawei.com>
Subject: Re: [PATCH v9 06/11] ACPI/IORT: Add support to retrieve IORT RMR reserved regions
Date: Tue, 19 Apr 2022 02:04:46 -0700 [thread overview]
Message-ID: <Yl57LuiR0JC4AZrw@infradead.org> (raw)
In-Reply-To: <955601f02f3b474da3327963fb1630f0@huawei.com>
On Tue, Apr 19, 2022 at 08:31:55AM +0000, Shameerali Kolothum Thodi via iommu wrote:
> Sorry for the delayed response(was on holidays). So if we move the
> iommu_dma_put_resv_region() call to generic_iommu_put_resv_regions() ,
> will that address the concerns here?
>
> I think it will resolve the issue in 05/11 as well pointed out by Christoph
> where we end up not releasing reserved regions when
> CONFIG_IOMMU_DMA is not set.
As Robin pointed out we might not really deduct that ACPI means RMR.
I suspect the best would be to just attach a free callback to the
regions. Either by adding it directly to struct iommu_resv_region
if we thing there are few enough regions to not be worried about
the memory use, or other by adding a container struct for the list_head
that contains the free callback.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-19 9:04 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 12:41 [PATCH v9 00/11] ACPI/IORT: Support for IORT RMR node Shameer Kolothum
2022-04-04 12:41 ` Shameer Kolothum
2022-04-04 12:41 ` Shameer Kolothum via iommu
2022-04-04 12:41 ` [PATCH v9 01/11] ACPI/IORT: Add temporary RMR node flag definitions Shameer Kolothum
2022-04-04 12:41 ` Shameer Kolothum
2022-04-04 12:41 ` Shameer Kolothum via iommu
2022-04-06 15:53 ` Lorenzo Pieralisi
2022-04-06 15:53 ` Lorenzo Pieralisi
2022-04-06 15:53 ` Lorenzo Pieralisi
2022-04-04 12:42 ` [PATCH v9 02/11] iommu: Introduce a union to struct iommu_resv_region Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-04 12:42 ` [PATCH v9 03/11] ACPI/IORT: Make iort_iommu_msi_get_resv_regions() return void Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-06 15:12 ` Lorenzo Pieralisi
2022-04-06 15:12 ` Lorenzo Pieralisi
2022-04-06 15:12 ` Lorenzo Pieralisi
2022-04-04 12:42 ` [PATCH v9 04/11] ACPI/IORT: Provide a generic helper to retrieve reserve regions Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-06 15:54 ` Lorenzo Pieralisi
2022-04-06 15:54 ` Lorenzo Pieralisi
2022-04-06 15:54 ` Lorenzo Pieralisi
2022-04-04 12:42 ` [PATCH v9 05/11] iommu/dma: Introduce a helper to remove reserved regions Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-07 13:26 ` Christoph Hellwig
2022-04-07 13:26 ` Christoph Hellwig
2022-04-07 13:26 ` Christoph Hellwig
2022-04-04 12:42 ` [PATCH v9 06/11] ACPI/IORT: Add support to retrieve IORT RMR " Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-06 15:47 ` Lorenzo Pieralisi
2022-04-06 15:47 ` Lorenzo Pieralisi
2022-04-06 15:47 ` Lorenzo Pieralisi
2022-04-07 13:28 ` Christoph Hellwig
2022-04-07 13:28 ` Christoph Hellwig
2022-04-07 13:28 ` Christoph Hellwig
2022-04-07 13:53 ` Robin Murphy
2022-04-07 13:53 ` Robin Murphy
2022-04-07 13:53 ` Robin Murphy
2022-04-07 13:59 ` Christoph Hellwig
2022-04-07 13:59 ` Christoph Hellwig
2022-04-07 13:59 ` Christoph Hellwig
2022-04-19 8:31 ` Shameerali Kolothum Thodi
2022-04-19 8:31 ` Shameerali Kolothum Thodi
2022-04-19 8:31 ` Shameerali Kolothum Thodi via iommu
2022-04-19 9:04 ` Christoph Hellwig [this message]
2022-04-19 9:04 ` Christoph Hellwig
2022-04-19 9:04 ` Christoph Hellwig
2022-04-04 12:42 ` [PATCH v9 07/11] ACPI/IORT: Add a helper to retrieve RMR info directly Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-06 15:51 ` Lorenzo Pieralisi
2022-04-06 15:51 ` Lorenzo Pieralisi
2022-04-06 15:51 ` Lorenzo Pieralisi
2022-04-04 12:42 ` [PATCH v9 08/11] iommu/arm-smmu-v3: Introduce strtab init helper Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-04 12:42 ` [PATCH v9 09/11] iommu/arm-smmu-v3: Refactor arm_smmu_init_bypass_stes() to force bypass Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-04 12:42 ` [PATCH v9 10/11] iommu/arm-smmu-v3: Get associated RMR info and install bypass STE Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-04 12:42 ` [PATCH v9 11/11] iommu/arm-smmu: Get associated RMR info and install bypass SMR Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum
2022-04-04 12:42 ` Shameer Kolothum via iommu
2022-04-07 15:43 ` [PATCH v9 00/11] ACPI/IORT: Support for IORT RMR node Steven Price
2022-04-07 15:43 ` Steven Price
2022-04-07 15:43 ` Steven Price
2022-04-19 14:50 ` Laurentiu Tudor
2022-04-19 14:50 ` Laurentiu Tudor
2022-04-19 14:50 ` Laurentiu Tudor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl57LuiR0JC4AZrw@infradead.org \
--to=hch@infradead.org \
--cc=Sami.Mujawar@arm.com \
--cc=guohanjun@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jon@solid-run.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=steven.price@arm.com \
--cc=wanghuiqiang@huawei.com \
--cc=will@kernel.org \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.