From: LABBE Corentin <clabbe@baylibre.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jernej.skrabec@gmail.com, samuel@sholland.org, wens@csie.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 00/19] crypto: allwinner: lots of fixes
Date: Mon, 11 Apr 2022 10:37:10 +0200 [thread overview]
Message-ID: <YlPotuZilcnenky0@Red> (raw)
In-Reply-To: <YlPbbM7RurahUMn/@gondor.apana.org.au>
Le Mon, Apr 11, 2022 at 03:40:28PM +0800, Herbert Xu a écrit :
> On Mon, Apr 11, 2022 at 09:37:22AM +0200, LABBE Corentin wrote:
> >
> > Coul you give me more details ?
> > I do not have any sparse error.
>
> Did you compile with C=1? Anyway, for a start hash_pad is broken as
> it tries to store an le32 value into a u32.
Yes I compile with both W=1 and C=1.
But rigth, hash_pad takes a u32 but the origin variable bf is __le32, so perhaps it is why sparse dont see a problem.
Anyway I will fix hash_pad declaration.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jernej.skrabec@gmail.com, samuel@sholland.org, wens@csie.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 00/19] crypto: allwinner: lots of fixes
Date: Mon, 11 Apr 2022 10:37:10 +0200 [thread overview]
Message-ID: <YlPotuZilcnenky0@Red> (raw)
In-Reply-To: <YlPbbM7RurahUMn/@gondor.apana.org.au>
Le Mon, Apr 11, 2022 at 03:40:28PM +0800, Herbert Xu a écrit :
> On Mon, Apr 11, 2022 at 09:37:22AM +0200, LABBE Corentin wrote:
> >
> > Coul you give me more details ?
> > I do not have any sparse error.
>
> Did you compile with C=1? Anyway, for a start hash_pad is broken as
> it tries to store an le32 value into a u32.
Yes I compile with both W=1 and C=1.
But rigth, hash_pad takes a u32 but the origin variable bf is __le32, so perhaps it is why sparse dont see a problem.
Anyway I will fix hash_pad declaration.
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-11 8:37 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 20:55 [PATCH 00/19] crypto: allwinner: lots of fixes Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 01/19] crypto: sun8i-ce: Fix minor style issue Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 02/19] crypto: sun8i-ce: do not allocate memory when handling requests Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 03/19] crypto: sun4i-ss: do not allocate backup IV on requests Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 04/19] crypto: sun8i-ss: rework handling of IV Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 05/19] crypto: sun8i-ss: handle zero sized sg Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 06/19] crypto: sun8i-ss: remove redundant test Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 07/19] crypto: sun8i-ss: test error before assigning Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 08/19] crypto: sun8i-ss: use sg_nents_for_len Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 09/19] crypto: sun8i-ss: do not allocate memory when handling hash requests Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 10/19] crypto: sun8i-ss: do not zeroize all pad Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 11/19] crypto: sun8i-ss: handle requests if last block is not modulo 64 Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 12/19] crypto: sun8i-ss: rework debugging Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:55 ` [PATCH 13/19] crypto: sun8i-ss: Add function for handling hash padding Corentin Labbe
2022-03-17 20:55 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 14/19] crypto: sun8i-ss: add hmac(sha1) Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 15/19] crypto: sun8i-ss: do not fallback if cryptlen is less than sg length Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 16/19] crypto: sun8i-ce: Add function for handling hash padding Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 17/19] crypto: sun8i-ce: use sg_nents_for_len Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 18/19] crypto: sun8i-ce: rework debugging Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-03-17 20:56 ` [PATCH 19/19] crypto: sun8i-ce: do not fallback if cryptlen is less than sg length Corentin Labbe
2022-03-17 20:56 ` Corentin Labbe
2022-04-08 8:24 ` [PATCH 00/19] crypto: allwinner: lots of fixes Herbert Xu
2022-04-08 8:24 ` Herbert Xu
2022-04-11 7:37 ` LABBE Corentin
2022-04-11 7:37 ` LABBE Corentin
2022-04-11 7:40 ` Herbert Xu
2022-04-11 7:40 ` Herbert Xu
2022-04-11 8:37 ` LABBE Corentin [this message]
2022-04-11 8:37 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlPotuZilcnenky0@Red \
--to=clabbe@baylibre.com \
--cc=herbert@gondor.apana.org.au \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.