All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: ludovic.desroches@microchip.com, tudor.ambarus@microchip.com,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] dma: at_xdmac: fix a missing check on list iterator
Date: Mon, 11 Apr 2022 19:04:32 +0530	[thread overview]
Message-ID: <YlQuaFjt9TxlutRH@matsya> (raw)
In-Reply-To: <20220327061154.4867-1-xiam0nd.tong@gmail.com>

On 27-03-22, 14:11, Xiaomeng Tong wrote:
> The bug is here:
> 	__func__, desc, &desc->tx_dma_desc.phys, ret, cookie, residue);
> 
> The list iterator 'desc' will point to a bogus position containing
> HEAD if the list is empty or no element is found. To avoid dev_dbg()
> prints a invalid address, use a new variable 'iter' as the list
> iterator, while use the origin variable 'desc' as a dedicated
> pointer to point to the found element.

Applied, thanks

-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: ludovic.desroches@microchip.com, tudor.ambarus@microchip.com,
	linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] dma: at_xdmac: fix a missing check on list iterator
Date: Mon, 11 Apr 2022 19:04:32 +0530	[thread overview]
Message-ID: <YlQuaFjt9TxlutRH@matsya> (raw)
In-Reply-To: <20220327061154.4867-1-xiam0nd.tong@gmail.com>

On 27-03-22, 14:11, Xiaomeng Tong wrote:
> The bug is here:
> 	__func__, desc, &desc->tx_dma_desc.phys, ret, cookie, residue);
> 
> The list iterator 'desc' will point to a bogus position containing
> HEAD if the list is empty or no element is found. To avoid dev_dbg()
> prints a invalid address, use a new variable 'iter' as the list
> iterator, while use the origin variable 'desc' as a dedicated
> pointer to point to the found element.

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-11 13:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-27  6:11 [PATCH] dma: at_xdmac: fix a missing check on list iterator Xiaomeng Tong
2022-03-27  6:11 ` Xiaomeng Tong
2022-04-11 13:34 ` Vinod Koul [this message]
2022-04-11 13:34   ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlQuaFjt9TxlutRH@matsya \
    --to=vkoul@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=stable@vger.kernel.org \
    --cc=tudor.ambarus@microchip.com \
    --cc=xiam0nd.tong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.