Re: [PATCH] clk: imx: Add check for kcalloc

From: Abel Vesa <abel.vesa@nxp.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc: mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: imx: Add check for kcalloc
Date: Tue, 12 Apr 2022 14:01:26 +0300	[thread overview]
Message-ID: <YlVcBviIvBBId9WV@abelvesa> (raw)
In-Reply-To: <20220310080257.1988412-1-jiasheng@iscas.ac.cn>

On 22-03-10 16:02:57, Jiasheng Jiang wrote:
> As the potential failure of the kcalloc(),
> it should be better to check it in order to
> avoid the dereference of the NULL pointer.
>
> Fixes: 379c9a24cc23 ("clk: imx: Fix reparenting of UARTs not associated with stdout")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Applied, thanks!

> ---
>  drivers/clk/imx/clk.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/imx/clk.c b/drivers/clk/imx/clk.c
> index 7cc669934253..99249ab361d2 100644
> --- a/drivers/clk/imx/clk.c
> +++ b/drivers/clk/imx/clk.c
> @@ -173,6 +173,8 @@ void imx_register_uart_clocks(unsigned int clk_count)
>  		int i;
>
>  		imx_uart_clocks = kcalloc(clk_count, sizeof(struct clk *), GFP_KERNEL);
> +		if (!imx_uart_clocks)
> +			return;
>
>  		if (!of_stdout)
>  			return;
> --
> 2.25.1
>