Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface

From: "Maíra Canal" <maira.canal@usp.br>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	hongxing.zhu@nxp.com, robh@kernel.org, bhelgaas@google.com,
	helgaas@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, linux-imx@nxp.com,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] PCI: imx6: Replace legacy gpio interface for gpiod interface
Date: Tue, 12 Apr 2022 08:02:10 -0300	[thread overview]
Message-ID: <YlVcMlaZB00gg0nX@fedora> (raw)
In-Reply-To: <c8d3ed7196d09f5f6a61d605a94613f792ab501b.camel@pengutronix.de>

On 04/11, Lucas Stach wrote:
> Hi Maíra, hi Lorenzo,
> 
> Am Montag, dem 11.04.2022 um 13:59 +0200 schrieb Francesco Dolcini:
> > On Fri, Apr 08, 2022 at 11:46:32AM -0300, Maíra Canal wrote:
> > > On Fri, Apr 08, 2022 at 03:23:39PM +0100, Lorenzo Pieralisi wrote:
> > > > On Mon, Nov 01, 2021 at 10:03:11PM -0300, Maíra Canal wrote:
> > > > > Considering the current transition of the GPIO subsystem, remove all
> > > > > dependencies of the legacy GPIO interface (linux/gpio.h and linux
> > > > > /of_gpio.h) and replace it with the descriptor-based GPIO approach.
> > > > > 
> > > > > Signed-off-by: Maíra Canal <maira.canal@usp.br>
> > > > > ---
> > > > > V1 -> V2: Rewrite commit log and subject line to match PCI subsystem standard
> > > > > V2 -> v3: Change gpiod_set_value_cansleep for gpiod_set_raw_value_cansleep
> > > > > ---
> > > > >  drivers/pci/controller/dwc/pci-imx6.c | 30 +++++++++------------------
> > > > >  1 file changed, 10 insertions(+), 20 deletions(-)
> 
> ... they do conflict and I guess the functional fix for the reset
> sequence should have priority over this cleanup. Maíra, may I ask you
> to respin your patch as soon as Francescos fix is in? I promise to not
> let it fall through the cracks again.

Hi Lucas

That's fine. After Francescos patch is applied, I resend the fix.

Thank you for the feedback!

Sincerly,
Maíra Canal

> 
> Regards,
> Lucas
> 