All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Chen-Yu Tsai <wens@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
	David Airlie <airlied@linux.ie>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Maxime Ripard <mripard@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers
Date: Tue, 12 Apr 2022 13:16:57 -0500	[thread overview]
Message-ID: <YlXCGfA7DUbPPiXw@robh.at.kernel.org> (raw)
In-Reply-To: <c3287f86-636d-33dc-c763-1f28803704f5@redhat.com>

On Tue, Apr 12, 2022 at 10:12:32AM +0200, Javier Martinez Canillas wrote:
> On 4/12/22 10:07, Geert Uytterhoeven wrote:
> > Hi Javier,
> 
> [snip]
> 
> >>
> >> Do you have any hints here on how I should enforce this in the schema ?
> >>
> >> Or if you think that a comment is enough, then I will add it in v3.
> > 
> > I don't know how to make it required for SPI, if possible at all.
> >
> 
> I see. Let's go with a comment then and we can later enforce it, if someone
> knows if is possible / how to do it.

It's not possible unless we annotate child nodes with something from the 
parent. '$nodename' is the one and only example of that. 

Really, this falls below the bar of what I'm concerned about checking. 
Ask me again when the conversions are all done (only ~2K to go :( ).

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>, Chen-Yu Tsai <wens@kernel.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Mark Brown <broonie@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers
Date: Tue, 12 Apr 2022 13:16:57 -0500	[thread overview]
Message-ID: <YlXCGfA7DUbPPiXw@robh.at.kernel.org> (raw)
In-Reply-To: <c3287f86-636d-33dc-c763-1f28803704f5@redhat.com>

On Tue, Apr 12, 2022 at 10:12:32AM +0200, Javier Martinez Canillas wrote:
> On 4/12/22 10:07, Geert Uytterhoeven wrote:
> > Hi Javier,
> 
> [snip]
> 
> >>
> >> Do you have any hints here on how I should enforce this in the schema ?
> >>
> >> Or if you think that a comment is enough, then I will add it in v3.
> > 
> > I don't know how to make it required for SPI, if possible at all.
> >
> 
> I see. Let's go with a comment then and we can later enforce it, if someone
> knows if is possible / how to do it.

It's not possible unless we annotate child nodes with something from the 
parent. '$nodename' is the one and only example of that. 

Really, this falls below the bar of what I'm concerned about checking. 
Ask me again when the conversions are all done (only ~2K to go :( ).

Rob

  reply	other threads:[~2022-04-12 18:17 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 21:12 [PATCH v2 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-11 21:12 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Javier Martinez Canillas
2022-04-11 21:12   ` Javier Martinez Canillas
2022-04-12  7:13   ` Geert Uytterhoeven
2022-04-12  7:13     ` Geert Uytterhoeven
2022-04-12 11:28   ` Maxime Ripard
2022-04-12 11:28     ` Maxime Ripard
2022-04-12 12:48     ` Javier Martinez Canillas
2022-04-12 12:48       ` Javier Martinez Canillas
2022-04-12 12:07   ` Chen-Yu Tsai
2022-04-12 12:07     ` Chen-Yu Tsai
2022-04-12 12:49     ` Javier Martinez Canillas
2022-04-12 12:49       ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas
2022-04-11 21:12   ` Javier Martinez Canillas
2022-04-12  7:16   ` Geert Uytterhoeven
2022-04-12  7:16     ` Geert Uytterhoeven
2022-04-12  8:01     ` Javier Martinez Canillas
2022-04-12  8:01       ` Javier Martinez Canillas
2022-04-12  8:07       ` Geert Uytterhoeven
2022-04-12  8:07         ` Geert Uytterhoeven
2022-04-12  8:12         ` Javier Martinez Canillas
2022-04-12  8:12           ` Javier Martinez Canillas
2022-04-12 18:16           ` Rob Herring [this message]
2022-04-12 18:16             ` Rob Herring
2022-04-11 21:12 ` [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones Javier Martinez Canillas
2022-04-11 21:12   ` Javier Martinez Canillas
2022-04-12  7:19   ` Geert Uytterhoeven
2022-04-12  7:19     ` Geert Uytterhoeven
2022-04-12  8:03     ` Javier Martinez Canillas
2022-04-12  8:03       ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas
2022-04-11 21:12   ` Javier Martinez Canillas
2022-04-12  7:23   ` Geert Uytterhoeven
2022-04-12  7:23     ` Geert Uytterhoeven
2022-04-12  8:07     ` Javier Martinez Canillas
2022-04-12  8:07       ` Javier Martinez Canillas
2022-04-12 11:21       ` Andy Shevchenko
2022-04-12 11:21         ` Andy Shevchenko
2022-04-12 11:22         ` Andy Shevchenko
2022-04-12 11:22           ` Andy Shevchenko
2022-04-12 12:47           ` Javier Martinez Canillas
2022-04-12 12:45         ` Javier Martinez Canillas
2022-04-12 12:45           ` Javier Martinez Canillas
2022-04-12  7:25   ` kernel test robot
2022-04-12  7:25     ` kernel test robot
2022-04-11 21:12 ` [PATCH v2 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-11 21:12   ` Javier Martinez Canillas
2022-04-12  7:31   ` Geert Uytterhoeven
2022-04-12  7:31     ` Geert Uytterhoeven
2022-04-12  8:07     ` Javier Martinez Canillas
2022-04-12  8:07       ` Javier Martinez Canillas
2022-04-12  8:17   ` kernel test robot
2022-04-12  8:17     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlXCGfA7DUbPPiXw@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@linux.ie \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=javierm@redhat.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mripard@kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.