All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Drew Fustini <dfustini@baylibre.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Dave Gerlach <d-gerlach@ti.com>, Tony Lindgren <tony@atomide.com>,
	Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle gpio pin property
Date: Tue, 12 Apr 2022 14:54:27 -0500	[thread overview]
Message-ID: <YlXY88aJIrcHc5Bc@robh.at.kernel.org> (raw)
In-Reply-To: <20220409211215.2529387-2-dfustini@baylibre.com>

On Sat, Apr 09, 2022 at 02:12:14PM -0700, Drew Fustini wrote:
> Document Wakeup M3 IPC property that indicates a GPIO pin is connected
> to the enable pin on DDR VTT regulator and can be toggled during low
> power mode transitions.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> [dfustini: converted to YAML, removed unnecessary "ti,needs-vtt-toggle"]
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml     | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> index d855c01ce61c..7f4a75c5fcaa 100644
> --- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> @@ -24,6 +24,14 @@ description: |+
>    A wkup_m3_ipc device node is used to represent the IPC registers within an
>    SoC.
>  
> +  Support for VTT Toggle
> +  ==================================
> +  On some boards like the AM335x EVM-SK and the AM437x GP EVM, a GPIO pin is
> +  connected to the enable pin on the DDR VTT regulator. This allows the
> +  regulator to be disabled upon suspend and enabled upon resume. Please note
> +  that the GPIO pin must be part of the GPIO0 module as only this GPIO module
> +  is in the wakeup power domain.
> +
>  properties:
>    compatible:
>      enum:
> @@ -51,6 +59,10 @@ properties:
>        mbox_wkupm3 child node.
>      maxItems: 1
>  
> +  ti,vtt-gpio-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: GPIO pin connected to enable pin on VTT regulator

Looking at the driver, can't you add 'maximum: 31' here? If so, I can 
add it when applying.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Drew Fustini <dfustini@baylibre.com>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Dave Gerlach <d-gerlach@ti.com>, Tony Lindgren <tony@atomide.com>,
	Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle gpio pin property
Date: Tue, 12 Apr 2022 14:54:27 -0500	[thread overview]
Message-ID: <YlXY88aJIrcHc5Bc@robh.at.kernel.org> (raw)
In-Reply-To: <20220409211215.2529387-2-dfustini@baylibre.com>

On Sat, Apr 09, 2022 at 02:12:14PM -0700, Drew Fustini wrote:
> Document Wakeup M3 IPC property that indicates a GPIO pin is connected
> to the enable pin on DDR VTT regulator and can be toggled during low
> power mode transitions.
> 
> Signed-off-by: Dave Gerlach <d-gerlach@ti.com>
> [dfustini: converted to YAML, removed unnecessary "ti,needs-vtt-toggle"]
> Signed-off-by: Drew Fustini <dfustini@baylibre.com>
> ---
>  .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml     | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> index d855c01ce61c..7f4a75c5fcaa 100644
> --- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
> @@ -24,6 +24,14 @@ description: |+
>    A wkup_m3_ipc device node is used to represent the IPC registers within an
>    SoC.
>  
> +  Support for VTT Toggle
> +  ==================================
> +  On some boards like the AM335x EVM-SK and the AM437x GP EVM, a GPIO pin is
> +  connected to the enable pin on the DDR VTT regulator. This allows the
> +  regulator to be disabled upon suspend and enabled upon resume. Please note
> +  that the GPIO pin must be part of the GPIO0 module as only this GPIO module
> +  is in the wakeup power domain.
> +
>  properties:
>    compatible:
>      enum:
> @@ -51,6 +59,10 @@ properties:
>        mbox_wkupm3 child node.
>      maxItems: 1
>  
> +  ti,vtt-gpio-pin:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: GPIO pin connected to enable pin on VTT regulator

Looking at the driver, can't you add 'maximum: 31' here? If so, I can 
add it when applying.

Rob

  parent reply	other threads:[~2022-04-12 19:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09 21:12 [PATCH v2 0/2] soc: ti: wkup_m3_ipc: support vtt toggle Drew Fustini
2022-04-09 21:12 ` Drew Fustini
2022-04-09 21:12 ` [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle gpio pin property Drew Fustini
2022-04-09 21:12   ` Drew Fustini
2022-04-10 14:17   ` Krzysztof Kozlowski
2022-04-10 14:17     ` Krzysztof Kozlowski
2022-04-12 19:54   ` Rob Herring [this message]
2022-04-12 19:54     ` Rob Herring
2022-04-12 21:15     ` Drew Fustini
2022-04-12 21:15       ` Drew Fustini
2022-04-13 21:48   ` Rob Herring
2022-04-13 21:48     ` Rob Herring
2022-04-09 21:12 ` [PATCH v2 2/2] soc: ti: wkup_m3_ipc: Add support for toggling VTT regulator Drew Fustini
2022-04-09 21:12   ` Drew Fustini
2022-04-22 23:14 ` (subset) [PATCH v2 0/2] soc: ti: wkup_m3_ipc: support vtt toggle Nishanth Menon
2022-04-22 23:14   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlXY88aJIrcHc5Bc@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=d-gerlach@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dfustini@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.