Re: [LTP] [PATCH v3 5/5] busy_poll: Move TST_{SETUP, CLEANUP} to the tests

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

> On 29. 04. 22 20:09, Petr Vorel wrote:
> > I was thinking about it as well. Makes sense, but then it hides the fact that
> > busy_poll_lib.sh contain other API variables (missing TST_TESTFUNC suggest that
> > there are some variables in busy_poll_lib.sh). Anyway, I'm ok to move it there
> > as well, just document that sharing variables between library and test will be
> > always a bit problematic.

> Now that you mention the other variables in busy_poll_lib.sh, I guess
> that TST_MIN_KVER and TST_NEEDS_CMDS should use conditional expansion so
> that the values can be changed in the tests.
Makes sense. But I'd probably prefer to postpone this commit,
because TST_NEEDS_CMDS will be in more shell libraries.
Because even this cleanup so far wasn't my intention, I'd prefer to get it
merged soon so that I can post rebased fixes for tst_net.sh with disabled IPv6
(to get them merged before release).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp