All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 5/5] busy_poll: Move TST_{SETUP, CLEANUP} to the tests
Date: Fri, 29 Apr 2022 20:09:29 +0200	[thread overview]
Message-ID: <Ymwp2cilZtjn+g3y@pevik> (raw)
In-Reply-To: <539e2eb7-05d5-470c-3287-b1e9b7220532@suse.cz>

Hi Martin,

> Hi,
> TST_TESTFUNC should be moved to individual test scripts as well, for the
> same reason. Other than that, the whole patchset looks good:

I was thinking about it as well. Makes sense, but then it hides the fact that
busy_poll_lib.sh contain other API variables (missing TST_TESTFUNC suggest that
there are some variables in busy_poll_lib.sh). Anyway, I'm ok to move it there
as well, just document that sharing variables between library and test will be
always a bit problematic.

> Reviewed-by: Martin Doucha <mdoucha@suse.cz>

Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-04-29 18:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  6:56 [LTP] [PATCH v3 5/5] busy_poll: Move TST_{SETUP, CLEANUP} to the tests Petr Vorel
2022-04-29 16:05 ` Martin Doucha
2022-04-29 18:09   ` Petr Vorel [this message]
2022-05-02  8:54     ` Martin Doucha
2022-05-02 13:50       ` Petr Vorel
2022-05-02 14:00         ` Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Ymwp2cilZtjn+g3y@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.