From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Andrea Bolognani <abologna@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>
Subject: Re: [PATCH 2/3] qapi: Fix documentation for query-xen-replication-status
Date: Wed, 20 Apr 2022 16:41:04 +0100 [thread overview]
Message-ID: <YmApkGQI0C/R195u@work-vm> (raw)
In-Reply-To: <20220420153408.243584-3-abologna@redhat.com>
* Andrea Bolognani (abologna@redhat.com) wrote:
> The correct return type is ReplicationStatus, not
> ReplicationResult.
>
> Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Hmm yes I think that's right.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> qapi/migration.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 27d7b28158..409eb086a2 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1619,7 +1619,7 @@
> #
> # Query replication status while the vm is running.
> #
> -# Returns: A @ReplicationResult object showing the status.
> +# Returns: A @ReplicationStatus object showing the status.
> #
> # Example:
> #
> --
> 2.35.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2022-04-20 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 15:34 [PATCH 0/3] qapi: Random small fixes Andrea Bolognani
2022-04-20 15:34 ` [PATCH 1/3] docs: qapi: Remove outdated reference to simple unions Andrea Bolognani
2022-04-20 15:34 ` [PATCH 2/3] qapi: Fix documentation for query-xen-replication-status Andrea Bolognani
2022-04-20 15:41 ` Dr. David Alan Gilbert [this message]
2022-04-20 15:34 ` [PATCH 3/3] qapi: Fix typo Andrea Bolognani
2022-04-21 8:21 ` [PATCH 0/3] qapi: Random small fixes Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmApkGQI0C/R195u@work-vm \
--to=dgilbert@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.